Abstract beans now require a class

22 views
Skip to first unread message

Chris Blackwell

unread,
Jan 22, 2012, 2:27:53 PM1/22/12
to ColdSpring-Users
I'm trying to get ModelGlue working with CS2 and as part of the core
MG configs we use abstract bean definitions to reduce duplication of
common constructor arguments. here's an example

<!-- this is used by all request phases -->
<bean id="modelglue.AbstractRequestPhase" abstract="true">
<constructor-arg name="moduleLoaderFactory">
<ref bean="modelglue.ModuleLoaderFactory" />
</constructor-arg>
</bean>

<bean id="modelglue.InitializationPhase"
class="ModelGlue.gesture.eventrequest.phase.Initialization"
parent="modelglue.AbstractRequestPhase">
<constructor-arg name="modules">
<list>
<value>/ModelGlue/gesture/modules/internal/initialization/config/
initialization.xml</value>
<value>/ModelGlue/gesture/modules/orm/config/ModelGlue.xml</value>
</list>
</constructor-arg>
</bean>

In CS1.2 you don't need to declare a class for an abstract bean
because it (should) never be instantiated. CS2 requires it to have a
class attribute that points to a valid cfc. The class doesn't have to
be anything more than a stub to get it working.

Is this an intended change or just an incompatibility ?

Cheers, Chris

Mark Mandel

unread,
Jan 22, 2012, 4:17:03 PM1/22/12
to coldspri...@googlegroups.com
Sounds like a legitimate bug. I can't think of any reason an abstract bean should need a class.

I will investigate and get back to you.

Mark


--
You received this message because you are subscribed to the Google Groups "ColdSpring-Users" group.
To post to this group, send email to coldspri...@googlegroups.com.
To unsubscribe from this group, send email to coldspring-use...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/coldspring-users?hl=en.




--
E: mark....@gmail.com
T: http://www.twitter.com/neurotic
W: www.compoundtheory.com

2 Devs from Down Under Podcast

Mark Mandel

unread,
Jan 23, 2012, 3:12:01 AM1/23/12
to coldspri...@googlegroups.com
Yup. Legitimate bug.

Fix incoming shortly.  Thanks for finding a reporting!

Mark

Mark Mandel

unread,
Jan 23, 2012, 6:35:12 PM1/23/12
to coldspri...@googlegroups.com
Fix uploaded to develop. Let me know if it solves your issue:

Mark

Chris Blackwell

unread,
Jan 24, 2012, 7:50:41 AM1/24/12
to coldspri...@googlegroups.com
Thanks Mark, that now works

As an aside, I'm not sure what the official ModelGlue line is on support for CS2, but i'd like to at least think about a creating a patch even if support can't be baked in. Is the api for cs2 now in a pretty final state? 

Cheers, Chris

Mark Mandel

unread,
Jan 24, 2012, 7:54:14 AM1/24/12
to coldspri...@googlegroups.com
Yeah, I can't see much changing, unless it's additions at the moment.

There is a minor feature enhancement to the SessionWrapper for ORM in the pipeline, and an advanced example app to be written... and that should complete Alpha2. From there, it's just a RC for final bug fixes, and then a 2.0 release.

Mark
Reply all
Reply to author
Forward
0 new messages