[PATCH 2/2] dict: add "mannor->manor"

5 views
Skip to first unread message

Jonathan Neuschäfer

unread,
Oct 15, 2011, 8:39:24 AM10/15/11
to code...@googlegroups.com, Jonathan Neuschäfer
---
data/dictionary.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/data/dictionary.txt b/data/dictionary.txt
index f65b73a..8a9686b 100644
--- a/data/dictionary.txt
+++ b/data/dictionary.txt
@@ -2289,7 +2289,7 @@ maneouvred->manoeuvred
maneouvres->manoeuvres
maneouvring->manoeuvring
manisfestations->manifestations
-mannor->manner
+mannor->manner, manor,
manoeuverability->maneuverability
manouver->maneuver, manoeuvre,
manouverability->maneuverability, manoeuvrability, manoeuverability,
--
1.7.7

Jonathan Neuschäfer

unread,
Oct 15, 2011, 8:39:23 AM10/15/11
to code...@googlegroups.com, Jonathan Neuschäfer
---
data/dictionary.txt | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/data/dictionary.txt b/data/dictionary.txt
index 895a5cf..f65b73a 100644
--- a/data/dictionary.txt
+++ b/data/dictionary.txt
@@ -3537,6 +3537,7 @@ sovereignity->sovereignty
soverign->sovereign
soverignity->sovereignty
soverignty->sovereignty
+spagetti->spaghetti
spainish->Spanish
speach->speech
specfic->specific
--
1.7.7

Jonathan Neuschäfer

unread,
Oct 15, 2011, 10:47:52 AM10/15/11
to code...@googlegroups.com, Jonathan Neuschäfer
This patch is a bit unfortunate, in that "time" is (probably) a more
common word in source code than "item" (although "item" isn't really
uncommon, either)

---
data/dictionary.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/data/dictionary.txt b/data/dictionary.txt
index 8a9686b..d0b96db 100644
--- a/data/dictionary.txt
+++ b/data/dictionary.txt
@@ -3850,7 +3850,7 @@ thsi->this
thsoe->those
thta->that
thyat->that
-tiem->time
+tiem->time, item,
tihkn->think
tihs->this
timne->time
--
1.7.7

Lucas De Marchi

unread,
Oct 15, 2011, 11:09:54 AM10/15/11
to code...@googlegroups.com, Jonathan Neuschäfer
Hi Jonathan,

On Sat, Oct 15, 2011 at 11:47, Jonathan Neuschäfer
<j.neus...@gmx.net> wrote:
> This patch is a bit unfortunate, in that "time" is (probably) a more
> common word in source code than "item" (although "item" isn't really
> uncommon, either)
> ---
>  data/dictionary.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Could you provide some numbers regarding this? Time appears very
often, so maybe it's better to let as is and revert changes that
should be converted to 'item' instead.

A quick grep in Linux kernel gives me:

$ git grep -ie "\<item\>" | wc -l
5749
$ git grep -ie "\<time\>" | wc -l
22757


thanks,

Lucas De Marchi

Lucas De Marchi

unread,
Oct 15, 2011, 11:10:55 AM10/15/11
to code...@googlegroups.com, Jonathan Neuschäfer
Hi Jonathan,

On Sat, Oct 15, 2011 at 09:39, Jonathan Neuschäfer
<j.neus...@gmx.net> wrote:
> ---
>  data/dictionary.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>


Both patches have been applied.

Thanks,
Lucas De Marchi

Jonathan Neuschäfer

unread,
Oct 17, 2011, 1:05:19 PM10/17/11
to Lucas De Marchi, code...@googlegroups.com, Jonathan Neuschäfer

GitHub search gave me the following results:
time: 23363162
item: 14919703 (63.86% of the result for "time")

But that's not really words, it also matches things like "time_step".

Thanks,
Jonathan Neuschäfer

Jonathan Neuschäfer

unread,
Oct 17, 2011, 2:35:10 PM10/17/11
to Lucas De Marchi, code...@googlegroups.com, Jonathan Neuschäfer
On Sat, Oct 15, 2011 at 02:39:24PM +0200, Jonathan Neuschäfer wrote:
> +mannor->manner, manor,

This patch probably worth reverting.

Since a "manor" is a type of "estate in land" [0], the word is
practically found nowhere but in adventure games (I was reviewing
codespell output of one when I found the word).

GitHub search also suggests that reverting this patch is a good idea:
manner: 470525 results
manor: 9884 results (2.1% of the results for "manner")

[0] http://en.wikipedia.org/wiki/Manor


Sorry for the noise,
Jonathan Neuschäfer

Lucas De Marchi

unread,
Oct 19, 2011, 12:04:12 AM10/19/11
to Jonathan Neuschäfer, code...@googlegroups.com
Hi Jonathan,

No problem. Path has been reverted.


thanks
Lucas De Marchi

Lucas De Marchi

unread,
Oct 19, 2011, 12:07:47 AM10/19/11
to Jonathan Neuschäfer, code...@googlegroups.com
Hi Jonathan,


Patch has been applied. Thanks.


Lucas De Marchi

Reply all
Reply to author
Forward
0 new messages