Cleanup appengine_config.py (issue 5672068)

[tech...@gmail.com]

Reviewers: Andi Albrecht, M-A,

Description:
Cleanup appengine_config.py

Please review this at http://codereview.appspot.com/5672068/

Affected files:
M appengine_config.py

Index: appengine_config.py
===================================================================
--- a/appengine_config.py
+++ b/appengine_config.py
@@ -35,14 +35,8 @@
from google.appengine.dist import use_library
use_library('django', '1.2')

-# Fail early if we can't import Django 1.x. Log identifying information.
-import django
-logging.info('django.__file__ = %r, django.VERSION = %r',
- django.__file__, django.VERSION)
-assert django.VERSION[0] >= 1, "This Django version is too old"
+# Django configuration module needs to be set explicitly as a workaround
+# http://code.google.com/p/googleappengine/issues/detail?id=5795
+os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'
+# NOTE: All "main" scripts must import webapp.template before django.

-# Custom Django configuration.
-# NOTE: All "main" scripts must import webapp.template before django.
-os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'
-from django.conf import settings
-settings._target = None

[tech...@gmail.com]

Works fine for my local install. Forgot to add Guido - maybe he has
objections as he is the author. If no objections, I'll commit in a few
days.

http://codereview.appspot.com/5672068/

[gvanr...@gmail.com]

LGTM (though I have no idea what the bug you quote in the comment is
about).

http://codereview.appspot.com/5672068/

[albrec...@googlemail.com]

On 2012/02/16 17:39:07, GvR wrote:
> LGTM (though I have no idea what the bug you quote in the comment is
about).

I don't see a bug here too. Settings DJANGO_SETTINGS_MODULE is common
practice when setting up a Django environment manually.

http://codereview.appspot.com/5672068/

[tech...@gmail.com]

The stacktrace described in the bug appears in my 1.6.0 SDK when you
first load http://localhost:8080/_ah/stats and then
http://localhost:8080 without setting

os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'

See http://paste.kde.org/423776/

I've recheck with 1.6.2. It is still actual and magic. On page refresh
traceback changes to http://paste.kde.org/423782/

http://codereview.appspot.com/5672068/

[tech...@gmail.com]

"Django 1.1 requires that the DJANGO_SETTINGS_MODULE environment
variable be set.."
http://code.google.com/appengine/docs/python/tools/libraries.html#Django
Updated patch with a correct comment. Will commit right now.

What a timewaste. :sad:

I only wonder if the requirement for all "main" scripts to import
webapp.template before django is still actual?

http://codereview.appspot.com/5672068/

[tech...@gmail.com]

Committed as a7a7f3bb87.

http://codereview.appspot.com/5672068/

[Guido van Rossum]

On Thu, Feb 16, 2012 at 10:07 PM, <tech...@gmail.com> wrote:
> I only wonder if the requirement for all "main" scripts to import
> webapp.template before django is still actual?

Switch to Python 2.7 and you won't need this any more...

--
--Guido van Rossum (python.org/~guido)