Issue 351 in rietveld: upload.py: send emails to reviewers on issue update

1 view
Skip to first unread message

riet...@googlecode.com

unread,
Dec 16, 2011, 4:36:28 AM12/16/11
to coderev...@googlegroups.com
Status: New
Owner: tech...@gmail.com
Labels: Type-Defect Priority-Medium

New issue 351 by tech...@gmail.com: upload.py: send emails to reviewers
on issue update
http://code.google.com/p/rietveld/issues/detail?id=351

upload.py is now able to add messages to issue threads on issue update, but
doesn't send notification mails when --send_mail option is provided. This
should be fixed.

riet...@googlecode.com

unread,
Dec 16, 2011, 4:52:46 AM12/16/11
to coderev...@googlegroups.com

Comment #1 on issue 351 by tech...@gmail.com: upload.py: send emails to

The "task_complete" call is most likely the best place to implement it. See
http://codereview.appspot.com/5476044/#msg2

riet...@googlecode.com

unread,
Feb 21, 2012, 2:24:44 AM2/21/12
to coderev...@googlegroups.com
Updates:
Status: Accepted

Comment #2 on issue 351 by albrecht.andi: upload.py: send emails to

Patch: http://codereview.appspot.com/5687062/

riet...@googlecode.com

unread,
Apr 6, 2012, 5:08:24 PM4/6/12
to coderev...@googlegroups.com
Updates:
Status: Fixed

Comment #4 on issue 351 by albrecht.andi: upload.py: send emails to

This issue was closed by revision 9ea01dc1c46e.

Reply all
Reply to author
Forward
0 new messages