Re: Add message from upload.py when updating an issue (fixes issue351). (issue 5687062)
0 views
Skip to first unread message
Andi Albrecht
Feb 22, 2012, 1:42:17 PM2/22/12
to albrec...@googlemail.com, tech...@gmail.com, gvanr...@gmail.com, mar...@chromium.org, coderev...@googlegroups.com, re...@codereview-hr.appspotmail.com
On Tue, Feb 21, 2012 at 9:52 PM, <mar...@chromium.org> wrote:
> On 2012/02/21 14:50:33, Andi Albrecht wrote:
>>
>> http://codereview.appspot.com/5687062/diff/1/upload.py
>> File upload.py (right):
>
>
>> http://codereview.appspot.com/5687062/diff/1/upload.py#newcode2261
>> upload.py:2261: message = message or title
>> @M-A: Do we mix up message and title here?
>
>
> Yes. Let me fix our tools first.
> On 2012/02/21 14:50:33, Andi Albrecht wrote:
>>
>> http://codereview.appspot.com/5687062/diff/1/upload.py
>> File upload.py (right):
>
>
>> http://codereview.appspot.com/5687062/diff/1/upload.py#newcode2261
>> upload.py:2261: message = message or title
>> @M-A: Do we mix up message and title here?
>
>
> Yes. Let me fix our tools first.
sure, let me know when you're ready - But I don't really understand
how this mix up blocks the change in this changeset :)
Reply all
Reply to author
Forward
0 new messages