Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.

[riet...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium Usability

New issue 401 by bsalo...@google.com: Chat sends notifications for my own
rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

I get chat notifications every time I interact with rietveld. These aren't
really useful since I know what I've done. Given that I interact with
rietveld quite a bit this can get annoying. Is it possible to make the chat
bot only notify me when someone else has modified an issue that pertains to
me?

[riet...@googlecode.com]

Updates:
Labels: Easy

Comment #1 on issue 401 by tech...@gmail.com: Chat sends notifications

for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

That's possible. When sending message we can exclude 'me' from the
recipients. It can be even made optional by adding user preference, but for
me it looks like a good default behavior.

[riet...@googlecode.com]

Comment #2 on issue 401 by bsalo...@google.com: Chat sends notifications

for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

Great! Could this rule also apply to emails? It's not quite as bothersome
to get email updates from my own activity but they also seem unnecessary.

[riet...@googlecode.com]

Comment #3 on issue 401 by tech...@gmail.com: Chat sends notifications

for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

AFAIK the code that sends the message is the same as the one that sends the
email and it is located in _notify_issue()
http://code.google.com/p/rietveld/source/browse/codereview/views.py#613

[riet...@googlecode.com]

Comment #4 on issue 401 by rmis...@google.com: Chat sends notifications for

my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

I am starting to take a look at this.
I can make sure that XMPP messages are not sent to the requester, but for
emails I already see that there is a safeguard to make sure the original
requester is not emailed again, I think what you see in your emails is your
email to the other members of the issue and not an email to yourself.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[riet...@googlecode.com]

Comment #5 on issue 401 by bsalo...@google.com: Chat sends notifications

for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

I think you're right. The emails are showing up because skia-review is in
the CC list.

[riet...@googlecode.com]

Comment #6 on issue 401 by rmis...@google.com: Chat sends notifications for

my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

Started in https://codereview.appspot.com/8099046/

[riet...@googlecode.com]

Updates:
Status: Fixed

Comment #7 on issue 401 by tech...@gmail.com: Chat sends notifications

for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

This issue was closed by revision 9d5c30b9d19f.