Issue 382 in rietveld: Please give me back my arrow keys

[riet...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 382 by er...@chromium.org: Please give me back my arrow keys
http://code.google.com/p/rietveld/issues/detail?id=382

CL http://code.google.com/p/rietveld/source/detail?r=140baeb01745 added a
feature that takes over the arrow keys to make them move the focus instead
of scrolling. I can see that some people might want this feature [I don't
personally], but could you please switch to using some other keys?

Scrolling by arrow key is a cross-browser standard that's fundamental to
how many of us navigate web pages. Now if I want to scroll at a reasonable
pace, or by a controlled amount, I need to use the mouse. Before this I
could just use my keyboard, which I much prefer.

What browser are you using? What version? On what operating system?

I'm on Chrome 19.0.1084.41 beta on Linux at the moment.

At what URL are you accessing Rietveld? (e.g. codereview.appspot.com)

https://chromiumcodereview.appspot.com

[riet...@googlecode.com]

Updates:
Status: Accepted
Owner: albrecht.andi

Comment #1 on issue 382 by gu...@google.com: Please give me back my arrow
keys
http://code.google.com/p/rietveld/issues/detail?id=382

I have to agree that something's not quite right with this feature. The
way we had it implemented in Mondrian, moving the blue marker down by one
line would simultaneously scroll the window up the same amount. But the
way it's done now in Rietveld, the blue marker moves all the way to the top
or bottom of the window before scrolling occurs, and then it jumps by
almost a whole page. Also, I find that in Firefox (FF 12.0 on Linux at
least) the page up/down keys have stopped working.

Andi, can you revisit this? I think that some previous recent complaints
about the blue marker also had to do with this -- I'd forgotten that there
was a functionality change. Or perhaps something else more recently made
it worse??? I don't recall noticing this during the review.

[riet...@googlecode.com]

Comment #2 on issue 382 by er...@chromium.org: Please give me back my arrow
keys
http://code.google.com/p/rietveld/issues/detail?id=382

If the screen still scrolled as normal, I certainly wouldn't mind that the
marker moved in the opposite direction.

[riet...@googlecode.com]

Updates:
Labels: Component-UI

Comment #3 on issue 382 by albrecht.andi: Please give me back my arrow keys
http://code.google.com/p/rietveld/issues/detail?id=382

Agreed, this came up so often in the last few weeks, I'll have a look at it
ASAP.

[riet...@googlecode.com]

Comment #4 on issue 382 by albrecht.andi: Please give me back my arrow keys
http://code.google.com/p/rietveld/issues/detail?id=382

I've uploaded a modified version that scrolls immediately to my test
instance: See for example http://rvtests.appspot.com/73842/diff/1/upload.py

Is this behavior better?

[riet...@googlecode.com]

Comment #5 on issue 382 by er...@chromium.org: Please give me back my arrow
keys
http://code.google.com/p/rietveld/issues/detail?id=382

Yes, it's much better.
It's a significantly slower scroll than a normal web page, which is a
little odd, but I can deal with that.

Thanks!

[riet...@googlecode.com]

Comment #6 on issue 382 by albrecht.andi: Please give me back my arrow keys
http://code.google.com/p/rietveld/issues/detail?id=382

Review: http://codereview.appspot.com/6221068

[riet...@googlecode.com]

Updates:
Status: Fixed

Comment #7 on issue 382 by albrecht.andi: Please give me back my arrow keys
http://code.google.com/p/rietveld/issues/detail?id=382

This issue was closed by revision d86fc9600d63.