Issue 378 in rietveld: Up and down arrow no longer scroll the diff page as expected

[riet...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 378 by art.yer...@gmail.com: Up and down arrow no longer scroll
the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

What steps will reproduce the problem?
1. Press down arrow
2. A highlight line appears in the code area, rather than scrolling the
window

What is the expected output? What do you see instead?
I expect the browser to scroll the window down

What browser are you using? What version? On what operating system?
Firefox 12.0 OSX

At what URL are you accessing Rietveld? (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).
http://cr.bittorrent.com/7870014/diff/10001/bittorrent.cpp

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***


Please provide any additional information below.
It'd be nice if users could turn the highlight line off and just have
arrows be arrows.

[riet...@googlecode.com]

Comment #1 on issue 378 by albrecht.andi: Up and down arrow no longer

scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

This change was intentional (see revision 140baeb01745) to allow line by
line navigation and addin comments by pressing "Enter" on every line. Why
do you think that this behavior differs so much from the default browser
behavior?

[riet...@googlecode.com]

Updates:
Status: Invalid

Comment #2 on issue 378 by gvanros...@gmail.com: Up and down arrow no

longer scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

Working as intended.

[riet...@googlecode.com]

Comment #3 on issue 378 by art.yer...@gmail.com: Up and down arrow no

longer scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

Because I use the arrow keys to scroll the page of diffs as a whole. Now
in order to get the first scroll down, I have to scroll below the entire
first page, one line at a time. Also, this skips over blocks of
commentary, which could be quite long. Perhaps I'm reading a long block of
reviewer's comments and want to scroll through them.

Also, the scrolling, when the highlight line moves off the screen, is emacs
style half-page at a time, whereas the arrow keys generally scroll 2 or 3
lines at a time, depending on text size.

Maybe I'm in the minority, but I think it's kind of jarring when a web page
takes an action on one of the standard keys on the keyboard. It'd be
different if the highlight line could be selected with the mouse, reacted
to pageup and pagedown, allowed focusing and scrolling through commentary,
and reacted to the overall page scrollbars on the document, as that'd at
least work as expected.

Here's an experiment: Press Up or down once, scroll to the bottom of a diff
page using the browser scroll bar, now press up again. I think you can
easily observe that it isn't the same as in a normal web page.

[riet...@googlecode.com]

Comment #4 on issue 378 by gvanros...@gmail.com: Up and down arrow no

longer scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

We can't make everyone happy, sorry.

[riet...@googlecode.com]

Comment #5 on issue 378 by art.yer...@gmail.com: Up and down arrow no

longer scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

You encouraged me to try out noscript, so it's not a total loss, I suppose.

[riet...@googlecode.com]

Comment #6 on issue 378 by gvanros...@gmail.com: Up and down arrow no

longer scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

Issue 380 has been merged into this issue.

[riet...@googlecode.com]

Comment #7 on issue 378 by ma...@chromium.org: Up and down arrow no longer

scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

You could make most people happy by using a different set of keys for the
line by line navigation and leaving arrow keys as they should be.

[riet...@googlecode.com]

Comment #8 on issue 378 by gvanros...@gmail.com: Up and down arrow no

longer scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

That would make most current users unhappy though. And no, I'm not going to
add a config option.

[riet...@googlecode.com]

Comment #9 on issue 378 by tech...@gmail.com: Up and down arrow no longer

scroll the diff page as expected
http://code.google.com/p/rietveld/issues/detail?id=378

I'd say we - open two issues and propose people to vote for it.