[rietveld] 4 new revisions pushed by albrecht.andi on 2012-05-24 18:25 GMT

[riet...@googlecode.com]

4 new revisions:

Revision: 04f258615e79
Author: Andi Albrecht <albrec...@gmail.com>
Date: Tue May 8 00:38:06 2012
Log: Print out posted data when XSRF token is invalid (issue361).
http://code.google.com/p/rietveld/source/detail?r=04f258615e79

Revision: cf21dfaa47f1
Author: Andi Albrecht <albrec...@gmail.com>
Date: Wed May 23 00:08:29 2012
Log: Automated merge with file:///home/andi/devel/rietveld/master
http://code.google.com/p/rietveld/source/detail?r=cf21dfaa47f1

Revision: d86fc9600d63
Author: Andi Albrecht <albrec...@gmail.com>
Date: Thu May 24 11:23:53 2012
Log: Move viewport on arrow key press (fixes issue382)....
http://code.google.com/p/rietveld/source/detail?r=d86fc9600d63

Revision: de97e688a806
Author: Andi Albrecht <albrec...@gmail.com>
Date: Thu May 24 11:24:52 2012
Log: Merged.
http://code.google.com/p/rietveld/source/detail?r=de97e688a806

==============================================================================
Revision: 04f258615e79
Author: Andi Albrecht <albrec...@gmail.com>
Date: Tue May 8 00:38:06 2012
Log: Print out posted data when XSRF token is invalid (issue361).
http://code.google.com/p/rietveld/source/detail?r=04f258615e79

Modified:
/codereview/views.py

=======================================
--- /codereview/views.py Fri Apr 6 14:07:20 2012
+++ /codereview/views.py Tue May 8 00:38:06 2012
@@ -681,7 +681,16 @@
# Try the previous hour's token
xsrf_token = account.get_xsrf_token(-1)
if post_token != xsrf_token:
- return HttpTextResponse('Invalid XSRF token.', status=403)
+ msg = [u'Invalid XSRF token.']
+ if request.POST:
+ msg.extend([u'',
+ u'However, this was the data posted to the
server:',
+ u''])
+ for key in request.POST:
+ msg.append(u'%s: %s' % (key, request.POST[key]))
+ msg.extend([u'', u'-'*10,
+ u'Please reload the previous page and post
again.'])
+ return HttpTextResponse(u'\n'.join(msg), status=403)
return func(request, *args, **kwds)

return xsrf_wrapper

==============================================================================
Revision: cf21dfaa47f1
Author: Andi Albrecht <albrec...@gmail.com>
Date: Wed May 23 00:08:29 2012
Log: Automated merge with file:///home/andi/devel/rietveld/master
http://code.google.com/p/rietveld/source/detail?r=cf21dfaa47f1



==============================================================================
Revision: d86fc9600d63
Author: Andi Albrecht <albrec...@gmail.com>
Date: Thu May 24 11:23:53 2012
Log: Move viewport on arrow key press (fixes issue382).

Review: http://codereview.appspot.com/6221068/
http://code.google.com/p/rietveld/source/detail?r=d86fc9600d63

Modified:
/static/script.js

=======================================
--- /static/script.js Sat Mar 3 13:06:04 2012
+++ /static/script.js Thu May 24 11:23:53 2012
@@ -1737,9 +1737,7 @@
var tr = codeRows[hookIdx];
if (tr) {
this.updateIndicator_(tr);
- if (!M_isElementVisible(this.win, tr)) {
- M_scrollIntoView(this.win, tr, direction);
- }
+ M_scrollIntoView(this.win, tr, direction);
}
}


==============================================================================
Revision: de97e688a806
Author: Andi Albrecht <albrec...@gmail.com>
Date: Thu May 24 11:24:52 2012
Log: Merged.
http://code.google.com/p/rietveld/source/detail?r=de97e688a806