Issue 385 in rietveld: upload.py should use OAuth 2.0

11 views
Skip to first unread message

riet...@googlecode.com

unread,
Jun 1, 2012, 9:13:37 PM6/1/12
to coderev...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 385 by mdemp...@google.com: upload.py should use OAuth 2.0
http://code.google.com/p/rietveld/issues/detail?id=385

ClientLogin is deprecated; see
https://developers.google.com/accounts/docs/AuthForInstalledApps

upload.py should switch to using OAuth 2.0 instead.

riet...@googlecode.com

unread,
Jan 21, 2013, 8:39:27 PM1/21/13
to coderev...@googlegroups.com

Comment #1 on issue 385 by dhe...@google.com: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

I'd be happy to do this.

riet...@googlecode.com

unread,
Jan 24, 2013, 5:53:52 AM1/24/13
to coderev...@googlegroups.com

riet...@googlecode.com

unread,
Jan 24, 2013, 6:26:48 AM1/24/13
to coderev...@googlegroups.com
Updates:
Labels: -Type-Defect Type-Task

Comment #3 on issue 385 by albrecht.andi: upload.py should use OAuth 2.0
http://code.google.com/p/rietveld/issues/detail?id=385

Since ClientLogin is deprecated, we should do something until somewhere in
2014.

But I find it quite important that we are able to communicate with the
server without any additional dependencies other than what comes with the
Python standard library.

It seems quite common that projects which use Rietveld just place a copy of
upload.py (eventually with some project-specific customizations) in
their "tools" folder and it just works without any additional setup. IMO it
would be great if we could keep this working that way.

riet...@googlecode.com

unread,
Jan 24, 2013, 8:19:16 AM1/24/13
to coderev...@googlegroups.com

Comment #4 on issue 385 by tech...@gmail.com: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

I am +1 for self-sufficient upload.py

riet...@googlecode.com

unread,
Jan 24, 2013, 12:39:45 PM1/24/13
to coderev...@googlegroups.com

Comment #5 on issue 385 by dhe...@google.com: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

Yes, that's my plan. Most of the niceties of google-api-python-client can
be stripped away.

riet...@googlecode.com

unread,
Feb 15, 2013, 5:09:57 PM2/15/13
to coderev...@googlegroups.com

Comment #6 on issue 385 by dhe...@google.com: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

The server side part has begun in:
https://codereview.appspot.com/7326049

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

riet...@googlecode.com

unread,
Feb 15, 2013, 5:12:49 PM2/15/13
to coderev...@googlegroups.com

Comment #7 on issue 385 by dhe...@google.com: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

RE: Andi Albrecht comment about adding a copy of upload.py, it's fairly
easy to distribute an entire package as an executable by zipping up a
folder, so long as that folder contains a __main__.py file.

riet...@googlecode.com

unread,
May 9, 2013, 8:45:23 PM5/9/13
to coderev...@googlegroups.com

Comment #8 on issue 385 by kpreid.switchb.org: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

Isn't this now Fixed?

riet...@googlecode.com

unread,
May 9, 2013, 9:47:46 PM5/9/13
to coderev...@googlegroups.com

Comment #9 on issue 385 by dhe...@google.com: upload.py should use OAuth
2.0
http://code.google.com/p/rietveld/issues/detail?id=385

Indeed. w00t!

riet...@googlecode.com

unread,
May 10, 2013, 12:11:03 AM5/10/13
to coderev...@googlegroups.com
Updates:
Status: Fixed

Comment #10 on issue 385 by albrecht.andi: upload.py should use OAuth 2.0
http://code.google.com/p/rietveld/issues/detail?id=385

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages