Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
codereview-list
Home
+ new post
About this group
Join this group
Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
rietv...@googlecode.com  
View profile  
 More options Oct 31 2012, 12:37 pm
From: rietv...@googlecode.com
Date: Wed, 31 Oct 2012 16:37:36 +0000
Local: Wed, Oct 31 2012 12:37 pm
Subject: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author
Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium Usability

New issue 401 by bsalo...@google.com: Chat sends notifications for my own  
rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

I get chat notifications every time I interact with rietveld. These aren't  
really useful since I know what I've done. Given that I interact with  
rietveld quite a bit this can get annoying. Is it possible to make the chat  
bot only notify me when someone else has modified an issue that pertains to  
me?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Oct 31 2012, 3:19 pm
From: rietv...@googlecode.com
Date: Wed, 31 Oct 2012 19:19:01 +0000
Local: Wed, Oct 31 2012 3:19 pm
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author
Updates:
        Labels: Easy

Comment #1 on issue 401 by techto...@gmail.com: Chat sends notifications  
for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

That's possible. When sending message we can exclude 'me' from the  
recipients. It can be even made optional by adding user preference, but for  
me it looks like a good default behavior.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Oct 31 2012, 3:27 pm
From: rietv...@googlecode.com
Date: Wed, 31 Oct 2012 19:27:48 +0000
Local: Wed, Oct 31 2012 3:27 pm
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author

Comment #2 on issue 401 by bsalo...@google.com: Chat sends notifications  
for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

Great! Could this rule also apply to emails? It's not quite as bothersome  
to get email updates from my own activity but they also seem unnecessary.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Oct 31 2012, 3:49 pm
From: rietv...@googlecode.com
Date: Wed, 31 Oct 2012 19:49:48 +0000
Local: Wed, Oct 31 2012 3:49 pm
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author

Comment #3 on issue 401 by techto...@gmail.com: Chat sends notifications  
for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

AFAIK the code that sends the message is the same as the one that sends the  
email and it is located in _notify_issue()  
http://code.google.com/p/rietveld/source/browse/codereview/views.py#613


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Mar 28, 1:52 pm
From: rietv...@googlecode.com
Date: Thu, 28 Mar 2013 17:52:51 +0000
Local: Thurs, Mar 28 2013 1:52 pm
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author

Comment #4 on issue 401 by rmis...@google.com: Chat sends notifications for  
my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

I am starting to take a look at this.
I can make sure that XMPP messages are not sent to the requester, but for  
emails I already see that there is a safeguard to make sure the original  
requester is not emailed again, I think what you see in your emails is your  
email to the other members of the issue and not an email to yourself.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Mar 28, 1:59 pm
From: rietv...@googlecode.com
Date: Thu, 28 Mar 2013 17:59:13 +0000
Local: Thurs, Mar 28 2013 1:59 pm
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author

Comment #5 on issue 401 by bsalo...@google.com: Chat sends notifications  
for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

I think you're right. The emails are showing up because skia-review is in  
the CC list.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Mar 28, 2:38 pm
From: rietv...@googlecode.com
Date: Thu, 28 Mar 2013 18:38:15 +0000
Local: Thurs, Mar 28 2013 2:38 pm
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author

Comment #6 on issue 401 by rmis...@google.com: Chat sends notifications for  
my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

Started in https://codereview.appspot.com/8099046/

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
rietv...@googlecode.com  
View profile  
 More options Mar 30, 5:32 am
From: rietv...@googlecode.com
Date: Sat, 30 Mar 2013 09:32:58 +0000
Local: Sat, Mar 30 2013 5:32 am
Subject: Re: Issue 401 in rietveld: Chat sends notifications for my own rietveld interactions.
Print | Individual message | Show original | Report this message | Find messages by this author
Updates:
        Status: Fixed

Comment #7 on issue 401 by techto...@gmail.com: Chat sends notifications  
for my own rietveld interactions.
http://code.google.com/p/rietveld/issues/detail?id=401

This issue was closed by revision 9d5c30b9d19f.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google