Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Group info
Language: English
Group categories: Not categorized
More group info »
Discussions
View:  Topic list, Topic summary Topics 1 - 10 of 475  Older »

You cannot post messages because only members can post, and you are not currently a member.
Description: Discussion of the code review tool "Rietveld", http://codereview.appspot.com, open source at http://code.google.com/p/rietveld/.
 

Can't post comments 
  I can't seem to post my review comments. I've got 15 draft comments on a review of about 45 files. "Rietveld Code Review Tool Sorry, an error occurred... Unhandled exception. Details: too many values to unpack [ValueError] Please post a message to the discussion group if you have any questions."... more »
By Jimmy Wan  - May 31 - 3 new of 3 messages    

Add j/k instead arrow keys and move j/k to h/l 
  Hi, Now that "Please give me back my arrow keys" is fixed [link] I've finally got a chance to play with keyboard navigation and, well, it is still far from being convenient without a lot of practice. So.. I propose to change j/k for moving up and down the canvas, and assign... more »
By anatoly techtonik  - May 24 - 5 new of 5 messages    

Allow upload.py to upload binary files that are not images. (issue 6221063) 
  lgtm, cc'ing the ML in case there's any opinion. We need the binary files to be uploaded so they can be downloaded by the commit queue. [link]
By mar...@chromium.org  - May 22 - 4 new of 4 messages    

Server error in Google Apps hosted instance 
  I'm getting the generic AppEngine Server Error page on all our Rietveld instances. We installed it via the Google Apps marketplace into three domains (though I assume they are all running on the same installation). Things have been running smoothly on them for months (or years in one case). Doesn't appear to be happening on codereview.appspot.com.... more »
By Kyle Baley  - May 14 - 5 new of 5 messages    

Pull base files from a public git repo 
  codereview-discuss, Does anyone have suggestions about how to keep git diffs/patches uploaded to Rietveld honest? By honest, I mean ensuring that diffs are relative to what's checked into the central git repo (sourceforge in this case) for the project, as opposed to some arbitrary branch in the... more »
By jeremy Lewi  - Apr 26 - 2 new of 2 messages    

big diffs 
  We are using Code Review to manage an operating system project, and we've been finding that if we try to put in a really big patch, Code Review chokes. See for example [link], in which we're unable to download the patch set from the website, and if we attempt to do "hg clpatch 6060047", I get this:... more »
By John Floren  - Apr 18 - 2 new of 2 messages    

Googlebot making inefficient calls 
  I was looking at some data recorded with Appstats recently and found that the Googlebot makes some pretty inefficient requests. For example, I saw it go to [link] -- note the huge offset! It's easy to imagine how it got there -- it blinkdly follows the "older" link on the "Closed issues" tab.... more »
By Guido van Rossum  - Apr 16 - 5 new of 5 messages    

Add a/d shortcut to focus on next/previous line in side-by-side view. (issue 5685057) 
  How to proceed with this issue? Adding codereview-discuss in the hope that there's someone on the list with JavaScript knowledge to have a look at the patch.
By Andi Albrecht  - Mar 17 - 2 new of 2 messages    

Error when accessing the issue 
  (Posting here as the error page suggested. Let me know if I should ask this somewhere else) I keep getting the following error when I access [link] Can someone look into this? Thanks, - oshima ---------------- Rietveld Code Review Tool Sorry, an error occurred...... more »
By Mitsuru Oshima  - Mar 13 - 2 new of 2 messages    

Add index Issue with reviewers and modified (issue 5729044) 
  LGTM [link]
By albrecht.a...@googlemail.com  - Mar 3 - 1 new of 1 message    

1 - 10 of 475   « Newer | Older »

XML       Send email to this group: codereview-discuss@googlegroups.com