Number of context lines, Addressed comments

[William Chan]

Hello,

I've recently started using Rietveld and had a few questions. Sorry
if these have been answered elsewhere or already tracked in the bug
tracker. I quickly browsed the bug tracker and couldn't find these.

First, I like having the full context of a file available when I do
code reviews. I think someone mentioned something about this not
being allowed due to AppEngine quotas and what not. Is this true?
It'd be nice to be able to view the whole file without having to waste
another bunch of clicks.

Secondly, when doing code reviews and responding to them, it's nice to
know that all the comments have been addressed. Is there some way to
do this? If not, is someone working on this?

Again, sorry if this has already been discussed somewhere or is
implemented and I'm too dense to have figured it out. If so, a
pointer to the previous discussion or instructions on what to do would
be appreciated.

Thanks!

[Guido van Rossum]

On Tue, Mar 24, 2009 at 1:48 PM, William Chan <will...@gmail.com> wrote:
> I've recently started using Rietveld and had a few questions.  Sorry
> if these have been answered elsewhere or already tracked in the bug
> tracker.  I quickly browsed the bug tracker and couldn't find these.
>
> First, I like having the full context of a file available when I do
> code reviews.  I think someone mentioned something about this not
> being allowed due to AppEngine quotas and what not.  Is this true?

Yes.

> It'd be nice to be able to view the whole file without having to waste
> another bunch of clicks.

You could set your default context to 1000 on your Settings page.

> Secondly, when doing code reviews and responding to them, it's nice to
> know that all the comments have been addressed.  Is there some way to
> do this?  If not, is someone working on this?

No, and not AFAIK.

> Again, sorry if this has already been discussed somewhere or is
> implemented and I'm too dense to have figured it out.  If so, a
> pointer to the previous discussion or instructions on what to do would
> be appreciated.

Sorry nobody replied earlier to you.

--
--Guido van Rossum (home page: http://www.python.org/~guido/)

[Daniel (ajax) Diniz]

Guido van Rossum wrote:
>
> On Tue, Mar 24, 2009 at 1:48 PM, William Chan <will...@gmail.com> wrote:
>> I've recently started using Rietveld and had a few questions.  Sorry
>> if these have been answered elsewhere or already tracked in the bug
>> tracker.  I quickly browsed the bug tracker and couldn't find these.
>>
>> First, I like having the full context of a file available when I do
>> code reviews.  I think someone mentioned something about this not
>> being allowed due to AppEngine quotas and what not.  Is this true?
>
> Yes.

With a way to submit comments in a serialized format, it might be
feasible to have the client download base file plus patch and build
the side-by-side view locally.

Consuming serialized comments would also open the doors to alternative
clients (e.g. IDEs or command line) and offline work.

I won't have time to work on this anytime soon (or even not-so-soon),
I'm afraid :/

Daniel