"Memory Error" for changeset 2347

[Christian Brunschen]

When attempting to access changeset 2347 at <http://
codereview.appspot.com/2347> , I keep getting one or two error
messages. The first is more elaborate:

"
Error: Server Error

The server encountered an error and could not complete your request.
If the problem persists, please report your problem and mention this
error message and the query that caused it.
"

The second is short and simple:

"
MemoryError
"

I expect this is part of the known bug at <http://code.google.com/p/
rietveld/wiki/KnownBugs>, "On huge files with many diffs you may
receive errors indicating out-of-memory or deadline-exceeded
conditions", but I thought I'd add the data points.

Best wishes,

// Christian Brunschen

[Jiayao Yu]

Just had a quick look in the logs. The query stopped around after 4 seconds of execution. It looks like the apps engine tried to kill the query and encountered an error. There is a known issue related to this:http://code.google.com/p/googleappengine/issues/detail?id=99 . And yes, sometimes MemoryError occurs first.
views.show seems a bit too heavy. Maybe it's not a good place to pre-populate the patchsets with comments.

Jiayao

[Andi Albrecht]

I've run some tests with Christians patch set and it was a simple
problem: After uploading a second patch set the issue page shows delta
links and the page size exploded from ~150kb to 1.5MB! This was caused
by the nested loops and conditions when rendering the delta links:
Each template statement produces at least one blank line. After all we
came up with this gigantic page. Adding a spaceless tag solved it...
;-)

The version is now live and issue 2347 is accessible again.

Andi

2008/6/19 Jiayao Yu <jiay...@gmail.com>: