big diffs

[John Floren]

We are using Code Review to manage an operating system project, and
we've been finding that if we try to put in a really big patch, Code
Review chokes. See for example http://codereview.appspot.com/6060047/,
in which we're unable to download the patch set from the website, and
if we attempt to do "hg clpatch 6060047", I get this:

Wed Apr 18 11:35:07 2012 downloading CL 6060047
Wed Apr 18 11:35:07 2012 loading CL 6060047
Wed Apr 18 11:35:07 2012 getting issue metadata from web
Wed Apr 18 11:35:07 2012 None
Wed Apr 18 11:35:07 2012 loaded CL 6060047
abort: HTTP Error 404: Not Found

(strace indicates that the 404 comes while trying to download
the .diff file). These kind of huge patches are rare, but important. I
think we should be able to put commit occasional changes like this
directly into the tree (bypassing Code Review), but Code Review has
been very useful in general so this isn't the best option for us.

Is there a way to get around this problem? Can anyone else share their
experiences in putting large diffs through Code Review?

Thanks

john

[Andi Albrecht]

Hi John,

the changelist you've mentioned is really huge and the codereview
server is not really optimized for such a huge number of changed
files. IMO it's best to upload such a change piece-wise. You can
specify which files to upload as arguments on the command line, but
I'm not sure if "hg clpatch" supports that too.

Best regards,

Andi

> --
> You received this message because you are subscribed to the Google Groups "codereview-discuss" group.
> To post to this group, send email to coderevie...@googlegroups.com.
> To unsubscribe from this group, send email to codereview-disc...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/codereview-discuss?hl=en.
>