Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
big diffs
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
John Floren  
View profile  
 More options Apr 18 2012, 2:35 pm
From: John Floren <j...@jfloren.net>
Date: Wed, 18 Apr 2012 11:35:41 -0700 (PDT)
Local: Wed, Apr 18 2012 2:35 pm
Subject: big diffs
We are using Code Review to manage an operating system project, and
we've been finding that if we try to put in a really big patch, Code
Review chokes. See for example http://codereview.appspot.com/6060047/,
in which we're unable to download the patch set from the website, and
if we attempt to do "hg clpatch 6060047", I get this:

        Wed Apr 18 11:35:07 2012 downloading CL 6060047
        Wed Apr 18 11:35:07 2012 loading CL 6060047
        Wed Apr 18 11:35:07 2012 getting issue metadata from web
        Wed Apr 18 11:35:07 2012 None
        Wed Apr 18 11:35:07 2012 loaded CL 6060047
abort: HTTP Error 404: Not Found

(strace indicates that the 404 comes while trying to download
the .diff file). These kind of huge patches are rare, but important. I
think we should be able to put commit occasional changes like this
directly into the tree (bypassing Code Review), but Code Review has
been very useful in general so this isn't the best option for us.

Is there a way to get around this problem? Can anyone else share their
experiences in putting large diffs through Code Review?

Thanks

john


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Andi Albrecht  
View profile  
 More options Apr 19 2012, 3:01 pm
From: Andi Albrecht <albrecht.a...@googlemail.com>
Date: Thu, 19 Apr 2012 21:01:03 +0200
Local: Thurs, Apr 19 2012 3:01 pm
Subject: Re: big diffs
Hi John,

the changelist you've mentioned is really huge and the codereview
server is not really optimized for such a huge number of changed
files. IMO it's best to upload such a change piece-wise. You can
specify which files to upload as arguments on the command line, but
I'm not sure if "hg clpatch" supports that too.

Best regards,

Andi


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »