Use as a general review tool

1 view
Skip to first unread message

Paul Gregory

unread,
Aug 18, 2008, 9:32:30 AM8/18/08
to codereview-discuss
Hi all,

Quick(ish) question. I run an open source project called Aqsis (http://
www.aqsis.org) and we the developers are about to embark on a general
'detail' code review. That is, we plan to review each file/class in
turn as part of a complete review of the codebase. We are looking for
tools to help manage the process. I came across "Review Board" and
"Reitveld". Both seem to offer review of pending changes, but nothing
relating to a general overall code review process. Is it possible to
use Reitveld in this context? If not, does anyone here have any
experience of doing such a global review?

Thanks for any advice.


Paul Gregory

Guido van Rossum

unread,
Aug 18, 2008, 11:01:32 AM8/18/08
to coderevie...@googlegroups.com
In Rietveld (sp!) it would be somewhat painful, although you could
probably hack the upload.py script to upload a fake diff for every
file in the repo.

Another option would be to switch to Google code hosting (even
temporarily) -- they have a general commenting facility that lets you
comment either on the code or on specific changes that have been
checked in.

See http://google-code-updates.blogspot.com/2008/07/looks-good-to-me-source-code-review.html
for more.

--Guido

--
--Guido van Rossum (home page: http://www.python.org/~guido/)

Paul Gregory

unread,
Aug 20, 2008, 8:15:37 AM8/20/08
to codereview-discuss
Thanks for the reply. I have looked at Googles hosting services and it
seems that this might be the right solution. I'm not sure about
switching entirely to Google for hosting, but as you say, temporarily
during the review might be a good thing. And who knows, we might find
it works so well we want to stay.

Thanks


Paul Gregory

On Aug 18, 4:01 pm, "Guido van Rossum" <gu...@python.org> wrote:
> In Rietveld (sp!) it would be somewhat painful, although you could
> probably hack the upload.py script to upload a fake diff for every
> file in the repo.
>
> Another option would be to switch to Google code hosting (even
> temporarily) -- they have a general commenting facility that lets you
> comment either on the code or on specific changes that have been
> checked in.
>
> Seehttp://google-code-updates.blogspot.com/2008/07/looks-good-to-me-sour...
Reply all
Reply to author
Forward
0 new messages