Don't strip the message anymore, it's breaking some dev use case (issue 5689045)

[mar...@chromium.org]

Reviewers: Andi Albrecht,

Description:
Don't strip the message anymore, it's breaking some dev use case

Please review this at http://codereview.appspot.com/5689045/

Affected files:
M upload.py

Index: upload.py
===================================================================
--- a/upload.py
+++ b/upload.py
@@ -2248,8 +2248,7 @@
prompt = "Title describing this patch set: "
else:
prompt = "New issue subject: "
- title = (
- title or message.split('\n', 1)[0].strip() or
raw_input(prompt).strip())
+ title = title or message.split('\n', 1)[0] or raw_input(prompt)
if not title and not options.issue:
ErrorExit("A non-empty title is required for a new issue")
# For existing issues, it's fine to give a patchset an empty name.
Rietveld

[Guido van Rossum]

LG

Curious about the use case...

> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to coderevie...@googlegroups.com.
> To unsubscribe from this group, send email to
> codereview-disc...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.
>

--
--Guido van Rossum (python.org/~guido)

[tech...@gmail.com]

Me too, because we may strip it on server side.

http://codereview.appspot.com/5689045/

[Marc-Antoine Ruel]

They do -m" " to skip the prompt entirely.

[Guido van Rossum]

LG. Ok.

--
--Guido van Rossum (python.org/~guido)