You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to closure-lin...@googlegroups.com
We are trying to use closure_linter to power a presubmit hook in Chromium (see https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/97b5dc28d9e5109b for all the details if you're curious). If we drop closure_linter into our source tree as is, we get an error because of the copyright notice in common/tokens_test.py: "Copyright 2011 Google Inc. All Rights Reserved."
We can change it locally to match the notice in most other files ("Copyright 2012 The Closure Linter Authors. All Rights Reserved." followed by some Apache License boilerplate) but I thought it might be a good idea to ask first to make sure that's okay to do. Or maybe it would be better to change it in the closure_linter repository itself: http://code.google.com/p/closure-linter/issues/detail?id=40
Thanks,
Tyler
Nathan Naze
unread,
Feb 15, 2012, 6:50:47 PM2/15/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to closure-lin...@googlegroups.com, Andy Perelson
This is an oversight, but, yes, a legal problem for some folks. I'll send a CL to update the copyright notice. ajp@, do you know who is responsible for the linter MOE push?
Nathan
Tyler Breisacher
unread,
Feb 15, 2012, 7:01:41 PM2/15/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to closure-lin...@googlegroups.com
Actually, we also get the error on both of the __init__.py files too. If you're going to be changing tokens_test.py you could also change the __init__.py files at the same time, if you wanted to. Either by adding the copyright notice, or by just deleting the entire contents of the file (which is just "#!/usr/bin/env python") since our license-check script ignores empty files. :)
Tyler Breisacher
unread,
Feb 28, 2012, 3:02:14 PM2/28/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to closure-lin...@googlegroups.com
I saw that this change went in as part of r15. Thanks!