submitting a trivial patch

16 views
Skip to first unread message

John Munro

unread,
May 20, 2013, 3:01:14 PM5/20/13
to closure-lib...@googlegroups.com
I found what I think is a bug in the Closure Library.  After submitting it to the issue tracker (560) I found what I think is a solution - to add .goog-css3-button-checked to ../css/css3button.css.

It's a pretty trivial change, but I'd like to be a good citizen and submit it.  The problem I have is that I'm new to Git and Rietveld, and I'm not sure how to answer all of the questions it's asking me...

Nathan Naze

unread,
May 20, 2013, 3:34:59 PM5/20/13
to closure-library
If it's just a line or two, just include the diff on this thread and I'll copy/paste it in.

For legal reasons, you still need to fill out the CLA: https://developers.google.com/open-source/cla/individual

Nathan


On Mon, May 20, 2013 at 3:01 PM, John Munro <ghos...@gmail.com> wrote:
I found what I think is a bug in the Closure Library.  After submitting it to the issue tracker (560) I found what I think is a solution - to add .goog-css3-button-checked to ../css/css3button.css.

It's a pretty trivial change, but I'd like to be a good citizen and submit it.  The problem I have is that I'm new to Git and Rietveld, and I'm not sure how to answer all of the questions it's asking me...

--
 
---
You received this message because you are subscribed to the Google Groups "Closure Library Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to closure-library-d...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

John Munro

unread,
May 20, 2013, 3:51:39 PM5/20/13
to closure-lib...@googlegroups.com
OK, I've filled in the CLA and the diff is attached

Thanks
To unsubscribe from this group and stop receiving emails from it, send an email to closure-library-discuss+unsub...@googlegroups.com.
css3button.css.diff
Reply all
Reply to author
Forward
0 new messages