goog.json.parse vs JSON.parse

[John Munro]

I'm using goog.net.XhrIo.getResponseJson() but it doesn't have a parameter for a reviver to convert dates (neither does goog.json.parse).  Is there any reason not to use JSON.parse on goog.net.XhrIo.getResponseText()?

[Nathan Naze]

The code predates the common existence of JSON.parse, thus this is why
it uses goog.json.parse.

Really, it should just be deprecated.

Nathan

> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to closure-library-d...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[John Munro]

When I try to compile the project using Closure I get the error

JSC_TYPE_MISMATCH. assignment to property responseJSON of filevision.net.API.Response
found   : *
required: (Object|null) at ../filevision/net/API.js line 290 : 12

The line in question is

            /**
             * Response as JSON object
             * @type {Object}
             */
            this.responseJSON = window.JSON.parse(xhr.getResponseText(), opt_reviver);

Is there something I can do to the return value of JSON.parse to make the compiler recognize it as an Object or do I need to change the type of the property to {*}?

On Monday, May 13, 2013 10:52:47 AM UTC-4, Nathan Naze wrote:

The code predates the common existence of JSON.parse, thus this is why
it uses goog.json.parse.

Really, it should just be deprecated.

Nathan

On Mon, May 13, 2013 at 10:25 AM, John Munro <ghos...@gmail.com> wrote:
> I'm using goog.net.XhrIo.getResponseJson() but it doesn't have a parameter
> for a reviver to convert dates (neither does goog.json.parse).  Is there any
> reason not to use JSON.parse on goog.net.XhrIo.getResponseText()?
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to closure-library-discuss+unsub...@googlegroups.com.

[Nathan Naze]

Do a cast.

https://code.google.com/p/closure-compiler/wiki/AnnotatingTypes

you can also use goog.asserts.asserts here

>> > email to closure-library-d...@googlegroups.com.

>> > For more options, visit https://groups.google.com/groups/opt_out.
>> >
>> >
>

> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to closure-library-d...@googlegroups.com.

[John Munro]

Thanks, I didn't know that was possible - Javascript + Closure is a big elephant to eat in one sitting :)

>> > email to closure-library-discuss+unsub...@googlegroups.com.

>> > For more options, visit https://groups.google.com/groups/opt_out.
>> >
>> >
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to closure-library-discuss+unsub...@googlegroups.com.