with-open should use a close multimethod?

[Mike Hinchey]

I have a suggestion for the with-open macro.  It calls .close when it's finished.  I'd like it to have a (defmulti close type) so it's behavior is extensible.  A standard method could be defined for java.io.Closeable and a :default method with no type hint.  I've come across a few cases where some external library defines what is essentially a close method but names it shutdown or disable, etc., and defining my own close method would be much easier than rewriting with-open.  This would also allow people to eliminate reflection for classes like sql Connection that were created before Closeable.

I'll submit a patch if it's wanted.  This would fit in core, or maybe contrib.duck-streams with a slightly different name.

-Mike

[Seth]

Sounds good to me.

[Chas Emerick]

Definitely +1, yes.

- Chas

[Sean Devlin]

+1

[C. Florian Ebeling]

+1

Coming across that problem just yesterday.

--
Florian Ebeling
florian...@gmail.com

[J. McConnell]

+1

[Jarkko Oranen]

> I'll submit a patch if it's wanted.  This would fit in core, or maybe
> contrib.duck-streams with a slightly different name.

This should be in core I think, so that it can work with with-open—
unless we're going to duplicate with-open in contrib. :/

--
Jarkko