Patch Review
Phil Hagelberg
So it's great to see new ideas popping up like protocols and datatypes,
but I've noticed that the list of patches ready to apply to Clojure gets
pretty long and doesn't seem to move that fast. I don't mean to
complain; I'd much rather have Rich and co. working on exciting new
features than spending a lot of time poring over and testing patch
submissions, which often can amount to grunt work.
Is there anything we can do to involve the community in streamlining the
process? I spent some time this evening[1] looking over a number of
tickets marked "ready to test" and just making sure they applied
cleanly, passed tests, and generally seemed to do what they meant to
do. For older patches this is more important as there's more of a chance
that they no longer cleanly apply to the master branch.
I wonder if we got more manpower involved in that process if it would
mean less work for Rich and the committer team when they are ready to
apply patches since it weeds out the patches that are clearly not
ready. Some projects I've worked on will not even consider a patch
unless it's got three "+1" comments from people who have tested it,
which encourages contributors to make an effort to get more people
involved in the process.
If it's not really a big deal and it's just causing unnecessary email to
the people subscribed to the tickets, then I'll just leave it alone, but
I'm wondering what others think. Again, I'm not complaining about the
current state of affairs; I'm just wondering if we can get more people
involved.
-Phil
[1] Yes, in fact, I _am_ a lot of fun at parties; thanks for asking.
Timothy Pratley
On Oct 21, 4:27 pm, Phil Hagelberg <p...@hagelb.org> wrote:
> I wonder if we got more manpower involved in that process if it would
> mean less work for Rich and the committer team when they are ready to
> apply patches since it weeds out the patches that are clearly not
> ready. Some projects I've worked on will not even consider a patch
> unless it's got three "+1" comments from people who have tested it,
> which encourages contributors to make an effort to get more people
> involved in the process.
I think that is a fantastic idea and is something I am interested in
participating in! I'll hold off spamming the tickets until the exact
process is agreed upon or dictated by Rich - my understanding is that
I'd just grab a patch, look at it to make sure it makes sense, test it
(maybe even add a test case if not there) and add a comment "works
great" on the ticket and any relevant info?
Regards,
Tim.
Sean Devlin
This would be awesome for contrib, too.