CLJ tickets needing work on September 27 2012

[Andy Fingerhut]

Tickets needing work for CLJ project
Date: September 27, 2012

If you are a Clojure contributor, the tickets below could use some
work. Some are easy, some are not. If you've never added a patch
before, or want a refresher on the mechanics, see (Note 1) near the
bottom.

For the list of tickets that have patches, but they need updating, or
a list of tickets without patches marked for Release 1.5 of Clojure,
keep reading below.

For the list of tickets that don't have any patches, see (Note 2) near
the bottom.

Another way to help out is to try out, read, review, comment on, and
vote for existing patches. See the separate "List of prescreened
patches" for those.

----------------------------------------------------------------------
Blocking bugs
----------------------------------------------------------------------
One or more contributors consider these bugs to be blocking,
i.e. significant enough to warrant fixing before another release is
made, by saying so on clojure-dev. If someone from Clojure/core wants
to veto that status, let me know and I'll remove it from this part of
the report.

<none at this time that need work>

----------------------------------------------------------------------
These tickets have no patches, or patches that need work, and are
marked for Release 1.5 of Clojure (see also Note 3 at the bottom):

No patch yet:

CLJ-394 Add marker Interfaces for defrecords and deftypes plus boolean test fns
CLJ-899 Allow colon as whitespace in map literals
CLJ-927 Consider using the identity function as default tagged literal reader

Doc string fixes only:

CLJ-835 0001-CLJ-835-Refine-doc-string-for-defmulti-hierarchy-opt.patch
CLJ-980 extended-type-doc-fix-v2.patch

Better error reporting:

CLJ-1024 0001-CLJ-1024-Check-for-invalid-varags-destrucuring-uses.patch

Clojure library bug fixes:

! CLJ-850 clj-850-type-hinted-fn-abstractmethoderror-patch3.txt

----------------------------------------------------------------------

These patches used to apply cleanly, but due to recent changes in
Clojure master no longer do.

Language enhancement, new reducers planned for Clojure 1.5:

CLJ-991 none of the patches apply cleanly, but did on Jul 26, 2012
CLJ-992 comments say that perhaps other patches should be applied before this one
CLJ-993 comments say that perhaps other patches should be applied before this one
CLJ-994 none of the patches apply cleanly, but did on Jul 26, 2012

These patches have comments/questions from a Clojure screener that
should be addressed:

CLJ-1029 ns-patch.diff

These patches would pass prescreening, except they fail one or more
tests in the Clojure test suite:

CLJ-1078 both Sep 26 2012 patches, alone or in combination

The patches below would be prescreened, except that their authors are
not on the list of Clojure contributors. The authors have been
contacted via email to ask if they are willing to sign CAs.

CLJ-450 clj-450-add-default-pred-arg-to-core-fns-patch.txt (Jason Orendorff)
CLJ-884 diff.patch (Rahul Pilani - patch actually does not apply cleanly as of June 2012, but did earlier in 2012)
CLJ-983 proxy_super.patch (Valentin Mahrwald)

The ones above are likely easy to update. The ones below are likely
more work, where part of the work could be figuring out what ought to
be done in the first place.


The criteria for the tickets in the list below is: they seem like they
might be a reasonable amount of effort to create a patch. I am sure
there are many others, too.

CLJ-668 Improve slurp performance by using native Java StringWriter and jio/copy
(looks related to CLJ-669, which does have a patch)
CLJ-706 make use of deprecated namespaces/vars easier to spot
CLJ-766 Implicit casting behaviour of into-array differs from <primitive>-array
CLJ-849 Add a pseudo-variable containing the current line number
CLJ-1023 non-tail-position try block breaks mutable fields in deftype


What should be done with these?
CLJ-840 (patch clj840-2.diff applies cleanly and passes tests)


Comments perhaps imply that authors or other contributors think more
work should be done to create new patches. Some of these might be
significant hunks of work. Not easy for me to tell.
CLJ-2 (only patch fails to apply cleanly)
CLJ-5 (one of two patches applied and built cleanly on May 4, 2012, but not on May 10, 2012)
CLJ-322 (patch compile-interop-1.patch applies and builds cleanly)
CLJ-445 (no patches apply cleanly)
CLJ-792 (patch clj-792-reorg-reflector-patch2.txt applied cleanly in Feb 2012, but didn't pass all tests)
CLJ-803 (both patches apply and build cleanly, iatom.patch using patch(1))
CLJ-821 (only patch fails to apply cleanly)
CLJ-891 (only patch applies and builds cleanly)

----------------------------------------------------------------------

(Note 1)

Read the documentation under the headings "Development", "Adding
patches", and "Removing patches" on this page:

http://dev.clojure.org/display/design/JIRA+workflow

(Note 2)

As of the date of this report, there are 153 tickets matching a JIRA
filter called "Needs a Patch (all)". To see them, go to this link:

http://dev.clojure.org/jira/secure/ManageFilters.jspa#filterView=search

In the box labeled Author, type in Andy Fingerhut. Click on the
choice that pops up and the contents should change to my user account
name, jafingerhut. Click on the Search button at the bottom. Then
click on the filter called "Needs a Patch (all)". You can subscribe
to the filter, after which it should show up in your list of filters
under the Issues menu on this page:

http://dev.clojure.org/jira/browse/CLJ

Most "Needs a Patch" tickets have no patches attached. If it does
have a patch, then its Patch attribute needs to be changed. Read the
documentation on adding patches at the link in (Note 1) above.

Some of the older tickets have links to patches in the old Assembla
ticket system. If you add an attachment to the JIRA ticket, my
automated patch prescreening code will pick it up the next time I run
it (about once per week).

(Note 3)

To see a JIRA filter matching tickets that are marked for Release 1.5,
but are not marked as having a patch, follow the instructions for Note
2, except the filter name is "Needs a patch for Release 1.5"

[Tassilo Horn]

Andy Fingerhut <andy.fi...@gmail.com> writes:

> Better error reporting:
>
> CLJ-1024 0001-CLJ-1024-Check-for-invalid-varags-destrucuring-uses.patch

What needs to be done here? The patch applies, and I've addressed
Victor's comment. Aaron, could you please elaborate on you comment? I
don't get it...

Bye,
Tassilo