munge should not convert $ (since it isJavaIdentifierPart)

[Michał Marczyk]

munge is overeager in converting $ to _DOLLARSIGN_, since $ is a valid
character in Java identifiers:

user> (filter #(Character/isJavaIdentifierPart %) (keys
clojure.lang.Compiler/CHAR_MAP))
(\$)

Patch attached.

Sincerely,
Michał

[Michał Marczyk]

On a related point, ' (single quote) is not admissible in Java
identifiers, but it is not munged on master:

user=> (Character/isJavaIdentifierPart \')
false
user=> (munge "'")
"'"

This leads to e.g.

user=> *'
#<core$_STAR_' clojure.core$_STAR_'@5adf48c4>

(note the ' after _STAR_).

Sincerely,
Michał

[Michał Marczyk]

Jon Seltzer reports running into the $ problem on the Clojure ggroup
[1]. I've created a ticket for it: [2].

Sincerely,
Michał

[1] http://groups.google.com/group/clojure/browse_thread/thread/7753adc5453d7410

[2] http://www.assembla.com/spaces/clojure/tickets/433-munge-should-not-munge-$-(which-isjavaidentifierpart)--should-munge---(which-is-not)