CLJ tickets needing work on November 1 2012

38 views
Skip to first unread message

Andy Fingerhut

unread,
Nov 1, 2012, 9:09:46 PM11/1/12
to cloju...@googlegroups.com
Tickets needing work for CLJ project
Date: November 1, 2012

If you are a Clojure contributor, the tickets below could use some
work. Some are easy, some are not. If you've never added a patch
before, or want a refresher on the mechanics, see (Note 1) near the
bottom.

For the list of tickets that have patches, but they need updating, or
a list of tickets without patches marked for Release 1.5 of Clojure,
keep reading below.

For the list of tickets that don't have any patches, see (Note 2) near
the bottom.

Another way to help out is to try out, read, review, comment on, and
vote for existing patches. See the separate "List of prescreened
patches" for those.

----------------------------------------------------------------------
Blocking bugs
----------------------------------------------------------------------
One or more contributors consider these bugs to be blocking,
i.e. significant enough to warrant fixing before another release is
made, by saying so on clojure-dev. If someone from Clojure/core wants
to veto that status, let me know and I'll remove it from this part of
the report.

<none at this time that need work>

----------------------------------------------------------------------
These tickets have no patches, or patches that need work, and are
marked for Release 1.5 of Clojure (see also Note 3 at the bottom):

No patch yet:

CLJ-899 Allow colon as whitespace in map literals
CLJ-1091 update changes.md to include 1.5 changes

Doc string fixes only:

CLJ-835 0001-CLJ-835-Refine-doc-string-for-defmulti-hierarchy-opt.patch
CLJ-980 extended-type-doc-fix-v2.patch

Clojure library bug fixes:

CLJ-850 clj-850-type-hinted-fn-abstractmethoderror-patch4.txt

----------------------------------------------------------------------
These patches used to apply cleanly, but due to recent changes in
Clojure master no longer do. See (Note 1) for some tips on updating
stale patches.

Language enhancement, new reducers planned for Clojure 1.5:

CLJ-994 none of the patches apply cleanly, but did on Jul 26, 2012

Clojure library bug fixes:

CLJ-1059 001-make-PersistentQueue-implement-List.diff or 002-make-PersistentQueue-implement-ASequential.diff (applied cleanly until Oct 20 2012 when a conflicting patch for CLJ-1070 was applied)

Language enhancement:

CLJ-976 clj-976-queue-literal-eval-and-synquote-patch-v3.txt (applied cleanly until Oct 20 2012 when a conflicting patch for CLJ-1070 was applied)


These patches have comments/questions from a Clojure screener that
should be addressed:

<none at this time>

These patches would pass prescreening, except they fail one or more
tests in the Clojure test suite:

<none at this time>

The patches below would be prescreened, except that their authors are
not on the list of Clojure contributors. The authors have been
contacted via email to ask if they are willing to sign CAs, but they
may not be interested in doing so.

CLJ-450 clj-450-add-default-pred-arg-to-core-fns-patch.txt (Jason Orendorff)
CLJ-884 diff.patch (Rahul Pilani - patch actually does not apply cleanly as of June 2012, but did earlier in 2012)
CLJ-983 proxy_super.patch (Valentin Mahrwald)
CLJ-1095 0001-map-indexed-accepts-multiple-collections.patch (Bo Jeanes)


The ones above may be easy to update. The ones below are likely more
work, where part of the work could be figuring out what ought to be
done in the first place.


The criteria for the tickets in the list below is: they seem like they
might be a reasonable amount of effort to create a patch. I am sure
there are many others, too.

CLJ-668 Improve slurp performance by using native Java StringWriter and jio/copy
(looks related to CLJ-669, which does have a patch)
CLJ-766 Implicit casting behaviour of into-array differs from <primitive>-array
CLJ-849 Add a pseudo-variable containing the current line number


What should be done with these?
CLJ-840 (patch clj840-2.diff applies cleanly and passes tests)


Comments perhaps imply that authors or other contributors think more
work should be done to create new patches. Some of these might be
significant hunks of work. Not easy for me to tell.
CLJ-2 (only patch fails to apply cleanly)
CLJ-5 (one of two patches applied and built cleanly on May 4, 2012, but not on May 10, 2012. The second, clj-5-destructure-error.diff, failed to apply as of Oct 4, 2012)
CLJ-322 (patch compile-interop-1.patch applies and builds cleanly)
CLJ-445 (no patches apply cleanly)
CLJ-792 (patch clj-792-reorg-reflector-patch2.txt applied cleanly in Feb 2012, but didn't pass all tests)
CLJ-803 (both patches apply and build cleanly, iatom.patch using patch(1))
CLJ-821 (only patch fails to apply cleanly)
CLJ-891 (only patch applied and built cleanly until Oct 4, 2012, when another committed patch caused it to no longer apply cleanly)

----------------------------------------------------------------------

(Note 1)

Read the documentation under the headings "Development", "Adding
patches", "Removing patches", and "Updating stale patches" on this
page:

http://dev.clojure.org/display/design/JIRA+workflow

(Note 2)

As of the date of this report, there are 152 tickets matching a JIRA
filter called "Needs a Patch (all)". To see them, go to this link:

http://dev.clojure.org/jira/secure/ManageFilters.jspa#filterView=search

In the box labeled Author, type in Andy Fingerhut. Click on the
choice that pops up and the contents should change to my user account
name, jafingerhut. Click on the Search button at the bottom. Then
click on the filter called "Needs a Patch (all)". You can subscribe
to the filter, after which it should show up in your list of filters
under the Issues menu on this page:

http://dev.clojure.org/jira/browse/CLJ

Most "Needs a Patch" tickets have no patches attached. If it does
have a patch, then its Patch attribute needs to be changed. Read the
documentation on adding patches at the link in (Note 1) above.

Some of the older tickets have links to patches in the old Assembla
ticket system. If you add an attachment to the JIRA ticket, my
automated patch prescreening code will pick it up the next time I run
it (about once per week).

(Note 3)

To see a JIRA filter matching tickets that are marked for Release 1.5,
but are not marked as having a patch, follow the instructions for Note
2, except the filter name is "Needs a patch for Release 1.5"

Reply all
Reply to author
Forward
0 new messages