Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Clojure Dev
Home
About this group
Apply for group membership
Can clj-1025 go into 1.5 please?
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
davesann  
View profile  
 More options Oct 17 2012, 5:29 am
From: davesann <daves...@gmail.com>
Date: Wed, 17 Oct 2012 02:29:14 -0700 (PDT)
Local: Wed, Oct 17 2012 5:29 am
Subject: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

Can this enhancement please go into 1.5

http://dev.clojure.org/jira/browse/CLJ-1025

This is a small change but enables clojure reader compatibility for strings
containing characters output by clojurescript as \x.. escaped characters
(extended ascii 128-255).

Thanks

Dave


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Brandon Bloom  
View profile  
 More options Oct 17 2012, 6:17 pm
From: Brandon Bloom <snprbo...@gmail.com>
Date: Wed, 17 Oct 2012 15:17:55 -0700 (PDT)
Local: Wed, Oct 17 2012 6:17 pm
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

+1

Also, maybe it would be a good idea to file a bug at
https://github.com/edn-format/edn/issues/ too? It seems like EDN doesn't
spec either \u.... or \x.. yet.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Chris Granger  
View profile  
 More options Oct 17 2012, 6:35 pm
From: Chris Granger <ibdk...@gmail.com>
Date: Wed, 17 Oct 2012 15:35:25 -0700
Local: Wed, Oct 17 2012 6:35 pm
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

I'd also really like to see this - it lead to a number of unusual bugs
before I figured out what in the world was going on.

Cheers,
Chris.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Chas Emerick  
View profile  
 More options Oct 19 2012, 11:23 am
From: Chas Emerick <c...@cemerick.com>
Date: Fri, 19 Oct 2012 11:23:09 -0400
Local: Fri, Oct 19 2012 11:23 am
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

-1

I too have hit issues due to the use of \x.. escapes coming out of ClojureScript, but it doesn't strike me as a Clojure (or edn) problem at all:

http://dev.clojure.org/jira/browse/CLJ-1025?focusedCommentId=29687#co...

Here's a prospective patch for ClojureScript that eliminates the use of goog.string.quote, which is the source of the \x.. escapes (as well as unwarranted \u.... escapes):

https://gist.github.com/3918764

I think CLJ-1025 should be closed as wontfix, with something like the above going into CLJS instead.

Cheers,

- Chas

On Oct 17, 2012, at 6:17 PM, Brandon Bloom wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Brian Taylor  
View profile  
 More options Oct 19 2012, 11:26 am
From: Brian Taylor <el.w...@gmail.com>
Date: Fri, 19 Oct 2012 11:26:52 -0400
Local: Fri, Oct 19 2012 11:26 am
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

+1 Chas's suggestion since it reduces the number of ways that the same
character sequence can be encoded.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
davesann  
View profile  
 More options Oct 19 2012, 3:45 pm
From: davesann <daves...@gmail.com>
Date: Fri, 19 Oct 2012 12:45:57 -0700 (PDT)
Local: Fri, Oct 19 2012 3:45 pm
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

fair enough - i wasn't sure how much cljs was relying on the goog string
lib for safe escaping. If this works and it gets fixed I'm all for it.

Is there a CLJS ticket raised with this?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Chas Emerick  
View profile  
 More options Oct 19 2012, 8:55 pm
From: Chas Emerick <c...@cemerick.com>
Date: Fri, 19 Oct 2012 17:55:47 -0700 (PDT)
Local: Fri, Oct 19 2012 8:55 pm
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author
I've filed a CLJS issue for this, and attached a patch:

http://dev.clojure.org/jira/browse/CLJS-400

Thanks for keeping on this, Dave. :-)

- Chas

On Oct 19, 3:45 pm, davesann <daves...@gmail.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
David Nolen  
View profile  
 More options Oct 19 2012, 9:16 pm
From: David Nolen <dnolen.li...@gmail.com>
Date: Fri, 19 Oct 2012 21:16:16 -0400
Local: Fri, Oct 19 2012 9:16 pm
Subject: Re: Can clj-1025 go into 1.5 please?
Print | Individual message | Show original | Report this message | Find messages by this author

On Fri, Oct 19, 2012 at 8:55 PM, Chas Emerick <c...@cemerick.com> wrote:
> I've filed a CLJS issue for this, and attached a patch:

> http://dev.clojure.org/jira/browse/CLJS-400

> Thanks for keeping on this, Dave. :-)

> - Chas

Approach of the patch looks fine but I think there are some minor perf
tweaks we should make. Comments added to the ticket.

David


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google