Can clj-1025 go into 1.5 please?

134 views
Skip to first unread message

davesann

unread,
Oct 17, 2012, 5:29:14 AM10/17/12
to cloju...@googlegroups.com
Can this enhancement please go into 1.5

http://dev.clojure.org/jira/browse/CLJ-1025

This is a small change but enables clojure reader compatibility for strings containing characters output by clojurescript as \x.. escaped characters (extended ascii 128-255).

Thanks

Dave

Brandon Bloom

unread,
Oct 17, 2012, 6:17:55 PM10/17/12
to cloju...@googlegroups.com
+1

Also, maybe it would be a good idea to file a bug at https://github.com/edn-format/edn/issues/ too? It seems like EDN doesn't spec either \u.... or \x.. yet.

Chris Granger

unread,
Oct 17, 2012, 6:35:25 PM10/17/12
to cloju...@googlegroups.com
I'd also really like to see this - it lead to a number of unusual bugs before I figured out what in the world was going on.

Cheers,
Chris.

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To view this discussion on the web visit https://groups.google.com/d/msg/clojure-dev/-/w490en2dfRQJ.

To post to this group, send email to cloju...@googlegroups.com.
To unsubscribe from this group, send email to clojure-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/clojure-dev?hl=en.

Chas Emerick

unread,
Oct 19, 2012, 11:23:09 AM10/19/12
to cloju...@googlegroups.com
-1

I too have hit issues due to the use of \x.. escapes coming out of ClojureScript, but it doesn't strike me as a Clojure (or edn) problem at all:


Here's a prospective patch for ClojureScript that eliminates the use of goog.string.quote, which is the source of the \x.. escapes (as well as unwarranted \u.... escapes):


I think CLJ-1025 should be closed as wontfix, with something like the above going into CLJS instead.

Cheers,

- Chas

Brian Taylor

unread,
Oct 19, 2012, 11:26:52 AM10/19/12
to cloju...@googlegroups.com
+1 Chas's suggestion since it reduces the number of ways that the same character sequence can be encoded.

davesann

unread,
Oct 19, 2012, 3:45:57 PM10/19/12
to cloju...@googlegroups.com
fair enough - i wasn't sure how much cljs was relying on the goog string lib for safe escaping. If this works and it gets fixed I'm all for it.

Is there a CLJS ticket raised with this?

Chas Emerick

unread,
Oct 19, 2012, 8:55:47 PM10/19/12
to Clojure Dev
I've filed a CLJS issue for this, and attached a patch:

http://dev.clojure.org/jira/browse/CLJS-400

Thanks for keeping on this, Dave. :-)

- Chas

On Oct 19, 3:45 pm, davesann <daves...@gmail.com> wrote:
> fair enough - i wasn't sure how much cljs was relying on the goog string
> lib for safe escaping. If this works and it gets fixed I'm all for it.
>
> Is there a CLJS ticket raised with this?
>
>
>
>
>
>
>
> On Saturday, 20 October 2012 02:23:15 UTC+11, Chas Emerick wrote:
>
> > -1
>
> > I too have hit issues due to the use of \x.. escapes coming out of
> > ClojureScript, but it doesn't strike me as a Clojure (or edn) problem at
> > all:
>
> >http://dev.clojure.org/jira/browse/CLJ-1025?focusedCommentId=29687#co...
>
> > Here's a prospective patch for ClojureScript that eliminates the use of
> > goog.string.quote, which is the source of the \x.. escapes (as well as
> > unwarranted \u.... escapes):
>
> >https://gist.github.com/3918764
>
> > I think CLJ-1025 should be closed as wontfix, with something like the
> > above going into CLJS instead.
>
> > Cheers,
>
> > - Chas
>
> > On Oct 17, 2012, at 6:17 PM, Brandon Bloom wrote:
>
> > +1
>
> > Also, maybe it would be a good idea to file a bug at
> >https://github.com/edn-format/edn/issues/too? It seems like EDN doesn't
> > spec either \u.... or \x.. yet.
>
> > On Wednesday, October 17, 2012 2:29:14 AM UTC-7, davesann wrote:
>
> >> Can this enhancement please go into 1.5
>
> >>http://dev.clojure.org/jira/browse/CLJ-1025
>
> >> This is a small change but enables clojure reader compatibility for
> >> strings containing characters output by clojurescript as \x.. escaped
> >> characters (extended ascii 128-255).
>
> >> Thanks
>
> >> Dave
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Clojure Dev" group.
> > To view this discussion on the web visit
> >https://groups.google.com/d/msg/clojure-dev/-/w490en2dfRQJ.
> > To post to this group, send email to cloju...@googlegroups.com<javascript:>
> > .
> > To unsubscribe from this group, send email to
> > clojure-dev...@googlegroups.com <javascript:>.

David Nolen

unread,
Oct 19, 2012, 9:16:16 PM10/19/12
to cloju...@googlegroups.com
On Fri, Oct 19, 2012 at 8:55 PM, Chas Emerick <ch...@cemerick.com> wrote:
I've filed a CLJS issue for this, and attached a patch:

http://dev.clojure.org/jira/browse/CLJS-400

Thanks for keeping on this, Dave. :-)

- Chas

Approach of the patch looks fine but I think there are some minor perf tweaks we should make. Comments added to the ticket.

David 
Reply all
Reply to author
Forward
0 new messages