CLJ prescreened patch list

[Andy Fingerhut]

Note: Some tickets have no attached files in JIRA, but their
descriptions or comments have links to patches in the older Assembla
system. Sorry, but no such tickets are included here. If anyone
wants one of those patches to be picked up by my code, please attach
the patch to the JIRA ticket. Even if it isn't in git format, my code
will pick it up and try to apply it as a non-git patch, and I might
create a git format patch from it.

Date: April 11, 2012
List of prescreened patches for CLJ project. Prescreened means:

+ The patch is in git format.
+ All authors listed in the patch have signed a CA.
+ Patch applies cleanly to latest master as of the date above with all
of the OS/JDK combos listed below:
Mac OS X 10.6.8 + Oracle/Apple JDK 1.6.0_31
Ubuntu 11.04 + IBM JDK 1.5.0 J9 2.3 (only if CLJ-967 patch applied first)
Ubuntu 11.04 + Oracle JDK 1.7.0_02
+ After applying the patch, the command "ant" compiles and passes all
tests without warnings or errors.

The conditions above are straightforward to automate, and have been
automated. The patch might still be a bad idea for many reasons,
e.g. it doesn't really fix the problem, there wasn't really a problem
to begin with that needed fixing, it isn't backwards compatible with
existing Clojure code, it contains bad spelling/grammar in doc
strings, it causes cancer in laboratory animals, etc., etc.

----------------------------------------------------------------------
Maybe worth going in before 1.4 release?
----------------------------------------------------------------------
CLJ-967 fixes current test breakage with IBM JDK 1.5 and 1.6
CLJ-967 clj-886-improved-fix-for-ibm-jdks-patch2.txt

CLJ-949 appears related to the recent flurry of activity in exception
handling.
CLJ-949 0001-let-undeclared-exceptions-continue-unchecked.patch

CLJ-873 patch permits any namespace to have a symbol named "/", not
only clojure.core. Especially useful for ClojureScript?
CLJ-873 clj-873-namespace-divides-patch.txt

Fix for exception when calling cl-format with legal arguments.
CLJ-881 clj-881-cl-format-exception-patch2.txt

----------------------------------------------------------------------
Tickets that can be closed now?
----------------------------------------------------------------------
CLJ-121 GC Issue 117: FAQ Page has formatting errors
CLJ-438 case* and code walkers
CLJ-696 SCA FAQ link is broken
Is CLJ-894 patch superseded by Rich's work on improving reduce performance?
Or do they achieve different things and this one is still useful?
CLJ-894 clj-894-better-reduce-performance-patch2.txt

----------------------------------------------------------------------
Prescreened patch list
----------------------------------------------------------------------
See after the list for the meaning of characters in first two columns.

Doc string fixes only:

b CLJ-892 clj-892-clarify-sort-sort-by-doc-strings-patch1.txt
b CLJ-893 clj-893-doc-vec-aliases-java-array-patch2.txt

Better error reporting, straightforward:

b CLJ-103 clj-103-incorrect-if-let-error-patch2.txt

Better error reporting, some complexity:

b CLJ-157 clj-157-better-err-msgs-for-defn-fn-syntax-errors-patch2.txt

Debug/tooling enhancement, straightforward:

b CLJ-788 clj-788-add-line-member-and-getter-to-CompilerException-patch.txt
b CLJ-896 clj-896-browse-url-uses-xdg-open-patch2.txt
b CLJ-902 clj-902-doc-on-namespaces-patch.txt
b CLJ-908 0001-Print-metadata-and-anonymous-classes-better.patch
b CLJ-939 0002-report-load-exceptions-with-file-and-line.diff
CLJ-943 0001-Remove-namespace-if-load-lib-fails-and-namespace-did.patch

Clojure bug fixes, straightforward:

CLJ-962 clj-962-subvec-nth-throws-on-negative-index-patch1.txt

Clojure library bug fixes:

B CLJ-768 clj-768-without-clj-881-patched-first.txt
b CLJ-783 clj-783-patch.txt
b CLJ-863 0001-make-interleave-handle-odd-arugments-in-the-same-man.patch
b CLJ-870 CLJ-753-870-905-combined-fix3.patch
(Notes on changes in attachment: CLJ-753-870-905-combined-fix3.readme.txt)
b CLJ-881 clj-881-cl-format-exception-patch2.txt
B CLJ-934 clj-934-transient-disj-patch2.txt
b CLJ-935 fix-trim-fns-different-whitespace-patch.txt
b CLJ-937 cl-format-efg-coerce-ratios-to-doubes-patch1.txt
b CLJ-945 capitalize-for-supplementary-chars-patch.txt
+b CLJ-967 clj-886-improved-fix-for-ibm-jdks-patch2.txt

Allow more correct-looking Clojure code to work, some complexity:

b CLJ-207 0001-Implement-CLJ-207-let-as-first-for-binding-form.patch
b CLJ-667 clj-667-allow-loop-recur-nested-in-catch-and-finally-patch2.txt
B CLJ-700 clj-700-patch3.txt
b CLJ-757 clj-757-fix-behavior-of-empty-transient-maps-patch2.txt
b CLJ-763 clj-763-destructuring-allow-dup-keys-patch2.txt
b CLJ-850 clj-850-type-hinted-fn-abstractmethoderror-patch3.txt

Performance enhancement, straightforward:

+ CLJ-669 clojure.java.io/do-copy: use java.nio for Files
b CLJ-858 stm-rm-msecs-patch.diff
CLJ-867 0001-CLJ-867-Incorporate-the-record-name-into-the-hash-co.patch

Language/library enhancement, straightforward:

CLJ-909 0001-Allow-custom-buffer-size-in-LineNumberingPushbackRea.patch
CLJ-910 0001-Make-memfn-allow-for-type-hinting-the-method-receive.patch
CLJ-916 clj-916-make-into-and-others-preserve-metadata-patch2.txt
b CLJ-923 clj-923-reading-ratios-prefixed-by-plus-patch2.txt
b CLJ-925 patch.diff
b CLJ-932 CLJ-932-0001.patch
b CLJ-952 clj-952-make-bigdec-work-on-bigints-patch1.txt
CLJ-957 0001-Allow-for-typehinting-of-method-signatures-in-deftyp.patch
CLJ-958 0001-Make-APersistentVector.iterator-slightly-more-effici.patch
+ CLJ-963 pprint-ns-patch.diff
+ CLJ-966 marker-protocols.diff

Language enhancement, some complexity:

CLJ-745 expose-protected-final-gen-class-clojure1.4.diff
CLJ-771 move-unchecked-casts.patch
b CLJ-873 clj-873-namespace-divides-patch.txt
CLJ-948 clj-948-annotate-gen-class-constructors-patch3.txt
CLJ-949 0001-let-undeclared-exceptions-continue-unchecked.patch

Language enhancement, some complexity, two similar patches available:

CLJ-827 0001-add-unsigned-bit-shift-right.patch
b CLJ-827 0001-CLJ-827-Add-bit-shift-right-logical.patch

Language enhancement, some complexity, several similar patches available:

(0001-* file adds failing tests only, so fails to test successfully)
CLJ-865 0001-Add-test-for-macroexpansion-metadata-preservation.patch
b CLJ-865 0002-Preserve-form-metadata-on-macroexpanded-forms.patch
CLJ-865 0003-Make-defmacro-preserve-form-metadata.patch
CLJ-865 0004-Another-stab-at-implementing-this.patch

Code cleanup:

CLJ-842 0001-Migrate-the-metadata-in-clojure.pprint.-to-the-new-s.patch
+ CLJ-964 clj-964-add-require-of-clojure-set-patch1.txt

----------------------------------------------------------------------
First column is one of:
+ Added to list since previous list was published on Mar 22 2012, or new patch.
* Patch updated so it still applies cleanly after recent commits.
(space) No change since previous list was published.

Second column is one of:
b In clojure-build list of patches applied.
B In clojure-build list of patches applied, in slightly modified form
due to another patch that was applied first in clojure-build's patch
list.
(space) Not in clojure-build.

clojure-build is: https://github.com/jafingerhut/clojure-build

No endorsement/criticism of the patch is implied by its
inclusion/exclusion in clojure-build. I include the info in this list
for my own bookkeeping purposes.
----------------------------------------------------------------------

[Jim Blomo]

Hi Andy, CLJ-970 applies cleanly to master and all tests pass. If I
should change the Details section to Version 1.4 let me know.

Jim

> --
> You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
> To post to this group, send email to cloju...@googlegroups.com.
> To unsubscribe from this group, send email to clojure-dev...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/clojure-dev?hl=en.
>

[Rich Hickey]

Thanks much for this. I appreciate the effort you and others put into it.

I think we are going to cut 1.4 as-is so as not to delay further shipping patches already applied, but I will use this list to seed the agenda (today) for 1.5 work.

Thanks again,

Rich

[David Nolen]

It would be nice to get column data on the agenda for 1.5, http://dev.clojure.org/jira/browse/CLJ-960

Even with the inevitable challenges (macros etc), basic source map support would be a significant improvement to the ClojureScript development experience.

David

[Andy Fingerhut]

Yes, my tool picked up your patch, but it looks like it is not the proper format. See the instructions for creating a git format patch at the link below, particularly the sections headed "Development" and "Adding patches".

http://dev.clojure.org/display/design/JIRA+workflow

Thanks,
Andy

[David Nolen]

This is a pretty powerful demo of what we can do if we can get those column numbers ;)

http://www.chris-granger.com/2012/04/12/light-table---a-new-ide-concept/

[Stuart Halloway]

Andy: huge thanks!

Everybody: As Rich says, we are going to cut 1.4 and then start applying these patches for 1.5. Sanity check: Is there anything in this list (or elsewhere) that is a *regressive* bug that needs to get into 1.4?

Thanks,

Stu

Stuart Halloway
Clojure/core
http://clojure.com

[Steve Miner]

On Apr 14, 2012, at 9:50 AM, Stuart Halloway wrote:

> Sanity check: Is there anything in this list (or elsewhere) that is a *regressive* bug that needs to get into 1.4?

I just filed:

http://dev.clojure.org/jira/browse/CLJ-973

Sometime recently, the format for data_readers.clj changed to require a read-time literal map instead of pairs of symbols. The doc string for *data-readers* should be updated to reflect the change.

[Jim Blomo]

Thanks, Andy. I've updated the ticket with the new patch format. May
I have edit permissions to remove the old patch and update the version
info on the ticket?

We also should consider linking to the JIRA workflow page from
clojure.org/contributing, for newbies like me :)

Jim

On Fri, Apr 13, 2012 at 8:17 AM, Andy Fingerhut

[Andy Fingerhut]

http://dev.clojure.org/jira/browse/CLJ-965

You can vote for that one. I can suggest, but I believe only very few people have authorization to change pages on clojure.org. There are instructions on the JIRA workflow page, linked to in the description of CLJ-965, on removing obsolete patches. Look in the "Adding patches" section. If those don't work for you, then you might need permissions bumped up. I believe Christopher Redinger (CC'ed) often handles that.

Thanks,
Andy

[Stuart Halloway]

Done - thanks!

Stu

[Christopher Redinger]

Hi Jim,

You now have the permissions you need in JIRA.

>>> To unsubscribe from this group, send email to clojure-dev+unsubscribe@googlegroups.com.

>>> For more options, visit this group at http://groups.google.com/group/clojure-dev?hl=en.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
>> To post to this group, send email to cloju...@googlegroups.com.

>> To unsubscribe from this group, send email to clojure-dev+unsubscribe@googlegroups.com.

>> For more options, visit this group at http://groups.google.com/group/clojure-dev?hl=en.
>>
>
> --
> You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
> To post to this group, send email to cloju...@googlegroups.com.

> To unsubscribe from this group, send email to clojure-dev+unsubscribe@googlegroups.com.

[Andy Fingerhut]

List of prescreened patches for CLJ project

Date: April 19, 2012

This list of tickets is intended primarily for Clojure screeners and
committers. If you are looking for tickets that need more work, look
for the separate "Tickets needing work" list.

Prescreened means:

* The patch is in git format.
* All authors listed in the patch have signed a CA.
* Patch applies cleanly to latest master as of the date above with all

of the OS/JDK combos listed below:
Mac OS X 10.6.8 + Oracle/Apple JDK 1.6.0_31
Ubuntu 11.04 + IBM JDK 1.5.0 J9 2.3

Ubuntu 11.04 + Oracle JDK 1.7.0_02

* After applying the patch, the command "ant" compiles and passes all
tests without warnings or errors (IBM JDKs only passes tests if
CLJ-967 applied first, which I did in my prescreening, and see Note
1 below for allowed warnings).

The conditions above are straightforward to automate, and have been
automated. The patch might still be a bad idea for many reasons,
e.g. it doesn't really fix the problem, there wasn't really a problem
to begin with that needed fixing, it isn't backwards compatible with
existing Clojure code, it contains bad spelling/grammar in doc
strings, it causes cancer in laboratory animals, etc., etc.

----------------------------------------------------------------------
"Oddballs"
----------------------------------------------------------------------

CLJ-124 GC Issue 120: Determine mechanism for controlling automatic shutdown of Agents, ...

CLJ-124 is marked as Approval=OK. Is it intended to be in that state?
There are tickets in the old Assembla system, but it isn't clear to me
from the comments which if any of them is approved.

CLJ-965 clojure.org/patches should have link to JIRA workflow wiki page added

CLJ-965 is a suggested change to clojure.org/patches, not a patch to
Clojure.

----------------------------------------------------------------------
Prescreened patches *not* marked with Fix Versions/s = "Release 1.5"

----------------------------------------------------------------------
See after the list for the meaning of characters in first two columns.

Extra unit tests

+ CLJ-730 0001-add-tests-for-complement-constantly-juxt-partial.patch

Debug/tooling enhancement, straightforward:

+ CLJ-960 columns-1.patch

Clojure library bug fixes:

+ CLJ-954 fix-tap-test-runner.diff

Allow more correct-looking Clojure code to work, some complexity:

b CLJ-757 clj-757-fix-behavior-of-empty-transient-maps-patch2.txt

Language/library enhancement, straightforward:

CLJ-909 0001-Allow-custom-buffer-size-in-LineNumberingPushbackRea.patch
CLJ-910 0001-Make-memfn-allow-for-type-hinting-the-method-receive.patch
CLJ-916 clj-916-make-into-and-others-preserve-metadata-patch2.txt
b CLJ-923 clj-923-reading-ratios-prefixed-by-plus-patch2.txt
b CLJ-925 patch.diff
b CLJ-932 CLJ-932-0001.patch
b CLJ-952 clj-952-make-bigdec-work-on-bigints-patch1.txt
CLJ-957 0001-Allow-for-typehinting-of-method-signatures-in-deftyp.patch
CLJ-958 0001-Make-APersistentVector.iterator-slightly-more-effici.patch

CLJ-963 pprint-ns-patch.diff
CLJ-966 marker-protocols.diff

Language enhancement, some complexity:

+ CLJ-308 0001-Added-ClosableResource-protocol-for-with-open.patch
CLJ-745 expose-protected-final-gen-class-clojure1.4.diff
CLJ-771 move-unchecked-casts.patch
CLJ-948 clj-948-annotate-gen-class-constructors-patch3.txt
+ CLJ-970 extend-implement-parameterized-types.diff

Language enhancement, some complexity, two similar patches available:

CLJ-827 0001-add-unsigned-bit-shift-right.patch
b CLJ-827 0001-CLJ-827-Add-bit-shift-right-logical.patch

Language enhancement, some complexity, several similar patches available:

(0001-* file adds failing tests only, so fails to test successfully)
CLJ-865 0001-Add-test-for-macroexpansion-metadata-preservation.patch
b CLJ-865 0002-Preserve-form-metadata-on-macroexpanded-forms.patch
CLJ-865 0003-Make-defmacro-preserve-form-metadata.patch
CLJ-865 0004-Another-stab-at-implementing-this.patch

Code cleanup:

CLJ-842 0001-Migrate-the-metadata-in-clojure.pprint.-to-the-new-s.patch
CLJ-964 clj-964-add-require-of-clojure-set-patch1.txt

----------------------------------------------------------------------
Prescreened patches that are either (a) marked with Fix Versions/s =
"Release 1.5" or (b) already screened
----------------------------------------------------------------------
Doc string fixes only:

b CLJ-196 0001-Fix-docstring-for-file-refs-196.patch
b CLJ-892 clj-892-clarify-sort-sort-by-doc-strings-patch1.txt
Ib CLJ-893 clj-893-doc-vec-aliases-java-array-patch2.txt
b CLJ-917 0001-Add-docstring-and-added-metadata-to-definterface.patch

Better error reporting, straightforward:

b CLJ-103 clj-103-incorrect-if-let-error-patch2.txt

Better error reporting, some complexity:

b CLJ-157 clj-157-better-err-msgs-for-defn-fn-syntax-errors-patch2.txt

Debug/tooling enhancement, straightforward:

b CLJ-788 clj-788-add-line-member-and-getter-to-CompilerException-patch.txt
b CLJ-896 clj-896-browse-url-uses-xdg-open-patch2.txt
b CLJ-902 clj-902-doc-on-namespaces-patch.txt
b CLJ-908 0001-Print-metadata-and-anonymous-classes-better.patch
b CLJ-939 0002-report-load-exceptions-with-file-and-line.diff
CLJ-943 0001-Remove-namespace-if-load-lib-fails-and-namespace-did.patch

Clojure bug fixes, straightforward:

CLJ-962 clj-962-subvec-nth-throws-on-negative-index-patch1.txt

Clojure library bug fixes:

B CLJ-768 clj-768-without-clj-881-patched-first.txt
b CLJ-783 clj-783-patch.txt
b CLJ-863 0001-make-interleave-handle-odd-arugments-in-the-same-man.patch
b CLJ-870 CLJ-753-870-905-combined-fix3.patch
(Notes on changes in attachment: CLJ-753-870-905-combined-fix3.readme.txt)
b CLJ-881 clj-881-cl-format-exception-patch2.txt
B CLJ-934 clj-934-transient-disj-patch2.txt
b CLJ-935 fix-trim-fns-different-whitespace-patch.txt
b CLJ-937 cl-format-efg-coerce-ratios-to-doubes-patch1.txt
b CLJ-945 capitalize-for-supplementary-chars-patch.txt

b CLJ-967 clj-886-improved-fix-for-ibm-jdks-patch2.txt

Allow more correct-looking Clojure code to work, some complexity:

b CLJ-667 clj-667-allow-loop-recur-nested-in-catch-and-finally-patch2.txt
B CLJ-700 clj-700-patch3.txt
b CLJ-763 clj-763-destructuring-allow-dup-keys-patch2.txt
Ib CLJ-850 clj-850-type-hinted-fn-abstractmethoderror-patch3.txt

Performance enhancement, straightforward:

CLJ-669 0001-use-java.nio-in-do-copy-method-for-Files.patch
b CLJ-858 stm-rm-msecs-patch.diff
I CLJ-867 0001-CLJ-867-Incorporate-the-record-name-into-the-hash-co.patch

Language enhancement, some complexity:

b CLJ-873 clj-873-namespace-divides-patch.txt
CLJ-949 0001-let-undeclared-exceptions-continue-unchecked.patch

----------------------------------------------------------------------
First column is one of:
+ Added to list since previous list was published on Mar 22 2012, or new patch.
* Patch updated so it still applies cleanly after recent commits.
(space) No change since previous list was published.

I Incomplete, with comments in JIRA ticket on what ought to be changed.

Second column is one of:
b In clojure-build list of patches applied.
B In clojure-build list of patches applied, in slightly modified form
due to another patch that was applied first in clojure-build's patch
list.
(space) Not in clojure-build.

clojure-build is: https://github.com/jafingerhut/clojure-build

No endorsement/criticism of the patch is implied by its
inclusion/exclusion in clojure-build. I include the info in this list
for my own bookkeeping purposes.
----------------------------------------------------------------------

(Note 1) Warnings/errors explicitly allowed in output of 'ant' command

The following warning lines are explicitly allowed in the output of
Oracle JDK 1.7.0:

[javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5

----------------------------------------------------------------------

[Alan Dipert]

Thank you again Andy for providing this, Brenton Ashworth and I will
work through what we can this afternoon and screen/provide feedback.
Alan

> --
> You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
> To post to this group, send email to cloju...@googlegroups.com.

> To unsubscribe from this group, send email to clojure-dev...@googlegroups.com.