CLJ prescreened patch list for May 31 2012
27 views
Skip to first unread message
Andy Fingerhut
May 31, 2012, 2:09:11 PM5/31/12
to cloju...@googlegroups.com
New in this week's report: Section "Tickets that might be closable
without any code changes"
List of prescreened patches for CLJ project
Date: May 31, 2012
This list of tickets is intended primarily for Clojure screeners and
committers. If you are looking for tickets that need more work, look
for the separate "Tickets needing work" list.
Prescreened means:
* The patch is in git format.
* All authors listed in the patch have signed a CA.
* Patch applies cleanly to latest master as of the date above with all
of the OS/JDK combos listed below (Note that up to May 4, 2012 the
IBM JDK version used for prescreening was 1.5.0, but with changes to
Clojure master shortly after that JDK 1.5.0 might no longer be
supported):
Mac OS X 10.6.8 + Oracle/Apple JDK 1.6.0_31
Ubuntu 11.10 + IBM JDK 1.6.0 J9 2.4
Ubuntu 11.10 + Oracle JDK 1.7.0_02
* After applying the patch, the command "./antsetup.sh ; ant" compiles
and passes all tests without warnings or errors (IBM JDK only passes
tests if the CLJ-967 patch dated May 19, 2012 is applied first,
which I did in my prescreening, and see Note 1 below for allowed
warnings).
The conditions above are straightforward to automate, and have been
automated. The patch might still be a bad idea for many reasons,
e.g. it doesn't really fix the problem, there wasn't really a problem
to begin with that needed fixing, it isn't backwards compatible with
existing Clojure code, it contains bad spelling/grammar in doc
strings, it will get you _and_ your little dog, too (Wizard of Oz
reference), etc., etc.
----------------------------------------------------------------------
"Oddballs"
----------------------------------------------------------------------
Not a ticket: Release 1.4 shows up as unreleased in JIRA?
http://groups.google.com/group/clojure-dev/browse_frm/thread/8c3582474c7e7191
CLJ-124 is marked as Approval=OK. Is it intended to be in that state?
There are patches in the old Assembla system, but it isn't clear to me
from the comments which if any of them is approved.
CLJ-124 GC Issue 120: Determine mechanism for controlling automatic shutdown of Agents, ...
----------------------------------------------------------------------
Tickets that might be closable without any code changes
----------------------------------------------------------------------
Some contributors believe that these tickets can be closed without any
code changes, perhaps because the issue is obsolete, the problem was
apparently fixed by some other commit since the issue was created,
etc.
CLJ-118 GC Issue 114: version.properties in branch/1.0 is inaccurate
CLJ-820 int coercion doesn't work in clojure 1.3
----------------------------------------------------------------------
Prescreened patches *not* marked with Fix Version/s = "Release 1.5"
----------------------------------------------------------------------
See after the list for the meaning of characters in first two columns.
Doc string fixes only:
CLJ-835 0001-CLJ-835-Refine-doc-string-for-defmulti-hierarchy-opt.patch
CLJ-980 extended-type-doc-fix-v2.patch
Debug/tooling enhancement, straightforward:
CLJ-960 columns-1.patch
CLJ-982 drupp-add-interface-predicate.diff
Clojure library bug fixes:
CLJ-828 0001-bases-should-return-a-seq-not-a-Java-array.patch
CLJ-981 rename-keys-fix.patch
Allow more correct-looking Clojure code to work, some complexity:
CLJ-373 clj-373-alter-behavior-of-update-in-with-empty-key-patch2.txt
b CLJ-757 clj-757-fix-behavior-of-empty-transient-maps-patch2.txt
CLJ-977 0001-CLJ-977-int-a-returns-a-value-long-a-throws-an-excep.patch
Language/library enhancement, straightforward:
CLJ-909 0001-Allow-custom-buffer-size-in-LineNumberingPushbackRea.patch
CLJ-910 0001-Make-memfn-allow-for-type-hinting-the-method-receive.patch
CLJ-916 clj-916-make-into-and-others-preserve-metadata-patch2.txt
b CLJ-923 clj-923-reading-ratios-prefixed-by-plus-patch2.txt
b CLJ-925 patch.diff
b CLJ-932 CLJ-932-0001.patch
CLJ-957 0001-Allow-for-typehinting-of-method-signatures-in-deftyp.patch
CLJ-958 0001-Make-APersistentVector.iterator-slightly-more-effici.patch
CLJ-963 pprint-ns-patch.diff
CLJ-966 marker-protocols.diff
CLJ-978 clojure--bean-support-for-private-implementation-classes-v3.diff
CLJ-1004 arraychunk-seq-10004.diff
Language enhancement, some complexity:
CLJ-248 clj-248-SortedMap-SortedSet-interfaces-patch2.txt
CLJ-308 0001-Added-ClosableResource-protocol-for-with-open.patch
CLJ-745 expose-protected-final-gen-class-clojure1.4.diff
CLJ-771 move-unchecked-casts-v2.patch
CLJ-948 clj-948-annotate-gen-class-constructors-patch3.txt
CLJ-970 extend-implement-parameterized-types.diff
CLJ-988 issue988-lockless-multifn.diff
Language enhancement, new reducers planned for Clojure 1.5:
CLJ-991 reducer-partition-by.diff
CLJ-992 0001-Add-reducers-iterate.patch
Language enhancement, some complexity, two similar patches available:
CLJ-827 0001-add-unsigned-bit-shift-right.patch
b CLJ-827 0001-CLJ-827-Add-bit-shift-right-logical.patch
Language enhancement, some complexity, several similar patches available:
(0001-* file adds failing tests only, so fails to test successfully)
CLJ-865 0001-Add-test-for-macroexpansion-metadata-preservation.patch
b CLJ-865 0002-Preserve-form-metadata-on-macroexpanded-forms.patch
CLJ-865 0003-Make-defmacro-preserve-form-metadata.patch
CLJ-865 0004-Another-stab-at-implementing-this.patch
Performance enhancement:
CLJ-703 improve-writeclassfile-perf.patch
CLJ-862 pmap-chunking-862.diff
CLJ-1005 0001-Use-transient-map-in-zipmap.patch
Code cleanup:
CLJ-842 0001-Migrate-the-metadata-in-clojure.pprint.-to-the-new-s.patch
CLJ-964 clj-964-add-require-of-clojure-set-patch1.txt
----------------------------------------------------------------------
Prescreened patches that are marked with Fix Version/s = "Release
1.5", but not screened
----------------------------------------------------------------------
Better error reporting, straightforward:
b CLJ-897 clj-897-deftype-error-message-is-misleading-patch.txt
b CLJ-940 clj-940-add-exception-for-non-sequence-in-refer-only-patch.txt
Better error reporting, some complexity:
b CLJ-157 clj-157-better-err-msgs-for-defn-fn-syntax-errors-patch2.txt
Debug/tooling enhancement, straightforward:
b CLJ-788 clj-788-add-line-member-and-getter-to-CompilerException-patch.txt
b CLJ-896 clj-896-browse-url-uses-xdg-open-patch2.txt
b CLJ-902 clj-902-doc-on-namespaces-patch.txt
b CLJ-908 clj-908-Print-metadata-and-anonymous-classes-better-patch2.txt
b CLJ-939 0002-report-load-exceptions-with-file-and-line.diff
CLJ-943 0001-Remove-namespace-if-load-lib-fails-and-namespace-did.patch
CLJ-987 0001-pprint-now-flushes-the-underlying-stream-similarly-t.patch
Clojure library bug fixes:
b CLJ-768 clj-768-patch-for-after-clj-881-fixed-patch2.txt
b CLJ-783 clj-783-patch.txt
CLJ-844 0001-CLJ-844-NPE-calling-keyword-on-map-from-bean.patch
b CLJ-863 0001-make-interleave-handle-odd-arugments-in-the-same-man.patch
b CLJ-870 CLJ-753-870-905-combined-fix3.patch
(Notes on changes in attachment: CLJ-753-870-905-combined-fix3.readme.txt)
B CLJ-934 clj-934-transient-disj-patch2.txt
b CLJ-935 fix-trim-fns-different-whitespace-patch.txt
b CLJ-937 cl-format-efg-coerce-ratios-to-doubes-patch1.txt
b CLJ-945 capitalize-for-supplementary-chars-patch.txt
Disable failing tests:
b CLJ-967 clj-967-disable-failing-io-copy-tests-on-ibm-jdk-16-patch1.txt
Allow more correct-looking Clojure code to work, some complexity:
b CLJ-667 clj-667-allow-loop-recur-nested-in-catch-and-finally-patch2.txt
B CLJ-700 clj-700-patch3.txt
Ib CLJ-850 clj-850-type-hinted-fn-abstractmethoderror-patch3.txt
Performance enhancement, straightforward:
CLJ-669 0001-use-java.nio-in-do-copy-method-for-Files.patch
b CLJ-858 stm-rm-msecs-patch.diff
Language enhancement, some complexity:
b CLJ-873 clj-873-namespace-divides-patch.txt
CLJ-949 0001-let-undeclared-exceptions-continue-unchecked.patch
CLJ-976 CLJ-976-queue-literal-eval.diff
----------------------------------------------------------------------
Prescreened, and screened or accepted
----------------------------------------------------------------------
Doc string fixes only:
b CLJ-196 0001-Fix-docstring-for-file-refs-196.patch
b CLJ-917 0001-Add-docstring-and-added-metadata-to-definterface.patch
----------------------------------------------------------------------
First column is one of:
I Incomplete, with comments in JIRA ticket on what ought to be changed.
Second column is one of:
b In clojure-build list of patches applied.
B In clojure-build list of patches applied, in slightly modified form
due to another patch that was applied first in clojure-build's patch
list.
(space) Not in clojure-build.
clojure-build is: https://github.com/jafingerhut/clojure-build
No endorsement/criticism of the patch is implied by its
inclusion/exclusion in clojure-build. I include the info in this list
for my own bookkeeping purposes.
----------------------------------------------------------------------
(Note 1) Warnings/errors explicitly allowed in output of 'ant' command
The following warning lines are explicitly allowed in the output of
Oracle JDK 1.7.0:
[javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
----------------------------------------------------------------------
without any code changes"
List of prescreened patches for CLJ project
Date: May 31, 2012
This list of tickets is intended primarily for Clojure screeners and
committers. If you are looking for tickets that need more work, look
for the separate "Tickets needing work" list.
Prescreened means:
* The patch is in git format.
* All authors listed in the patch have signed a CA.
* Patch applies cleanly to latest master as of the date above with all
of the OS/JDK combos listed below (Note that up to May 4, 2012 the
IBM JDK version used for prescreening was 1.5.0, but with changes to
Clojure master shortly after that JDK 1.5.0 might no longer be
supported):
Mac OS X 10.6.8 + Oracle/Apple JDK 1.6.0_31
Ubuntu 11.10 + IBM JDK 1.6.0 J9 2.4
Ubuntu 11.10 + Oracle JDK 1.7.0_02
* After applying the patch, the command "./antsetup.sh ; ant" compiles
and passes all tests without warnings or errors (IBM JDK only passes
tests if the CLJ-967 patch dated May 19, 2012 is applied first,
which I did in my prescreening, and see Note 1 below for allowed
warnings).
The conditions above are straightforward to automate, and have been
automated. The patch might still be a bad idea for many reasons,
e.g. it doesn't really fix the problem, there wasn't really a problem
to begin with that needed fixing, it isn't backwards compatible with
existing Clojure code, it contains bad spelling/grammar in doc
strings, it will get you _and_ your little dog, too (Wizard of Oz
reference), etc., etc.
----------------------------------------------------------------------
"Oddballs"
----------------------------------------------------------------------
Not a ticket: Release 1.4 shows up as unreleased in JIRA?
http://groups.google.com/group/clojure-dev/browse_frm/thread/8c3582474c7e7191
CLJ-124 is marked as Approval=OK. Is it intended to be in that state?
There are patches in the old Assembla system, but it isn't clear to me
from the comments which if any of them is approved.
CLJ-124 GC Issue 120: Determine mechanism for controlling automatic shutdown of Agents, ...
----------------------------------------------------------------------
Tickets that might be closable without any code changes
----------------------------------------------------------------------
Some contributors believe that these tickets can be closed without any
code changes, perhaps because the issue is obsolete, the problem was
apparently fixed by some other commit since the issue was created,
etc.
CLJ-118 GC Issue 114: version.properties in branch/1.0 is inaccurate
CLJ-820 int coercion doesn't work in clojure 1.3
----------------------------------------------------------------------
Prescreened patches *not* marked with Fix Version/s = "Release 1.5"
----------------------------------------------------------------------
See after the list for the meaning of characters in first two columns.
Doc string fixes only:
CLJ-835 0001-CLJ-835-Refine-doc-string-for-defmulti-hierarchy-opt.patch
CLJ-980 extended-type-doc-fix-v2.patch
Debug/tooling enhancement, straightforward:
CLJ-960 columns-1.patch
CLJ-982 drupp-add-interface-predicate.diff
Clojure library bug fixes:
CLJ-828 0001-bases-should-return-a-seq-not-a-Java-array.patch
CLJ-981 rename-keys-fix.patch
Allow more correct-looking Clojure code to work, some complexity:
CLJ-373 clj-373-alter-behavior-of-update-in-with-empty-key-patch2.txt
b CLJ-757 clj-757-fix-behavior-of-empty-transient-maps-patch2.txt
CLJ-977 0001-CLJ-977-int-a-returns-a-value-long-a-throws-an-excep.patch
Language/library enhancement, straightforward:
CLJ-909 0001-Allow-custom-buffer-size-in-LineNumberingPushbackRea.patch
CLJ-910 0001-Make-memfn-allow-for-type-hinting-the-method-receive.patch
CLJ-916 clj-916-make-into-and-others-preserve-metadata-patch2.txt
b CLJ-923 clj-923-reading-ratios-prefixed-by-plus-patch2.txt
b CLJ-925 patch.diff
b CLJ-932 CLJ-932-0001.patch
CLJ-957 0001-Allow-for-typehinting-of-method-signatures-in-deftyp.patch
CLJ-958 0001-Make-APersistentVector.iterator-slightly-more-effici.patch
CLJ-963 pprint-ns-patch.diff
CLJ-966 marker-protocols.diff
CLJ-978 clojure--bean-support-for-private-implementation-classes-v3.diff
CLJ-1004 arraychunk-seq-10004.diff
Language enhancement, some complexity:
CLJ-248 clj-248-SortedMap-SortedSet-interfaces-patch2.txt
CLJ-308 0001-Added-ClosableResource-protocol-for-with-open.patch
CLJ-745 expose-protected-final-gen-class-clojure1.4.diff
CLJ-771 move-unchecked-casts-v2.patch
CLJ-948 clj-948-annotate-gen-class-constructors-patch3.txt
CLJ-970 extend-implement-parameterized-types.diff
CLJ-988 issue988-lockless-multifn.diff
Language enhancement, new reducers planned for Clojure 1.5:
CLJ-991 reducer-partition-by.diff
CLJ-992 0001-Add-reducers-iterate.patch
Language enhancement, some complexity, two similar patches available:
CLJ-827 0001-add-unsigned-bit-shift-right.patch
b CLJ-827 0001-CLJ-827-Add-bit-shift-right-logical.patch
Language enhancement, some complexity, several similar patches available:
(0001-* file adds failing tests only, so fails to test successfully)
CLJ-865 0001-Add-test-for-macroexpansion-metadata-preservation.patch
b CLJ-865 0002-Preserve-form-metadata-on-macroexpanded-forms.patch
CLJ-865 0003-Make-defmacro-preserve-form-metadata.patch
CLJ-865 0004-Another-stab-at-implementing-this.patch
Performance enhancement:
CLJ-703 improve-writeclassfile-perf.patch
CLJ-862 pmap-chunking-862.diff
CLJ-1005 0001-Use-transient-map-in-zipmap.patch
Code cleanup:
CLJ-842 0001-Migrate-the-metadata-in-clojure.pprint.-to-the-new-s.patch
CLJ-964 clj-964-add-require-of-clojure-set-patch1.txt
----------------------------------------------------------------------
Prescreened patches that are marked with Fix Version/s = "Release
1.5", but not screened
----------------------------------------------------------------------
Better error reporting, straightforward:
b CLJ-897 clj-897-deftype-error-message-is-misleading-patch.txt
b CLJ-940 clj-940-add-exception-for-non-sequence-in-refer-only-patch.txt
Better error reporting, some complexity:
b CLJ-157 clj-157-better-err-msgs-for-defn-fn-syntax-errors-patch2.txt
Debug/tooling enhancement, straightforward:
b CLJ-788 clj-788-add-line-member-and-getter-to-CompilerException-patch.txt
b CLJ-896 clj-896-browse-url-uses-xdg-open-patch2.txt
b CLJ-902 clj-902-doc-on-namespaces-patch.txt
b CLJ-908 clj-908-Print-metadata-and-anonymous-classes-better-patch2.txt
b CLJ-939 0002-report-load-exceptions-with-file-and-line.diff
CLJ-943 0001-Remove-namespace-if-load-lib-fails-and-namespace-did.patch
CLJ-987 0001-pprint-now-flushes-the-underlying-stream-similarly-t.patch
Clojure library bug fixes:
b CLJ-768 clj-768-patch-for-after-clj-881-fixed-patch2.txt
b CLJ-783 clj-783-patch.txt
CLJ-844 0001-CLJ-844-NPE-calling-keyword-on-map-from-bean.patch
b CLJ-863 0001-make-interleave-handle-odd-arugments-in-the-same-man.patch
b CLJ-870 CLJ-753-870-905-combined-fix3.patch
(Notes on changes in attachment: CLJ-753-870-905-combined-fix3.readme.txt)
B CLJ-934 clj-934-transient-disj-patch2.txt
b CLJ-935 fix-trim-fns-different-whitespace-patch.txt
b CLJ-937 cl-format-efg-coerce-ratios-to-doubes-patch1.txt
b CLJ-945 capitalize-for-supplementary-chars-patch.txt
Disable failing tests:
b CLJ-967 clj-967-disable-failing-io-copy-tests-on-ibm-jdk-16-patch1.txt
Allow more correct-looking Clojure code to work, some complexity:
b CLJ-667 clj-667-allow-loop-recur-nested-in-catch-and-finally-patch2.txt
B CLJ-700 clj-700-patch3.txt
Ib CLJ-850 clj-850-type-hinted-fn-abstractmethoderror-patch3.txt
Performance enhancement, straightforward:
CLJ-669 0001-use-java.nio-in-do-copy-method-for-Files.patch
b CLJ-858 stm-rm-msecs-patch.diff
Language enhancement, some complexity:
b CLJ-873 clj-873-namespace-divides-patch.txt
CLJ-949 0001-let-undeclared-exceptions-continue-unchecked.patch
CLJ-976 CLJ-976-queue-literal-eval.diff
----------------------------------------------------------------------
Prescreened, and screened or accepted
----------------------------------------------------------------------
Doc string fixes only:
b CLJ-196 0001-Fix-docstring-for-file-refs-196.patch
b CLJ-917 0001-Add-docstring-and-added-metadata-to-definterface.patch
----------------------------------------------------------------------
First column is one of:
I Incomplete, with comments in JIRA ticket on what ought to be changed.
Second column is one of:
b In clojure-build list of patches applied.
B In clojure-build list of patches applied, in slightly modified form
due to another patch that was applied first in clojure-build's patch
list.
(space) Not in clojure-build.
clojure-build is: https://github.com/jafingerhut/clojure-build
No endorsement/criticism of the patch is implied by its
inclusion/exclusion in clojure-build. I include the info in this list
for my own bookkeeping purposes.
----------------------------------------------------------------------
(Note 1) Warnings/errors explicitly allowed in output of 'ant' command
The following warning lines are explicitly allowed in the output of
Oracle JDK 1.7.0:
[javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
----------------------------------------------------------------------
Brandon Bloom
May 31, 2012, 7:19:10 PM5/31/12
to cloju...@googlegroups.com
> No endorsement/criticism of the patch is implied by its inclusion/exclusion in clojure-build. I include the info in this list for my own bookkeeping purposes.
I seem to have figured out the process for ClojureScript: Pester David! Is the story similar for Clojure itself? I'd really like to make the most of my scarce hours that I have to contribute. Who do I need to bribe? :-)
Andy Fingerhut
Jun 1, 2012, 1:28:38 PM6/1/12
to cloju...@googlegroups.com
I've been told by several Clojure screeners that the prescreening process from which I produce these weekly reports is helpful in getting attention on patches that are ready.
I am curious to hear from Clojure screeners if there is something more they would find helpful. What can you think of that contributors can do to help move patches along?
e.g. would it help if contributors read and carefully evaluated patches they didn't write, and added comments to the tickets with what they found (good or bad)?
Does anyone look at JIRA's vote counts for tickets when deciding what to evaluate? If that isn't done now, would it help if there was a version of the prescreened patch list sorted from most to fewest votes? This might encourage contributors to vote for their favorites, if they knew it could make a difference.
Something else?
Andy
Stuart Halloway
Jun 8, 2012, 3:30:00 PM6/8/12
to cloju...@googlegroups.com
> David Nolen seems to be a collective of about 20 people sharing on-line accounts, or he doesn't sleep :-) Seriously, his rate of getting improvements into ClojureScript is a pleasure to behold.
>
> I've been told by several Clojure screeners that the prescreening process from which I produce these weekly reports is helpful in getting attention on patches that are ready.
>
> I am curious to hear from Clojure screeners if there is something more they would find helpful. What can you think of that contributors can do to help move patches along?
>
> e.g. would it help if contributors read and carefully evaluated patches they didn't write, and added comments to the tickets with what they found (good or bad)?
More comments on tickets would be great.
>
> I've been told by several Clojure screeners that the prescreening process from which I produce these weekly reports is helpful in getting attention on patches that are ready.
>
> I am curious to hear from Clojure screeners if there is something more they would find helpful. What can you think of that contributors can do to help move patches along?
>
> e.g. would it help if contributors read and carefully evaluated patches they didn't write, and added comments to the tickets with what they found (good or bad)?
> Does anyone look at JIRA's vote counts for tickets when deciding what to evaluate? If that isn't done now, would it help if there was a version of the prescreened patch list sorted from most to fewest votes? This might encourage contributors to vote for their favorites, if they knew it could make a difference.
> Something else?
>
> Andy
Reply all
Reply to author
Forward
0 new messages