Bug in 1.2 clojure.set/subset? and superset? for false/nil values.

9 views
Skip to first unread message

Jason Wolfe

unread,
Sep 21, 2010, 12:07:09 AM9/21/10
to Clojure Dev
user> (clojure.set/subset? #{false} #{false})
false

Actually my bug from some time ago, sorry! The fix is simple, "every?
s" --> "every? #(contains? s %)" in both cases. Should I make a
ticket / patch / tests?

-Jason

Stuart Halloway

unread,
Sep 21, 2010, 7:42:47 AM9/21/10
to cloju...@googlegroups.com
Yes please.

> --
> You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
> To post to this group, send email to cloju...@googlegroups.com.
> To unsubscribe from this group, send email to clojure-dev...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/clojure-dev?hl=en.
>

Jason Wolfe

unread,
Sep 21, 2010, 3:13:26 PM9/21/10
to Clojure Dev
https://www.assembla.com/spaces/clojure/tickets/437-bugs-in-clojure-set-subset--and-superset--for-sets-with-false-nil-elements

There's a patch that adds tests and fixes the bugs attached to the
ticket.

On Sep 21, 4:42 am, Stuart Halloway <stuart.hallo...@gmail.com> wrote:
> Yes please.
>
> > user> (clojure.set/subset? #{false} #{false})
> > false
>
> > Actually my bug from some time ago, sorry!  The fix is simple, "every?
> > s" --> "every? #(contains? s %)" in both cases.  Should I make a
> > ticket / patch / tests?
>
> > -Jason
>
> > --
> > You received this message because you are subscribed to the Google Groups "Clojure Dev" group.> To post to this group, send email tocloj...@googlegroups.com.> To unsubscribe from this group, send email toclojure-de...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages