[CKEditor Dev] #6585: [Opera] Close inline style fails
CKEditor
---------------------------+------------------------------------------------
Reporter: garry.yao | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: Core : Styles | Version: 3.4.1
Keywords: Opera |
---------------------------+------------------------------------------------
1. Start typing a few words within an empty page;
1. Click to open 'Bold' style, continue to type some words;
1. Click again on 'Bold' to close the style;
* Actual Result: Selection is still inside the strong element.
Doesn't seems to be a regression.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585>
CKEditor <http://ckeditor.com/>
The text editor for Internet
CKEditor
---------------------------+------------------------------------------------
Reporter: garry.yao | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: Core : Styles | Version: 3.4.1
Keywords: Opera |
---------------------------+------------------------------------------------
Comment(by garry.yao):
Confirmed in Opera 11 Alpha/10.6.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:1>
CKEditor
---------------------------+------------------------------------------------
Reporter: garry.yao | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: Core : Styles | Version: 3.4.1
Keywords: Opera |
---------------------------+------------------------------------------------
Comment(by robmueller):
This isn't just an Opera problem. In Chrome (8 and 9) and Safari (5)
changing the Bold/Italic/Underline style doesn't work at all unless you
have some text selected. If it's just an insert cursor, nothing changes.
It all appears to work ok in Firefox and IE (8 and 9PP7).
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:2>
CKEditor
---------------------------+------------------------------------------------
Reporter: garry.yao | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: Core : Styles | Version: 3.4.1
Keywords: Opera |
---------------------------+------------------------------------------------
> 1. Start typing a few words within an empty page;
> 1. Click to open 'Bold' style, continue to type some words;
> 1. Click again on 'Bold' to close the style;
> * Actual Result: Selection is still inside the strong element.
>
> Doesn't seems to be a regression.
1. Start typing a few words within an empty page;
1. Click to open 'Bold' style, continue to type some words;
1. Click again on 'Bold' to close the style;
* Actual Result: Selection is still inside the strong element.
Doesn't seems to be a regression.
--
Comment(by garry.yao):
Ok, only happens when text selection is at the end of the block, which
degrade it's priority.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:3>
CKEditor
Reporter: garry.yao | Owner:
Type: Bug | Status: confirmed
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Changes (by hallvord@…):
* status: new => confirmed
Comment:
it seems to work OK again in Chrome, leaving Opera as the only browser
with the problem..
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:4>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner:
Type: Bug | Status: confirmed
Priority: High | Milestone:
----------------------------+-----------------------
Changes (by hallvord@…):
* priority: Normal => High
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:5>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: review
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Changes (by garry.yao):
* owner: => garry.yao
* priority: High => Normal
* status: confirmed => review
Comment:
Update: The impact of the bug is actually much wider than observed, as the
following selection situations are also affected:
{{{
<p><strong>bold^</strong></p> // Ticket TC
<p><strong>^bold</strong></p>
<p><a href="#">link with <strong>bold^</strong></a> text</p>
<p><a href="#">link with <strong>^bold^</strong></a> text</p>
}}}
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:6>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: review
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by hallvord@…):
Since you're working on this at the moment, do you know what Opera does
differently from, say, Chrome? If you could explain what the difference
is, we could prioritise a fix on our side and you would not need to add
further Opera sniffing to your code base!
(PS: sorry to have messed with your priorities and other state yesterday,
just wanted to boost priority to get to this shortly myself.)
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:7>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: review
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by hallvord@…):
(BTW, does this patch change behaviour regarding #6874 ?)
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:8>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: review
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Changes (by satya):
* cc: satya_minnekanti@… (added)
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:9>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: review
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by fredck):
Replying to [comment:7 hallvord@…]:
> Since you're working on this at the moment, do you know what Opera does
differently from, say, Chrome? If you could explain what the difference
is, we could prioritise a fix on our side and you would not need to add
further Opera sniffing to your code base!
>
> (PS: sorry to have messed with your priorities and other state
yesterday, just wanted to boost priority to get to this shortly myself.)
I would love to see that, Hallvord. Here you have the issue at your
side:[[BR]]
https://bugs.opera.com/browse/CORE-38253
To workaround the problem, the patch proposed by Garry is appending and
empty text node to the selection point (which I believe will be the fix at
your side as well).
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:10>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: review
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by hallvord@…):
Thanks for the bug report. I'm right now testing an internal build with
cursor-related changes, and the original problem seems to work OK in that
build (without Garry's workaround)!
To be clear, how I'm testing is for example
* create a new document
* type 'hello ' (no quotes)
* press ctrl-b
* type 'world' (no quotes)
* press ctrl-b
* type ', this is me'
In the internal build, only the word 'world' will be bold. Since the new
test case still fails, we probably have more than one issue..
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:11>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Changes (by fredck):
* status: review => assigned
Comment:
I'm holding on this one at our side at this point, waiting for some
conclusion at Opera's side.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:12>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Changes (by fredck):
* cc: satya_minnekanti@… (removed)
* cc: satya, damo, tmonahan, jamescun (added)
* keywords: Opera => Opera IBM
Comment:
#7802 has been marked as DUP.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:13>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by hallvord@…):
testing with ctrl-b works fine, but for some reason the cursor goes to the
start of the document when using the B button on the toolbar to toggle
bold off. I'm not sure why ctrl-b and the button would behave differently,
but I guess you need to restore the cursor position after clicks in the
toolbar and this breaks something?
I don't think we'll get this fixed from our side in the near future, so if
Garry's patch solves this please apply it.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:14>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by j.swiderski):
This issue was duplicated in #8143.
@mike1 has proposed little different TC: Clear editor, turn on one of
bold/italic/underline/strikethrough, type some text, press the same button
again to turn off formatting.
Result - you can't turn off formatting (this part has been from CKE 3.0)
and the cursor goes to the beginning of the text (this part has been from
CKE 3.5).
This TC is not applicable for subscript and superscript. I mean you can’t
turn them off also but they don’t cause cursor to go back to the beginning
of text.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:15>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by hallvord@…):
Did you add a workaround? The real editor works better in some of our
internal builds now, though the test still fails.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:16>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.4.1
----------------------------+-----------------------
Comment (by fredck):
I don't think we have any workaround for it.
My current tests with Opera 11.52 (Build 1100) are even worst. On step 3,
the caret moves to the start of the paragraph.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:17>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.0
Resolution: | Keywords: Opera IBM
----------------------------+-----------------------
* version: 3.4.1 => 3.0
Comment:
#8515 was marked as duplicate.
This TC with ENTER_BR set is applicable for format buttons as well as
inline styles from "Styles Dropdown".
1. If you select style type and then deselect it there is no effect
(**from CKE 3.0**) and cursor jumps to the beginning (**from CKE 3.4**)
2. The same thing happens when you apply inline style to selection.
3. **NEW** When you clear editor contents, select inline style and start
typing and press enter, cursor will jump to the beginning of line/document
(**from CKE 3.0**). Perhaps this should be reported in separate ticket.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:18>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.0
Resolution: | Keywords: Opera IBM
----------------------------+-----------------------
Comment (by j.swiderski):
#9135 was marked as duplicate.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:20>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.0
Resolution: | Keywords: Opera IBM
----------------------------+-----------------------
Comment (by j.swiderski):
'''Summary'''
**In ENTER_BR**
1. If in **ENTER_BR** you select style type and then deselect it there is
no effect (**from CKE 3.0**) and cursor jumps to the beginning (**from CKE
3.4**)
2. The same thing happens when you apply inline style to selection and you
are in **ENTER_BR** - cursor jumps to the beginning.
3. When you clear editor contents and you are in **ENTER_BR**, select
inline style and start typing and press enter, cursor will jump to the
beginning of line/document (**from CKE 3.0**).
**In any enter mode **
1. Select bold/italic /underline, type some text and try to deselect
these styles. From CKEditor 3.0 to CKEditor 3.4 you are not able to
deselect last style you have chosen. From CKEditor 3.4.1 you are not able
to deselect last style left. This is applicable for all inline styles
including font-sizes, font-names, inline styles and format buttons.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:21>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.0
Resolution: | Keywords: Opera IBM
----------------------------+-----------------------
Old description:
> 1. Start typing a few words within an empty page;
> 1. Click to open 'Bold' style, continue to type some words;
> 1. Click again on 'Bold' to close the style;
> * Actual Result: Selection is still inside the strong element.
>
> Doesn't seems to be a regression.
New description:
1. Start typing a few words within an empty page;
1. Click to open 'Bold' style, continue to type some words;
1. Click again on 'Bold' to close the style;
* Actual Result: Selection is still inside the strong element.
Doesn't seems to be a regression.
To summarize, this TC is applicable for format buttons as well as inline
styles from "Styles Dropdown", font names and font sizes - **All inline
styles**.
Checkout [comment:20 comment 20] for more details
--
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:19>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Type: Bug | Status: assigned
Component: Core : Styles | Version: 3.0
Resolution: | Keywords: Opera IBM
----------------------------+-----------------------
Comment (by hallvord@…):
Just a status report from our side: we've completed a big rewrite of the
selection/range code in Opera. While intermittently testing the work-in-
progress I saw improvements, but unfortunately it seems this is still a
problem in the rewritten code as currently shipping.
The good news is that there has been considerable action on the bug you
submitted about this issue over the last few days. We believe we have a
fix, it just needs to be verified regression-free when tested against our
existing test suites. There are some failures which QA is investigating
right now - maybe some of the old tests need adjusting, or maybe the code
still needs some tuning. I'll comment here again when I know roughly when
the fix will be shipping.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:22>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: garry.yao | Owner: garry.yao
Priority: Normal | Milestone:
Component: Core : Styles | Version: 3.0
Resolution: fixed | Keywords: Opera IBM
----------------------------+-----------------------
Changes (by j.swiderski):
* status: assigned => closed
* resolution: => fixed
Comment:
I have checked TCs mentioned here for latest Opera 12.12 and editor 3.6.5
and I must say they all pass :).
The only thing I have noticed is:
>>in ENTER_BR you select style type press enter, cursor will jump to the
beginning of line/document
The good news is that this is only visual bug. If you type despite cursor
being at the top of document, both letters and cursor will show up in
right place.
I think that this bug can be now closed.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6585#comment:23>
CKEditor <http://ckeditor.com/>
The text editor for the Internet