[CKEditor Dev] #8463: WebKit: Cut/Copy don't go on "enabled" state
CKEditor
-----------------------------+-----------------
Reporter: fredck | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: General | Version:
Keywords: WebKit HasPatch |
-----------------------------+-----------------
Original message from our contact form, Ticket REF : 3815-QDFX-1500.
----
I found that 'cut' and 'copy' icons do not go to enabled state after you
select text in editor (chrome v. 14.0.835.202 m windows). After exploring
this I found that there is a problem with queryCommandEnabled function in
clipboard plugin, so I propose a solution to you.
{{{
function stateFromNamedCommand( command, editor )
{
// IE Bug: queryCommandEnabled('paste') fires also
'beforepaste(copy/cut)',
// guard to distinguish from the ordinary sources( either
// keyboard paste or execCommand ) (#4874).
CKEDITOR.env.ie && ( depressBeforeEvent = 1 );
var retval = CKEDITOR.TRISTATE_OFF;
try {retval = editor.document.$.queryCommandEnabled( command ) ||
CKEDITOR.env.webkit && editor.getSelection().getRanges()[0].startOffset !=
editor.getSelection().getRanges()[0].endOffset ? CKEDITOR.TRISTATE_OFF :
CKEDITOR.TRISTATE_DISABLED;}catch( er ){}
depressBeforeEvent = 0;
return retval;
}
}}}
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: fredck | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version: 3.5.1
Resolution: | Keywords: WebKit HasPatch
----------------------+-----------------------------
Changes (by j.swiderski):
* status: new => confirmed
* version: => 3.5.1
Comment:
Reproducible from CKEditor 3.5.1 rev [6311]
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:1>
CKEditor
Reporter: fredck | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Resolution: | Keywords: WebKit HasPatch
----------------------+-----------------------------
Comment (by Reinmar):
That bug is visible from rev [6311] because in this revision states of
buttons had been bound to what `stateFromNamedComand` is returning. This
function was buggy even before that.
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:2>
CKEditor
Reporter: fredck | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version: 3.5.1
Resolution: | Keywords: WebKit HasPatch
----------------------+-----------------------------
Comment (by dbrownITR):
Are there any plans to integrate the proposed patch?
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:3>
CKEditor
Reporter: fredck | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version: 3.5.1
Resolution: | Keywords: WebKit HasPatch
----------------------+-----------------------------
Comment (by astjohn):
I would also like to see a solution for this issue.
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:4>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: review
Priority: Normal | Milestone:
Component: General | Version: 3.5.1
Resolution: | Keywords: WebKit HasPatch
----------------------+-----------------------------
* owner: => Reinmar
* status: confirmed => review
Comment:
This issue is already fixed in dev version of next major release
(inaccessible for you).
I ported correct patch to version 3.6.3 - you can apply it if you want, or
wait for new major or bugfixing release.
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:5>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: review
Component: General | Version: 3.6.4 (SVN - trunk)
Resolution: | Keywords: WebKit HasPatch
----------------------+---------------------------------
Changes (by Reinmar):
* version: 3.5.1 => 3.6.4 (SVN - trunk)
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:6>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: review
Component: General | Version: 3.6.4 (SVN - trunk)
Resolution: | Keywords: WebKit HasPatch
----------------------+---------------------------------
Comment (by astjohn):
@Reinmar, that's awesome. Thank you for this!
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:7>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: review
Component: General | Version: 3.6.4 (SVN - trunk)
Resolution: | Keywords: WebKit HasPatch
----------------------+---------------------------------
* milestone: => CKEditor 3.6.4
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:8>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: review_passed
Priority: Normal | Milestone: CKEditor 3.6.4
Resolution: | Keywords: WebKit
---------------------------+---------------------------------
Changes (by garry.yao):
* keywords: WebKit HasPatch => WebKit
* status: review => review_passed
* component: General => UI : Toolbar
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:9>
CKEditor
Reporter: fredck | Owner: Reinmar
Priority: Normal | Milestone: CKEditor 3.6.4
Component: UI : Toolbar | Version: 3.6.4 (SVN - trunk)
---------------------------+---------------------------------
Changes (by Reinmar):
* status: review_passed => closed
* resolution: => fixed
Comment:
Fixed with [7504].
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:10>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: closed
Priority: Normal | Milestone: CKEditor 3.6.4
Resolution: fixed | Keywords: WebKit
---------------------------+----------------------------
Changes (by wwalc):
* version: 3.6.4 (SVN - trunk) => 3.5.1
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:11>
CKEditor
Reporter: fredck | Owner: Reinmar
Type: Bug | Status: closed
Priority: Normal | Milestone: CKEditor 3.6.4
Component: UI : Toolbar | Version: 3.5.1
Resolution: fixed | Keywords: WebKit
---------------------------+----------------------------
Comment (by j.swiderski):
#9143 - there is still a problem when you select content with cursor
placed underneath this content.
--
Ticket URL: <http://dev.ckeditor.com/ticket/8463#comment:12>