Message from discussion
Add locatorIndex to Nodes to speed up get/set/drop on main thread DOM... (issue414030)
X-BeenThere: chromium-reviews@googlegroups.com
Received: by 10.90.1.25 with SMTP id 25ls2579468aga.3.p; Mon, 30 Nov 2009
07:02:36 -0800 (PST)
Received: by 10.90.13.23 with SMTP id 23mr6095468agm.2.1259593356315;
Mon, 30 Nov 2009 07:02:36 -0800 (PST)
Received: by 10.90.13.23 with SMTP id 23mr6095467agm.2.1259593356291;
Mon, 30 Nov 2009 07:02:36 -0800 (PST)
Return-Path: <3jN4TSxgJAMkrw6x78xp2.40t72t6.wp27t2v1px0....@apphosting.bounces.google.com>
Received: from mail-yx0-f233.google.com (mail-yx0-f233.google.com [209.85.210.233])
by gmr-mx.google.com with ESMTP id 18si406540ywh.9.2009.11.30.07.02.36;
Mon, 30 Nov 2009 07:02:36 -0800 (PST)
Received-SPF: pass (google.com: domain of 3jN4TSxgJAMkrw6x78xp2.40t72t6.wp27t2v1px0....@apphosting.bounces.google.com designates 209.85.210.233 as permitted sender) client-ip=209.85.210.233;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3jN4TSxgJAMkrw6x78xp2.40t72t6.wp27t2v1px0....@apphosting.bounces.google.com designates 209.85.210.233 as permitted sender) smtp.mail=3jN4TSxgJAMkrw6x78xp2.40t72t6.wp27t2v1px0....@apphosting.bounces.google.com
Received: by mail-yx0-f233.google.com with SMTP id 22so346428yxe.3
for <chromium-reviews@googlegroups.com>; Mon, 30 Nov 2009 07:02:36 -0800 (PST)
MIME-Version: 1.0
Reply-To: christian.plesner.han...@gmail.com, ant...@chromium.org,
chromium-reviews@googlegroups.com
Received: by 10.101.180.36 with SMTP id h36mr4912305anp.20.1259593356105; Mon,
30 Nov 2009 07:02:36 -0800 (PST)
Message-ID: <001636c927f18d5b2f047997eee7@google.com>
Date: Mon, 30 Nov 2009 15:02:36 +0000
Subject: Add locatorIndex to Nodes to speed up get/set/drop on main thread
DOM... (issue414030)
From: christian.plesner.han...@gmail.com
To: ant...@chromium.org
Cc: chromium-reviews@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
Reviewers: antonm,
Message:
Hi Anton,
Here's the changelist we talked about. One issue I forgot when I made this
was
to shrink the node map when removing elements, we have to remember to do
that.
-- Christian
Description:
Add locatorIndex to Nodes to speed up get/set/drop on main thread DOM
node map.
Please review this at http://codereview.chromium.org/414030
SVN Base: http://svn.webkit.org/repository/webkit/trunk/
Affected files:
M WebCore/bindings/v8/DOMData.h
M WebCore/bindings/v8/DOMDataStore.h
M WebCore/bindings/v8/DOMDataStore.cpp
M WebCore/bindings/v8/MainThreadDOMData.h
M WebCore/bindings/v8/StaticDOMDataStore.h
M WebCore/bindings/v8/StaticDOMDataStore.cpp
M WebCore/bindings/v8/V8DOMMap.h
M WebCore/bindings/v8/V8DOMMap.cpp
M WebCore/bindings/v8/V8DOMWrapper.h
M WebCore/bindings/v8/V8DOMWrapper.cpp
M WebCore/dom/Node.h
M WebCore/dom/Node.cpp