Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Chromium-reviews
Home
About this group
Join this group
Message from discussion Follow up from http://codereview.chromium.org /17452...
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
thoma...@chromium.org  
View profile  
 More options Jan 20 2009, 5:30 pm
From: thoma...@chromium.org
Date: Tue, 20 Jan 2009 22:30:47 +0000
Local: Tues, Jan 20 2009 5:30 pm
Subject: Follow up from http://codereview.chromium.org/17452...
Print | View thread | Show original | Report this message | Find messages by this author
Reviewers: Eric Seidel (Google), darin, pink, awalker,

Description:
Follow up from http://codereview.chromium.org/17452

Remove the ifdef and instead provide a chromium api for setting the
focus color.
This lets any unittest do overrides w/o forcing other layers to know
about
layout tests.  It also provides the bottom layer so once we can plumb a
ipc
message for focus colors and send them from the browser over to the
renderer
processes.

Please review this at http://codereview.chromium.org/18424

SVN Base: svn://svn.chromium.org/chrome/trunk/src/

Affected files:
   A      
third_party/WebKit/WebCore/platform/graphics/chromium/ColorChromium.h
   M      
third_party/WebKit/WebCore/platform/graphics/chromium/ColorChromium.cpp


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google