Message from discussion
augment modal cookie prompt on mac to include details pane (issue669127)
X-BeenThere: chromium-reviews@googlegroups.com
Received: by 10.90.14.37 with SMTP id 37ls1430726agn.0.p; Wed, 10 Mar 2010
21:04:53 -0800 (PST)
Received: by 10.90.37.22 with SMTP id k22mr2838284agk.0.1268283893000;
Wed, 10 Mar 2010 21:04:53 -0800 (PST)
Received: by 10.90.37.22 with SMTP id k22mr2838277agk.0.1268283892544;
Wed, 10 Mar 2010 21:04:52 -0800 (PST)
Return-Path: <39HmYSwYMEFID1u42Cw1B862E6.8B0w1B862E6-ByF2yGC08805y0B8E9C....@apphosting.bounces.google.com>
Received: from mail-gw0-f69.google.com (mail-gw0-f69.google.com [74.125.83.69])
by gmr-mx.google.com with ESMTP id 24si712727ywh.2.2010.03.10.21.04.52;
Wed, 10 Mar 2010 21:04:52 -0800 (PST)
Received-SPF: pass (google.com: domain of 39HmYSwYMEFID1u42Cw1B862E6.8B0w1B862E6-ByF2yGC08805y0B8E9C....@apphosting.bounces.google.com designates 74.125.83.69 as permitted sender) client-ip=74.125.83.69;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 39HmYSwYMEFID1u42Cw1B862E6.8B0w1B862E6-ByF2yGC08805y0B8E9C....@apphosting.bounces.google.com designates 74.125.83.69 as permitted sender) smtp.mail=39HmYSwYMEFID1u42Cw1B862E6.8B0w1B862E6-ByF2yGC08805y0B8E9C....@apphosting.bounces.google.com
Received: by gwb15 with SMTP id 15so10780000gwb.0
for <chromium-reviews@googlegroups.com>; Wed, 10 Mar 2010 21:04:52 -0800 (PST)
MIME-Version: 1.0
Reply-To: da...@google.com, tha...@chromium.org, rse...@chromium.org,
bau...@chromium.org, chromium-reviews@googlegroups.com, j...@chromium.org,
pam+wa...@chromium.org, ben...@chromium.org, phajdan...@chromium.org
Received: by 10.91.62.3 with SMTP id p3mr502521agk.2.1268283892334; Wed, 10
Mar 2010 21:04:52 -0800 (PST)
Message-ID: <0016e64cb8a4e084df04817f5a89@google.com>
Date: Thu, 11 Mar 2010 05:04:52 +0000
Subject: Re: [Mac] augment modal cookie prompt on mac to include details pane
(issue669127)
From: tha...@chromium.org
To: da...@google.com, rse...@chromium.org, bau...@chromium.org
Cc: chromium-reviews@googlegroups.com, j...@chromium.org,
pam+wa...@chromium.org, ben...@chromium.org, phajdan...@chromium.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
I patched this in and played with it a bit.
Issues:
* When the cookie dialog is dismissed, the browser window is not
re-activated.
This works in the current dev channel.
* The spacing in the cookie dialog is pretty off. Please use IB's automatic
guides for sizing. (With the width-based tweakers, this is a lot easier if
you
make the tweaker as high as the buttons they contain)
* When opening the cookies _sheet_ in the content settings window, resizing
it
makes it look broken
http://codereview.chromium.org/669127