Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Chromium-reviews
Home
About this group
Join this group
Message from discussion Fix issue 6520
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
t...@chromium.org  
View profile  
 More options Jan 20 2009, 5:46 pm
From: t...@chromium.org
Date: Tue, 20 Jan 2009 22:46:29 +0000
Local: Tues, Jan 20 2009 5:46 pm
Subject: Fix issue 6520
Print | View thread | Show original | Report this message | Find messages by this author
Reviewers: Ben Goodger,

Description:
Fix issue 6520 by ensuring that InfoBarClosed is called whenever a tab
is closed or a navigation to a URL that is not supported by the current
TabContentsType takes place by invoking it on all InfoBarDelegates from
TabContents::Destroy(), which is the best least-common-denominator I've
found for doing this work. Alternatively I could have made
InfoBarDelegate listen for TAB_CONTENTS_DESTROYED and self-invoke
InfoBarClosed but that seemed unorthodox (relatively speaking).

This prevents InfoBarDelegates from leaking in these cases.

BUG=6520

Please review this at http://codereview.chromium.org/18381

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/alternate_nav_url_fetcher.cc
   M     chrome/browser/password_manager/password_manager.cc
   M     chrome/browser/ssl/ssl_manager.cc
   M     chrome/browser/tab_contents/infobar_delegate.h
   M     chrome/browser/tab_contents/tab_contents.cc


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google