Reduce header dependencies in chrome. (issue585008) - Chromium-reviews

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Reduce header dependencies in chrome. (issue585008)
Received-SPF: pass (google.com: domain of phist...@gmail.com designates 209.85.218.216 as permitted sender) client-ip=209.85.218.216;
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type;
        b=FeOd7/h3eQAAIWcFj75KnP15HLA/J9EzOGhr6NtzoHrirmAUIJbLdcjeCUqFFDxRzG
         JSCWPrJ+4WxMo0qy8DZ+DlgDWfG8ckAcBt0E9MXe1W+ALULB+u8gtJev0Ecna9FKkyS1
         bwofctrwlZ0CPJhsWNQD/iX7b2aVuSIp9Tmlw=
MIME-Version: 1.0
In-Reply-To: <0016368e2ee86b8ed0047f139...@google.com>
References: <0016368e2ee86b8ed0047f139...@google.com>
From: PhistucK <phist...@gmail.com>
Date: Mon, 8 Feb 2010 11:59:40 +0200
Message-ID: <f01b86fc1002080159v55a94964x8251d73a33b7b...@mail.gmail.com>
Subject: Re: [GTTF] Reduce header dependencies in chrome. (issue585008)
To: phajdan...@chromium.org, bre...@chromium.org, thes...@chromium.org, 
	phist...@gmail.com, chromium-reviews@googlegroups.com
Content-Type: multipart/alternative; boundary=000325554b2e69b32c047f13dda3

--000325554b2e69b32c047f13dda3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Your explanation is confusing and looks like you are contradicting
yourself... but maybe I am just not knowledgeable enough in programming to
understand it.

Nevermind. :) Keep up the great work.
Thank you.

=E2=98=86PhistucK


On Mon, Feb 8, 2010 at 11:40, <phajdan...@chromium.org> wrote:

> On 2010/02/08 09:30:57, PhistucK wrote:
>
>> Sorry to disturb, but I just looked at the changes and saw that you most=
ly
>>
> added
>
>> dependencies. How come this counts as "reduced header dependencies"?
>>
>
> Well, the files I touched need these #includes. For now they've been
> getting
> them implicitly through some other #include. After I reduced the number o=
f
> cases
> a .h file includes another .h file, some .cc files need to be updated. An=
d
> that's the point: some of them and not all, which means that most of the
> files
> previously depending on an unneeded .h file now no longer do.
>
> This helps when making changes to header files. The less files you need t=
o
> recompile, the faster you can work. And by reducing number of times a .h
> file
> includes another .h file one can reduce the total header file dependencie=
s.
>
>
> http://codereview.chromium.org/585008
>

--000325554b2e69b32c047f13dda3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Your=C2=A0explanation=C2=A0is confusing and looks like you=
 are contradicting yourself... but maybe I am just not knowledgeable enough=
 in programming to understand it.<div><br></div><div>Nevermind. :) Keep up =
the great work.</div>


<div>Thank you.<br><div><br clear=3D"all">=E2=98=86PhistucK<br>
<br><br><div class=3D"gmail_quote">On Mon, Feb 8, 2010 at 11:40,  <span dir=
=3D"ltr">&lt;<a href=3D"mailto:phajdan...@chromium.org" target=3D"_blank">p=
hajdan...@chromium.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_=
quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1=
ex">


<div>On 2010/02/08 09:30:57, PhistucK wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
Sorry to disturb, but I just looked at the changes and saw that you mostly<=
br>
</blockquote>
added<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
dependencies. How come this counts as &quot;reduced header dependencies&quo=
t;?<br>
</blockquote>
<br></div>
Well, the files I touched need these #includes. For now they&#39;ve been ge=
tting<br>
them implicitly through some other #include. After I reduced the number of =
cases<br>
a .h file includes another .h file, some .cc files need to be updated. And<=
br>
that&#39;s the point: some of them and not all, which means that most of th=
e files<br>
previously depending on an unneeded .h file now no longer do.<br>
<br>
This helps when making changes to header files. The less files you need to<=
br>
recompile, the faster you can work. And by reducing number of times a .h fi=
le<br>
includes another .h file one can reduce the total header file dependencies.=
<div><div></div><div><br>
<br>
<a href=3D"http://codereview.chromium.org/585008" target=3D"_blank">http://=
codereview.chromium.org/585008</a><br>
</div></div></blockquote></div><br></div></div></div>

--000325554b2e69b32c047f13dda3--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
