Received: by 10.91.93.4 with SMTP id v4mr134019agl.6.1270758504087;
        Thu, 08 Apr 2010 13:28:24 -0700 (PDT)
X-BeenThere: chromium-os-reviews@googlegroups.com
Received: by 10.90.216.14 with SMTP id o14ls14644agg.5.p; Thu, 08 Apr 2010 
	13:28:22 -0700 (PDT)
Received: by 10.90.152.18 with SMTP id z18mr775280agd.10.1270758500475;
        Thu, 08 Apr 2010 13:28:20 -0700 (PDT)
Received: by 10.90.152.18 with SMTP id z18mr775230agd.10.1270758497339;
        Thu, 08 Apr 2010 13:28:17 -0700 (PDT)
Return-Path: <3YDy-SwMME6YSYHINXUSOaS.UXMINXUSOaS-UY-XKbOKcYMUUMRKMXUaVY....@apphosting.bounces.google.com>
Received: from mail-yw0-f228.google.com (mail-yw0-f228.google.com [209.85.211.228])
        by gmr-mx.google.com with ESMTP id 12si38875gxk.14.2010.04.08.13.28.17;
        Thu, 08 Apr 2010 13:28:17 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3YDy-SwMME6YSYHINXUSOaS.UXMINXUSOaS-UY-XKbOKcYMUUMRKMXUaVY....@apphosting.bounces.google.com designates 209.85.211.228 as permitted sender) client-ip=209.85.211.228;
Received: by ywh25 with SMTP id 25so2170787ywh.12
        for <chromium-os-reviews@googlegroups.com>; Thu, 08 Apr 2010 13:28:17 -0700 (PDT)
MIME-Version: 1.0
Reply-To: m...@chromium.org
Received: by 10.101.117.5 with SMTP id u5mr272933anm.29.1270758496982; Thu, 08 
	Apr 2010 13:28:16 -0700 (PDT)
Message-ID: <001636ed7345ced77f0483bf8498@google.com>
Date: Thu, 08 Apr 2010 20:28:16 +0000
Subject: [cros-reviews] Re: Add repo_name for overlays. All overlays should 
	have repo_name defined  (issue1524021)
From: m...@chromium.org
To: te...@chromium.org, pi...@chromium.org
Cc: chromium-os-reviews@googlegroups.com, robot...@chromium.org
X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: 
	domain of 3YDy-SwMME6YSYHINXUSOaS.UXMINXUSOaS-UY-XKbOKcYMUUMRKMXUaVY....@apphosting.bounces.google.com 
	designates 209.85.211.228 as permitted sender) smtp.mail=3YDy-SwMME6YSYHINXUSOaS.UXMINXUSOaS-UY-XKbOKcYMUUMRKMXUaVY....@apphosting.bounces.google.com
X-Original-Sender: m...@chromium.org
Precedence: list
Mailing-list: list chromium-os-reviews@googlegroups.com; contact 
	chromium-os-reviews+owners@googlegroups.com
List-ID: <chromium-os-reviews.googlegroups.com>
List-Post: <http://groups.google.com/group/chromium-os-reviews/post?hl=en_US>, 
	<mailto:chromium-os-reviews@googlegroups.com>
List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:chromium-os-reviews+help@googlegroups.com>
List-Archive: <http://groups.google.com/group/chromium-os-reviews?hl=en_US>
Sender: chromium-os-reviews@googlegroups.com
List-Subscribe: <http://groups.google.com/group/chromium-os-reviews/subscribe?hl=en_US>, 
	<mailto:chromium-os-reviews+subscribe@googlegroups.com>
List-Unsubscribe: <http://groups.google.com/group/chromium-os-reviews/subscribe?hl=en_US>, 
	<mailto:chromium-os-reviews+unsubscribe@googlegroups.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

LGTM

Wish we were consistent with either ${BOARD}-${OVERLAY} or  
${BOARD}_${OVERLAY}.

Anyone know why we use one in one context and another in another context? I
guess we need the '_' as a field separator. Maybe we should clean up to use
that.

http://codereview.chromium.org/1524021/show


-- 
Subscription settings: http://groups.google.com/group/chromium-os-reviews/subscribe?hl=en