Chromium OS reviews Google Group

Re: The trousers library, to interface to the TPM. (issue505045)

2010-08-24T01:32:17Z

Can we delete this change?
[link]

[cros-reviews] Fix crashing bug where device_path is set to unknown. (issue2147006)

2010-05-25T18:05:38Z

Reviewers: Sam Leffler,

Description:
Fix crashing bug where device_path is set to unknown.
BUG=chromium-os:3251
TEST=made sure libcros still loads and everything still works.

Please review this at [link]

SVN Base: ssh://git@chromiumos-git//cros .git

[cros-reviews] Rev libcros. (issue1712029)

2010-04-30T21:54:02Z

Reviewers: dhg,

Description:
Rev libcros.

Please review this at [link]

SVN Base: ssh://git@chromiumos-git//chro miumos-overlay.git

Affected files:
A + chromeos-base/libcros/libcros- 0.0.1-r14.ebuild

Index: chromeos-base/libcros/libcros- 0.0.1-r14.ebuild

[cros-reviews] Added DisconnectFromNetwork and SetPassphrase. (issue1695032)

2010-04-30T21:44:41Z

Reviewers: Sam Leffler,

Description:
Added DisconnectFromNetwork and SetPassphrase.
BUG=none
TEST=tested new UI for disconnecting from network and setting passphrase.

Please review this at [link]

SVN Base: ssh://git@chromiumos-git//cros .git

Affected files:

[cros-reviews] Changes to support profile entries. (issue1667002)

2010-04-16T22:43:59Z

Reviewers: Sam Leffler,

Description:
Changes to support profile entries. Entries are now passed back by
GetSystemInfo()
Added SetAutoConnect() and DeleteRememberedService()
BUG=chroumium-os:2555
TEST=Use UI to exercise these methods. Network options page should show the
remembered services.

Fix bug causing some properties on entry to be saved with quotes in the name. (issue1600025)

2010-04-14T21:24:12Z

Reviewers: Sam Leffler,
Description:
Fix bug causing some properties on entry to be saved with quotes in the
name.
Please review this at [link]
Affected files:
M files/src/profile.c
Index: files/src/profile.c
diff --git a/files/src/profile.c b/files/src/profile.c

Attempt to fix crashing bug. Added more logging. (issue1518024)

2010-04-13T00:34:50Z

Reviewers: dhg,
Message:
I'm not 100% sure I found the crashing bug, but I put in a few more
safeguards
and added more logging.
Description:
Attempt to fix crashing bug. Added more logging.
BUG=chromium-os:2438
TEST=none
Please review this at [link]
Affected files:

Add sudo_clobber and sudo_append functions so that we can "echo" (issue1610021)

2010-04-12T17:28:28Z

Reviewers: msb,
Message:
As you requested :-)
Description:
Add sudo_clobber and sudo_append functions so that we can "echo"
and "cat" stuff and pipe it to something that can write to a
file as root. For example:
echo "foo" | sudo_append /tmp/bar
will append "foo" to the file /tmp/bar as root. While

Add repo_name for overlays. All overlays should have repo_name defined (issue1524021)

2010-04-08T00:42:45Z

Reviewers: msb,
Description:
Add repo_name for overlays. All overlays should have repo_name defined
since it ends up as part of binary package metadata.
Please review this at [link]
Affected files:
A src/overlays/overlay-arm-gener ic/profiles/repo_name
A src/overlays/overlay-beagleboa rd/profiles/repo_name

Remove synaptics dependency. (issue1576023)

2010-04-06T18:14:50Z

Reviewers: zel,
Message:
Related to fix for 2209.
Now we no longer need dependency on synaptics.
Description:
Remove synaptics dependency.
Please review this at [link]
Affected files:
A chromeos-base/libcros/libcros- 0.0.1-r11.ebuild
M chromeos-base/libcros/libcros- 0.0.1.ebuild

Fix synaptics to use system synclient call. (issue1520020)

2010-04-06T18:02:43Z

Reviewers: zel,
Message:
Turns out there was a problem with tap-to-click. The synaptics driver was
changed. Now I'm just using the system call to change synaptics parameters.
Description:
Fix synaptics to use system synclient call.
BUG=chromiumos-2209
TEST=Changing tap-to-click settings should now work.

Re: AU: Delta Diff Generator (issue891002)

2010-03-28T16:19:41Z

Sorry for taking so long on this. LGTM after these (mostly stylistic)
comments
are addressed.
[link]
File src/platform/update_engine/del ta_diff_generator.cc (right):
[link]
src/platform/update_engine/del ta_diff_generator.cc:63: int fd =

Re: Rev libcros for version 14. (issue1111005)

2010-03-24T23:25:05Z

LGTM
[link]

Rev libcros for version 14. (issue1111005)

2010-03-19T22:56:46Z

Reviewers: davemoore,
Message:
This is the ebuild rev for [link]
Description:
Rev libcros for version 14.
Please review this at [link]
Affected files:
A chromeos-base/libcros/libcros- 0.0.1-r10.ebuild
Index: chromeos-base/libcros/libcros- 0.0.1-r10.ebuild

rev libcros (issue1078005)

2010-03-19T19:11:09Z

Reviewers: Sam Leffler,
Description:
rev libcros
Please review this at [link]
Affected files:
A chromeos-base/libcros/libcros- 0.0.1-r9.ebuild
Index: chromeos-base/libcros/libcros- 0.0.1-r9.ebuild
diff --git a/chromeos-base/libcros/libcro s-0.0.1-r9.ebuild
b/chromeos-base/libcros/libcro s-0.0.1-r9.ebuild