Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Chromium OS reviews
Home
About this group
Contact owner to join
Fix crashing bug where device_path is set to unknown. (issue2147006)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   15 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
choc...@chromium.org  
View profile  
 More options May 25 2010, 2:05 pm
From: choc...@chromium.org
Date: Tue, 25 May 2010 18:05:38 +0000
Local: Tues, May 25 2010 2:05 pm
Subject: [cros-reviews] Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: Sam Leffler,

Description:
Fix crashing bug where device_path is set to unknown.
BUG=chromium-os:3251
TEST=made sure libcros still loads and everything still works.

Please review this at http://codereview.chromium.org/2147006/show

SVN Base: ssh://git@chromiumos-git//cros.git

Affected files:
   M chromeos_cros_api.h
   M chromeos_network.cc

Index: chromeos_cros_api.h
diff --git a/chromeos_cros_api.h b/chromeos_cros_api.h
index  
4ad1d4f294f138dd7b6dff8b74f3becbfec7b08f..c7f8c6aafbd340f812fea789b927d382d 447ab7e  
100644
--- a/chromeos_cros_api.h
+++ b/chromeos_cros_api.h
@@ -101,12 +101,13 @@
  //  34: Added GetSystemInfo. Logs returned by GetSystemInfo are consumed by
  //      the bug report dialog when submitting user feedback to Google  
Feedback
  //  35: Removed deprecated methods for input method (see v28).
+//  36: Fix crashing but with device_path set to unknown.

  namespace chromeos {  // NOLINT

  enum CrosAPIVersion {
    kCrosAPIMinVersion = 29,
-  kCrosAPIVersion = 35
+  kCrosAPIVersion = 36
  };

  // Default path to pass to  
LoadCros: "/opt/google/chrome/chromeos/libcros.so"
Index: chromeos_network.cc
diff --git a/chromeos_network.cc b/chromeos_network.cc
index  
223104f204d435f34f136a130e83c75399826ecc..57042e3a23756520dff05d7a34470eab4 1e8d98d  
100644
--- a/chromeos_network.cc
+++ b/chromeos_network.cc
@@ -353,7 +353,7 @@ void ParseServiceProperties(const  
glib::ScopedHashTable& properties,
      const gchar* path = static_cast<const gchar*>(g_value_get_boxed  
(&val));
      info->device_path = NewStringCopy(path);
    } else {
-    info->device_path = NewStringCopy(kUnknownString);
+    info->device_path = NULL;
    }
  }


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
choc...@chromium.org  
View profile  
 More options May 25 2010, 3:52 pm
From: choc...@chromium.org
Date: Tue, 25 May 2010 19:52:26 +0000
Local: Tues, May 25 2010 3:52 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:05 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:05:51 +0000
Local: Tues, May 25 2010 4:05 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:05 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:05:56 +0000
Local: Tues, May 25 2010 4:05 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:06 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:06:02 +0000
Local: Tues, May 25 2010 4:06 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:06 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:06:12 +0000
Local: Tues, May 25 2010 4:06 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:06 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:06:28 +0000
Local: Tues, May 25 2010 4:06 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:06 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:06:32 +0000
Local: Tues, May 25 2010 4:06 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:06 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:06:54 +0000
Local: Tues, May 25 2010 4:06 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:07 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:07:11 +0000
Local: Tues, May 25 2010 4:07 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:07 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:07:25 +0000
Local: Tues, May 25 2010 4:07 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:08 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:08:16 +0000
Local: Tues, May 25 2010 4:08 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:08 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:08:24 +0000
Local: Tues, May 25 2010 4:08 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
zelid...@chromium.org  
View profile  
 More options May 25 2010, 4:08 pm
From: zelid...@chromium.org
Date: Tue, 25 May 2010 20:08:37 +0000
Local: Tues, May 25 2010 4:08 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Zelidrag Hornung  
View profile  
 More options May 25 2010, 4:20 pm
From: Zelidrag Hornung <zelid...@chromium.org>
Date: Tue, 25 May 2010 13:20:33 -0700
Local: Tues, May 25 2010 4:20 pm
Subject: Re: Fix crashing bug where device_path is set to unknown. (issue2147006)
Print | Individual message | Show original | Report this message | Find messages by this author

...it's not me who went crazy here... codereview.chromium.org did :)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google