Chromium-dev Google Group

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

pierre.lafaye...@gmail.com (Pierre-Antoine LaFayette) — Wed, 06 Jan 2010 15:59:08 UT

Okay. Yes we could use data URI, but where do we retrieve the icon resources
from at that level?
2010/1/6 Darin Fisher <da...@chromium.org>

buildbot failure in Chromium on Modules XP (dbg), revision 35620

build...@chromium.org — Wed, 06 Jan 2010 11:07:23 UT

Automatically closing tree for "sbox_integration_tests" on "Modules XP (dbg)"
[link]
[link]
--=> Automatically closing tree for "sbox_integration_tests" on "Modules XP (dbg)" <=--

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

da...@chromium.org (Darin Fisher) — Wed, 06 Jan 2010 05:54:35 UT

We can also use data: URLs to inject the icons into the HTML file used to
render the directory listings. We can do that at the time when the HTML
file is generated.
-Darin

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

da...@chromium.org (Darin Fisher) — Wed, 06 Jan 2010 05:52:44 UT

Yes, exactly. Remember that ftp:// directories can be loaded in iframes by
web content. We don't want to grant any extra privileges to renderer
processes that display ftp:// content b/c those privileges could leak to
other content loaded by the same renderer if cross-site-scripting exploit
happens to exist.

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

d...@kegel.com (Dan Kegel) — Wed, 06 Jan 2010 05:28:37 UT

Try listing the tests, e.g.
$ out/Debug/tab_switching_test --gtest_list_tests
and verify the UnloadTest tests are even there.
See [link]
for where these options come from.

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

n179...@gmail.com (n179911) — Wed, 06 Jan 2010 05:23:02 UT

Thanks. but It still said '0 tests ran'
$ out/Debug/tab_switching_test
--gtest_filter=UnloadTest.Cros sSiteInfiniteBeforeUnloadSync
Note: Google Test filter = UnloadTest.CrossSiteInfiniteBe foreUnloadSync
[==========] Running 0 tests from 0 test cases.
[==========] 0 tests from 0 test cases ran. (1 ms total)

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

d...@kegel.com (Dan Kegel) — Wed, 06 Jan 2010 05:16:42 UT

Try
$ make tab_switching_test
$ out/Debug/tab_switching_test
--gtest_filter=UnloadTest.Cros sSiteInfiniteBeforeUnloadSync

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

n179...@gmail.com (n179911) — Wed, 06 Jan 2010 05:13:07 UT

Thanks for your help. But I still need some help in running a test case
For this test case defined in unload_test.cc:
TEST_F(UnloadTest, CrossSiteInfiniteBeforeUnloadS ync) {...}
i have tried:
./out/Debug/automated_ui_tests --gtest_filter='CrossSiteInfin iteUnloadSync'
./out/Debug/base_unittests --gtest_filter='CrossSiteInfin iteUnloadSync'

buildbot failure in Chromium on Webkit Mac10.5 (dbg)(3), revision 35609

build...@chromium.org — Wed, 06 Jan 2010 03:40:46 UT

Automatically closing tree for "test_shell_tests" on "Webkit Mac10.5 (dbg)(3)"
[link]
[link]
--=> Automatically closing tree for "test_shell_tests" on "Webkit Mac10.5 (dbg)(3)" <=--

buildbot failure in Chromium on Mac10.5 Tests (dbg)(1), revision 35602

build...@chromium.org — Wed, 06 Jan 2010 02:34:37 UT

Automatically closing tree for "unit_tests" on "Mac10.5 Tests (dbg)(1)"
[link]
[link]
--=> Automatically closing tree for "unit_tests" on "Mac10.5 Tests (dbg)(1)" <=--

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

est...@chromium.org (Evan Stade) — Wed, 06 Jan 2010 02:24:56 UT

this would drastically inflate the size of the extension and wouldn't match
the system icon theme

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

aba...@chromium.org (Adam Barth) — Wed, 06 Jan 2010 01:34:59 UT

Instead of DOMUI, why not use an extension to display the directory
listing? You can put the icons in the CRX.
Adam

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

e...@chromium.org (Evan Martin) — Wed, 06 Jan 2010 00:16:02 UT

I talked with Arv in person and I think I sufficiently convinced him
that getting DOMUI security right is tricky. (Consider: XSSes in the
FTP display code, and that ftp sites containing HTML pages must not
have privs when displaying the HTML.) That may still mean that DOMUI
is ok, but I would prefer to consider any other option available.

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

a...@chromium.org (Erik Arvidsson) — Tue, 05 Jan 2010 23:33:11 UT

I think it should be OK to move these to DOMUI. NTP can also link to
local HTML files and we already mark the chrome protocol in such a way
that it cannot be accessed by any other scheme.
erik
On Tue, Jan 5, 2010 at 15:19, Pierre-Antoine LaFayette

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

pierre.lafaye...@gmail.com (Pierre-Antoine LaFayette) — Tue, 05 Jan 2010 23:19:21 UT

That's why I wanted to check before starting any work. So the question is
now whether it we'd rather use a DOM UI page or create a similar API that
would be used solely by file:// and ftp://. What is needed for
[link] is simply access to the favicon data for file types.
I'm not sure if these are available through WebCore or not. The drag and