Chromium-dev Google Group

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-08T04:17:53Z

Not if you ever need to initialize another GURL with it (since the compiler
can't collapse the copy). Which is true much of the time that EmptyGURL()
can be replaced by GURL().
And the code clarity reasons still stand. Please don't do this in the name
of hoping you'll save an instruction somewhere, it's much like premature

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-08T04:00:49Z

Where as It looks like GURL::EmptyGURL() may be a tad less costly than
GURL().

Re: [chromium-dev] Where does documentation intended for non-developers go?

2010-01-08T03:44:25Z

Where was it at?

buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 35770

2010-01-08T03:14:32Z

Automatically closing tree for "compile" on "Linux Builder (ChromiumOS)"
[link]
[link]
--=> Automatically closing tree for "compile" on "Linux Builder (ChromiumOS)" <=--

Re: [chromium-dev] Build issue GL/glu.h

2010-01-08T02:27:29Z

For the incoming gpu plugin on linux, the following new packages are needed:
* mesa-common-dev
* libgl1-mesa-dev
* libglu1-mesa-dev
The gpu plugin change is not checked in yet (some of the slaves didn't
get those packages), but will shortly (hopefully tomorrow), so you
should go ahead and install those packages now. I updated

Re: [chromium-dev] Build issue GL/glu.h

2010-01-08T02:27:09Z

See the email from 3 days ago titled "PSA: new dev packages needed on linux"

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07T22:53:49Z

GCC, for one will not do so.

Build issue GL/glu.h

2010-01-07T16:14:13Z

Any idea what could be causing this thing? It's been going on for
some time now. All of my research turns up nothing.
CXX(target) out/Release/obj.target/command _buffer_service/gpu/
command_buffer/service/gles2_c md_decoder.o
In file included from ./gpu/command_buffer/common/gl es2_cmd_format.h:
16,
from gpu/command_buffer/service/gle s2_cmd_decoder.cc:

Re: [chromium-dev] Red Tree 2010/1/6

2010-01-07T19:13:46Z

I'll take the bug for now to identify the WebKit rev that caused the
regression.

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07T23:15:18Z

The limitation is still true AFAIK. Many compilers give up early in case
where function can return two objects depending on some condition.

Re: [chromium-dev] Red Tree 2010/1/6

2010-01-07T23:20:32Z

Adam reverted WebKit r52847 which appears to fix the regression. In
Chromium's r35744, Dimitri picked up Adam's fix, perf tests are green now.
Thanks Adam and Dimitri!

Re: [chromium-dev] Where does documentation intended for non-developers go?

2010-01-08T01:31:26Z

We used to have a technical FAQ but I deleted it because it was
embarrassingly out of date ("When's the Mac port coming out?"). I
think we could profitably use one again. For example, "Why does
Chrome give a warning about .exe downloads on Linux?" is definitely a
FAQ I get.

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-08T00:02:29Z

probably just a tad more costly since it involves Singleton<T>. but, i
think peter's main reason was simply to stick to the simpler and more
familiar std::string.
-darin

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-08T00:01:52Z

There are a couple reasons. Code clarity and consistency is a primary one;
using EmptyString() implies you _need_ EmptyString() and that the default
constructor won't work, which can be confusing. (I am especially frustrated
with code like "std::string x(EmptyString());".) For folks used to using

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07T23:45:06Z

Out of curiosity, what is wrong with using EmptyString() in those
cases? Is there a correctness problem? Unnecessary inclusion of
string_util.h?
- a