This change should be fairly uneventful to you. You will just notice a bunch of files being deleted and re-checked out once you next sync.
If you hack on WebCore, then you are already committing your changes upstream to svn.webkit.org, and this change shouldn't matter to you.
If you are a WebKit merger, then this changes everything. Now, instead of running the merge script, you will just be responsible for rolling DEPS to the next good revision of WebKit (and making corresponding fixes to the chromium repository as usual). Dimitri will be sending out details about how this process will work.
On Fri, May 8, 2009 at 9:49 AM, Darin Fisher <da...@chromium.org> wrote: > I just committed a change that deletes our local copy of WebCore and > JavaScriptCore (we use the wtf/ directory from here). > http://src.chromium.org/viewvc/chrome?view=rev&revision=15644 > This change should be fairly uneventful to you. You will just notice a > bunch of files being deleted and re-checked out once you next sync
gclient sync now crashes for me:
svn: '/home/dank/chromium/src/third_party/WebKit/WebCore' is not under version c ontrol Traceback (most recent call last): File "/home/dank/chromium/depot_tools/release/gclient.py", line 1643, in <modu le> result = Main(sys.argv) File "/home/dank/chromium/depot_tools/release/gclient.py", line 1638, in Main return DispatchCommand(command, options, args) File "/home/dank/chromium/depot_tools/release/gclient.py", line 1569, in Dispa tchCommand return command_map[command](options, args) File "/home/dank/chromium/depot_tools/release/gclient.py", line 1489, in DoUpd ate return client.RunOnDeps('update', args) File "/home/dank/chromium/depot_tools/release/gclient.py", line 1221, in RunOn Deps scm.RunCommand(command, self._options, args, file_list) File "/home/dank/chromium/depot_tools/release/gclient.py", line 668, in RunCom mand return commands[command](options, args, file_list) File "/home/dank/chromium/depot_tools/release/gclient.py", line 725, in update '.') File "/home/dank/chromium/depot_tools/release/gclient.py", line 561, in Captur eSVNInfo dom = xml.dom.minidom.parseString(info) File "/usr/lib/python2.5/xml/dom/minidom.py", line 1925, in parseString return expatbuilder.parseString(string) File "/usr/lib/python2.5/xml/dom/expatbuilder.py", line 940, in parseString return builder.parseString(string) File "/usr/lib/python2.5/xml/dom/expatbuilder.py", line 223, in parseString parser.Parse(string, True) xml.parsers.expat.ExpatError: no element found: line 3, column 0
Deleting the WebCore lines from .gclient_entries didn't help :-(
On Fri, May 8, 2009 at 10:06 AM, Dan Kegel <daniel.r.ke...@gmail.com> wrote: > On Fri, May 8, 2009 at 9:49 AM, Darin Fisher <da...@chromium.org> wrote: > > I just committed a change that deletes our local copy of WebCore and > > JavaScriptCore (we use the wtf/ directory from here). > > http://src.chromium.org/viewvc/chrome?view=rev&revision=15644 > > This change should be fairly uneventful to you. You will just notice a > > bunch of files being deleted and re-checked out once you next sync
> gclient sync now crashes for me:
> svn: '/home/dank/chromium/src/third_party/WebKit/WebCore' is not under > version c > ontrol > Traceback (most recent call last): > File "/home/dank/chromium/depot_tools/release/gclient.py", line 1643, in > <modu > le> > result = Main(sys.argv) > File "/home/dank/chromium/depot_tools/release/gclient.py", line 1638, in > Main > return DispatchCommand(command, options, args) > File "/home/dank/chromium/depot_tools/release/gclient.py", line 1569, in > Dispa > tchCommand > return command_map[command](options, args) > File "/home/dank/chromium/depot_tools/release/gclient.py", line 1489, in > DoUpd > ate > return client.RunOnDeps('update', args) > File "/home/dank/chromium/depot_tools/release/gclient.py", line 1221, in > RunOn > Deps > scm.RunCommand(command, self._options, args, file_list) > File "/home/dank/chromium/depot_tools/release/gclient.py", line 668, in > RunCom > mand > return commands[command](options, args, file_list) > File "/home/dank/chromium/depot_tools/release/gclient.py", line 725, in > update > '.') > File "/home/dank/chromium/depot_tools/release/gclient.py", line 561, in > Captur > eSVNInfo > dom = xml.dom.minidom.parseString(info) > File "/usr/lib/python2.5/xml/dom/minidom.py", line 1925, in parseString > return expatbuilder.parseString(string) > File "/usr/lib/python2.5/xml/dom/expatbuilder.py", line 940, in > parseString > return builder.parseString(string) > File "/usr/lib/python2.5/xml/dom/expatbuilder.py", line 223, in > parseString > parser.Parse(string, True) > xml.parsers.expat.ExpatError: no element found: line 3, column 0
> Deleting the WebCore lines from .gclient_entries didn't help :-(
> I guess I'll try to reinitialize...
That's unfortunate... I wonder what is different about your setup. The buildbots and trybots and my personal Linux box were all happy with the change.
Maybe just try deleting all of third_party/WebKit, and then re-run gclient sync.
On Fri, May 8, 2009 at 10:16 AM, Darin Fisher <da...@chromium.org> wrote: >> gclient sync now crashes for me:
> That's unfortunate... I wonder what is different about your setup. The > buildbots and trybots and my personal Linux box were all happy with the > change. > Maybe just try deleting all of third_party/WebKit, and then re-run gclient > sync.
On Fri, May 8, 2009 at 10:20 AM, Dan Kegel <daniel.r.ke...@gmail.com> wrote:
> On Fri, May 8, 2009 at 10:16 AM, Darin Fisher <da...@chromium.org> wrote: >>> gclient sync now crashes for me:
>> That's unfortunate... I wonder what is different about your setup. The >> buildbots and trybots and my personal Linux box were all happy with the >> change. >> Maybe just try deleting all of third_party/WebKit, and then re-run gclient >> sync.
> Yes, that worked.
I also had to delete third_party/WebKit. Gclient sync was crashing in CaptureSVNInfo() because the svn info --xml output was a skeleton XML file.
On Fri, May 8, 2009 at 10:31 AM, Lei Zhang <thes...@chromium.org> wrote:
> On Fri, May 8, 2009 at 10:20 AM, Dan Kegel <daniel.r.ke...@gmail.com>
> wrote:
> > On Fri, May 8, 2009 at 10:16 AM, Darin Fisher <da...@chromium.org>
> wrote:
> >>> gclient sync now crashes for me:
> >> That's unfortunate... I wonder what is different about your setup. The
> >> buildbots and trybots and my personal Linux box were all happy with the
> >> change.
> >> Maybe just try deleting all of third_party/WebKit, and then re-run
> gclient
> >> sync.
> > Yes, that worked.
> I also had to delete third_party/WebKit. Gclient sync was crashing in
> CaptureSVNInfo() because the svn info --xml output was a skeleton XML
> file.
On Fri, May 8, 2009 at 10:35 AM, Darin Fisher <da...@chromium.org> wrote:
> On Fri, May 8, 2009 at 10:31 AM, Lei Zhang <thes...@chromium.org> wrote:
>> On Fri, May 8, 2009 at 10:20 AM, Dan Kegel <daniel.r.ke...@gmail.com>
>> wrote:
>> > On Fri, May 8, 2009 at 10:16 AM, Darin Fisher <da...@chromium.org>
>> > wrote:
>> >>> gclient sync now crashes for me:
>> >> That's unfortunate... I wonder what is different about your setup. The
>> >> buildbots and trybots and my personal Linux box were all happy with the
>> >> change.
>> >> Maybe just try deleting all of third_party/WebKit, and then re-run
>> >> gclient
>> >> sync.
>> > Yes, that worked.
>> I also had to delete third_party/WebKit. Gclient sync was crashing in
>> CaptureSVNInfo() because the svn info --xml output was a skeleton XML
>> file.
On Fri, May 8, 2009 at 9:49 AM, Darin Fisher <da...@chromium.org> wrote: > I just committed a change that deletes our local copy of WebCore and > JavaScriptCore (we use the wtf/ directory from here). > http://src.chromium.org/viewvc/chrome?view=rev&revision=15644
> This change should be fairly uneventful to you. You will just notice a > bunch of files being deleted and re-checked out once you next sync.
|
