Re: UI 'accurateness' control (issue7240029)

7 views
Skip to first unread message

apa...@chromium.org

unread,
Jun 27, 2011, 5:03:43 AM6/27/11
to peter...@gmail.com, chromedev...@googlegroups.com
LGTM


http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java#newcode29
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java:29:
AccuratenessControl(Composite composite, String[] pathSegments, int
initialAccuratenessValue) {
You might want to use the Eclipse IPath/Path types instead

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties#newcode1
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties:1:
AccuratenessControl_LESS_BUTTON0=< Less
Please rename the constant

http://codereview.chromium.org/7240029/

peter...@gmail.com

unread,
Jun 27, 2011, 12:39:07 PM6/27/11
to apa...@chromium.org, chromedev...@googlegroups.com

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java#newcode29
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/AccuratenessControl.java:29:
AccuratenessControl(Composite composite, String[] pathSegments, int
initialAccuratenessValue) {

On 2011/06/27 09:03:43, apavlov wrote:
> You might want to use the Eclipse IPath/Path types instead

I thought about this, but I ruled out there's no need to add an extra
dependency for no profit.

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties#newcode1
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messages.properties:1:
AccuratenessControl_LESS_BUTTON0=< Less

On 2011/06/27 09:03:43, apavlov wrote:
> Please rename the constant

OMG, didn't see this. Thanks
Done

http://codereview.chromium.org/7240029/

Reply all
Reply to author
Forward
0 new messages