Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
chromedevtools-dev
Home
+ new post
About this group
Join this group
UI 'accurateness' control (issue7240029)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
apav...@chromium.org  
View profile  
 More options Jun 27 2011, 5:03 am
From: apav...@chromium.org
Date: Mon, 27 Jun 2011 09:03:43 +0000
Local: Mon, Jun 27 2011 5:03 am
Subject: Re: UI 'accurateness' control (issue7240029)
Print | Individual message | Show original | Report this message | Find messages by this author
LGTM

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/Accur atenessControl.java
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/Accur atenessControl.java:29:
AccuratenessControl(Composite composite, String[] pathSegments, int
initialAccuratenessValue) {
You might want to use the Eclipse IPath/Path types instead

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messa ges.properties
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messa ges.properties:1:
AccuratenessControl_LESS_BUTTON0=< Less
Please rename the constant

http://codereview.chromium.org/7240029/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
peter.ry...@gmail.com  
View profile  
 More options Jun 27 2011, 12:39 pm
From: peter.ry...@gmail.com
Date: Mon, 27 Jun 2011 16:39:07 +0000
Local: Mon, Jun 27 2011 12:39 pm
Subject: Re: UI 'accurateness' control (issue7240029)
Print | Individual message | Show original | Report this message | Find messages by this author

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/Accur atenessControl.java
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/Accur atenessControl.java:29:
AccuratenessControl(Composite composite, String[] pathSegments, int
initialAccuratenessValue) {
On 2011/06/27 09:03:43, apavlov wrote:

> You might want to use the Eclipse IPath/Path types instead

I thought about this, but I ruled out there's no need to add an extra
dependency for no profit.

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messa ges.properties
(right):

http://codereview.chromium.org/7240029/diff/1/plugins/org.chromium.de...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/propertypages/messa ges.properties:1:
AccuratenessControl_LESS_BUTTON0=< Less
On 2011/06/27 09:03:43, apavlov wrote:

> Please rename the constant

OMG, didn't see this. Thanks
Done

http://codereview.chromium.org/7240029/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google