Allow breakpoint enable and properties ruler actions for all breakpoints (issue 10918154)

[peter...@gmail.com]

Reviewers: apavlov,

Description:
Allow breakpoint enable and properties ruler actions for all breakpoints


Please review this at http://codereview.chromium.org/10918154/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java


Index:
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
diff --git
a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
index
9ea11cffeb354b85c97a883052a94c7286410570..842560970f84ebcad65de65528999c3f8a8fd3f0
100644
---
a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
+++
b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
@@ -8,16 +8,14 @@ import
org.chromium.debug.core.model.ChromiumExceptionBreakpoint;
import org.chromium.debug.core.model.ChromiumLineBreakpoint;
import org.eclipse.debug.core.model.IBreakpoint;
import org.eclipse.jface.action.IAction;
+import org.eclipse.jface.preference.PreferenceDialog;
import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
-import org.eclipse.jface.viewers.ISelectionProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
-import org.eclipse.jface.viewers.StructuredSelection;
import org.eclipse.jface.window.IShellProvider;
import org.eclipse.ui.IObjectActionDelegate;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.IWorkbenchPartSite;
-import org.eclipse.ui.dialogs.PropertyDialogAction;
+import org.eclipse.ui.dialogs.PreferencesUtil;

/**
* Action to bring up the breakpoint properties dialog.
@@ -78,23 +76,10 @@ public abstract class JsBreakpointPropertiesAction
implements IObjectActionDeleg
};
}

- protected static void runAction(final IBreakpoint breakpoint,
IShellProvider shell) {
- PropertyDialogAction action =
- new PropertyDialogAction(shell,
- new ISelectionProvider() {
- public void
addSelectionChangedListener(ISelectionChangedListener listener) {
- }
+ protected static void runAction(IBreakpoint breakpoint, IShellProvider
shell) {
+ PreferenceDialog propertyDialog =
PreferencesUtil.createPropertyDialogOn(
+ shell.getShell(), breakpoint, (String) null, (String[]) null,
null);

- public ISelection getSelection() {
- return new StructuredSelection(breakpoint);
- }
-
- public void
removeSelectionChangedListener(ISelectionChangedListener listener) {
- }
-
- public void setSelection(ISelection selection) {
- }
- });
- action.run();
+ propertyDialog.open();
}
}
Index:
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java
diff --git
a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java
b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java
index
87d019454703e023fad35e4ba18a5d1baf6c4392..1f11c8d0eb0e2e2bb921e1579be20b404133adbf
100755
---
a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java
+++
b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java
@@ -33,18 +33,11 @@ public class JsBreakpointPropertiesRulerAction extends
RulerBreakpointAction imp
}

public void update() {
- breakpoint = null;
- IBreakpoint activeBreakpoint = getBreakpoint();
- if (activeBreakpoint != null &&
- activeBreakpoint instanceof ChromiumLineBreakpoint) {
- breakpoint = activeBreakpoint;
- }
+ breakpoint = getBreakpoint();
setEnabled(breakpoint != null);
}

-
public static class Delegate extends AbstractRulerActionDelegate {
-
@Override
protected IAction createAction(ITextEditor editor, IVerticalRulerInfo
rulerInfo) {
return new JsBreakpointPropertiesRulerAction(editor, rulerInfo);

[apa...@chromium.org]

LGTM

http://codereview.chromium.org/10918154/