Groups

chromedevtools-codereview

1–30 of 261

Welcome to code-review watch group of project

Google Chrome Developer Tools for Java
http://code.google.com/p/chromedevtools/

0 selected

apa...@chromium.org

5/14/13

Re: Catch up with protocol (issue 14743016)

lgtm https://codereview.chromium.org/14743016/

unread,

Re: Catch up with protocol (issue 14743016)

lgtm https://codereview.chromium.org/14743016/

5/14/13

apa...@chromium.org

4/30/13

Re: Fix race condition in breakpoint synchronization helper (issue 14460007)

lgtm https://codereview.chromium.org/14460007/

unread,

Re: Fix race condition in breakpoint synchronization helper (issue 14460007)

lgtm https://codereview.chromium.org/14460007/

4/30/13

apa...@chromium.org

4/18/13

Re: Fix number property sorting and optimize hasProperty call in Debugger (issue 14195023)

lgtm https://codereview.chromium.org/14195023/

unread,

Re: Fix number property sorting and optimize hasProperty call in Debugger (issue 14195023)

lgtm https://codereview.chromium.org/14195023/

4/18/13

apa...@chromium.org, Peter Rybin3

4/3/13

Re: Fullfill couple of TODOs (issue 12328046)

got distracted. done. thanks! 2013/4/3 <apa...@chromium.org>: > not closed yet? > >

unread,

Re: Fullfill couple of TODOs (issue 12328046)

got distracted. done. thanks! 2013/4/3 <apa...@chromium.org>: > not closed yet? > >

4/3/13

peter...@gmail.com, apa...@chromium.org2

2/22/13

Fullfill couple of TODOs (issue 12328046)

lgtm https://codereview.chromium.org/12328046/

unread,

Fullfill couple of TODOs (issue 12328046)

lgtm https://codereview.chromium.org/12328046/

2/22/13

peter...@gmail.com, apa...@chromium.org4

2/21/13

Move setValue operation into a separate JsDeclarativeVariable interface (issue 12300043)

Committed manually as r1141 (presubmit successful). https://codereview.chromium.org/12300043/

unread,

Move setValue operation into a separate JsDeclarativeVariable interface (issue 12300043)

Committed manually as r1141 (presubmit successful). https://codereview.chromium.org/12300043/

2/21/13

peter...@gmail.com, apa...@chromium.org4

2/20/13

In LiveEdit API expose important control-flow parameter (fixing TODO) (issue 12323002)

Committed manually as r1140 (presubmit successful). https://codereview.chromium.org/12323002/

unread,

In LiveEdit API expose important control-flow parameter (fixing TODO) (issue 12323002)

Committed manually as r1140 (presubmit successful). https://codereview.chromium.org/12323002/

2/20/13

peter...@gmail.com2

2/19/13

Drop TODO for getVmVersion method (issue 12324002)

Committed manually as r1139 (presubmit successful). https://codereview.chromium.org/12324002/

unread,

Drop TODO for getVmVersion method (issue 12324002)

Committed manually as r1139 (presubmit successful). https://codereview.chromium.org/12324002/

2/19/13

peter...@gmail.com2

2/19/13

Fix tests compilation (issue 12316003)

Committed manually as r1138 (presubmit successful). https://codereview.chromium.org/12316003/

unread,

Fix tests compilation (issue 12316003)

Committed manually as r1138 (presubmit successful). https://codereview.chromium.org/12316003/

2/19/13

apa...@chromium.org, peter...@gmail.com2

2/18/13

Re: Support set variable value for WebKit protocol (issue 12287017)

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/

unread,

Re: Support set variable value for WebKit protocol (issue 12287017)

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/

2/18/13

peter...@gmail.com

2/15/13

Support set variable value for WebKit protocol (issue 12287017)

Reviewers: apavlov, Description: Support set variable value for WebKit protocol Please review this at

unread,

Support set variable value for WebKit protocol (issue 12287017)

Reviewers: apavlov, Description: Support set variable value for WebKit protocol Please review this at

2/15/13

peter...@gmail.com

2/15/13

Catch up with chrome /json protocol (issue 12285013)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Catch up with chrome /json

unread,

Catch up with chrome /json protocol (issue 12285013)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Catch up with chrome /json

2/15/13

peter...@gmail.com, apa...@chromium.org2

2/15/13

Catch up with WIP (issue 12261048)

LGTM On 2013/02/14 23:57:16, Peter Rybin wrote: > mailto:TBD=apa...@chromium.org TBD - not

unread,

Catch up with WIP (issue 12261048)

LGTM On 2013/02/14 23:57:16, Peter Rybin wrote: > mailto:TBD=apa...@chromium.org TBD - not

2/15/13

peter...@gmail.com

1/28/13

Re: Disaply compile error position in editor (issue 12040008)

https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/org/chromium/

unread,

Re: Disaply compile error position in editor (issue 12040008)

https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/org/chromium/

1/28/13

peter...@gmail.com, apa...@chromium.org5

1/24/13

Disaply compile error position in diff viewer (issue 12035015)

https://codereview.chromium.org/12035015/diff/6003/plugins/org.chromium.debug.ui/src/org/chromium/

unread,

Disaply compile error position in diff viewer (issue 12035015)

https://codereview.chromium.org/12035015/diff/6003/plugins/org.chromium.debug.ui/src/org/chromium/

1/24/13

peter...@gmail.com

1/24/13

Add 'type' field to tab enumeration JSON protocol (issue 12036084)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Add 'type' field to tab

unread,

Add 'type' field to tab enumeration JSON protocol (issue 12036084)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Add 'type' field to tab

1/24/13

peter...@gmail.com, apa...@chromium.org4

1/24/13

Disaply compile error position in editor (issue 12040008)

LGTM with a nit https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/

unread,

Disaply compile error position in editor (issue 12040008)

LGTM with a nit https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/

1/24/13

peter...@gmail.com

1/22/13

Catch up with WIP (issue 12047026)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Catch up with WIP Please review

unread,

Catch up with WIP (issue 12047026)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Catch up with WIP Please review

1/22/13

apa...@chromium.org, peter...@gmail.com3

1/21/13

Re: Expose liveedit compile error data in SDK (issue 11833010)

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/

unread,

Re: Expose liveedit compile error data in SDK (issue 11833010)

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/

1/21/13

peter...@gmail.com

1/14/13

Fix NPE (issue 11881024)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Fix NPE Please review this at

unread,

Fix NPE (issue 11881024)

Reviewers: apavlov, Message: TBR=apa...@chromium.org Description: Fix NPE Please review this at

1/14/13

peter...@gmail.com, apa...@chromium.org2

1/10/13

Add change variable UI (issue 11828047)

lgtm https://codereview.chromium.org/11828047/

unread,

Add change variable UI (issue 11828047)

lgtm https://codereview.chromium.org/11828047/

1/10/13

peter...@gmail.com, apa...@chromium.org6

1/10/13

Re: Support variable changing in SDK interface and v8 native (issue 11662019)

On 2013/01/10 14:28:48, Peter Rybin wrote: > > Not sure what you mean. I implied something like

unread,

Re: Support variable changing in SDK interface and v8 native (issue 11662019)

On 2013/01/10 14:28:48, Peter Rybin wrote: > > Not sure what you mean. I implied something like

1/10/13

peter...@gmail.com, apa...@chromium.org2

1/10/13

drop old backends (issue 11829027)

lgtm https://codereview.chromium.org/11829027/

unread,

drop old backends (issue 11829027)

lgtm https://codereview.chromium.org/11829027/

1/10/13

peter...@gmail.com, apa...@chromium.org4

1/10/13

fix npe issue #81 (issue 11821037)

lgtm https://codereview.chromium.org/11821037/

unread,

fix npe issue #81 (issue 11821037)

lgtm https://codereview.chromium.org/11821037/

1/10/13

peter...@gmail.com, apa...@chromium.org3

1/10/13

Fix NPE part 2 (issue 11833019)

lgtm https://codereview.chromium.org/11833019/

unread,

Fix NPE part 2 (issue 11833019)

lgtm https://codereview.chromium.org/11833019/

1/10/13

peter...@gmail.com

1/9/13

Expose liveedit compile error data in SDK (issue 11833010)

Reviewers: apavlov, Description: Expose liveedit compile error data in SDK Please review this at

unread,

Expose liveedit compile error data in SDK (issue 11833010)

Reviewers: apavlov, Description: Expose liveedit compile error data in SDK Please review this at

1/9/13

peter...@gmail.com2

1/9/13

Re: Redesign scope API, separate declarative and object scopes. (issue 11602013)

https://codereview.chromium.org/11602013/

unread,

Re: Redesign scope API, separate declarative and object scopes. (issue 11602013)

https://codereview.chromium.org/11602013/

1/9/13

peter...@gmail.com, apa...@chromium.org2

12/27/12

Redesign scope API, separate declarative and object scopes. (issue 11602013)

lgtm with comments https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.

unread,

Redesign scope API, separate declarative and object scopes. (issue 11602013)

lgtm with comments https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.

12/27/12

peter...@gmail.com, Alexander Pavlov2

12/26/12

Rename JsVariableImpl -> JsVariableBase (issue 11659028)

LGTM On Wed, Dec 26, 2012 at 9:08 PM, <peter...@gmail.com> wrote: Reviewers: apavlov,

unread,

Rename JsVariableImpl -> JsVariableBase (issue 11659028)

LGTM On Wed, Dec 26, 2012 at 9:08 PM, <peter...@gmail.com> wrote: Reviewers: apavlov,

12/26/12

peter...@gmail.com, apa...@chromium.org2

12/26/12

Fix JsObject#getProperties method so that it returns collection of JsObjectProperty (issue 11659026)

LGTM with comments https://codereview.chromium.org/11659026/diff/3001/plugins/org.chromium.sdk/src/

unread,

Fix JsObject#getProperties method so that it returns collection of JsObjectProperty (issue 11659026)

LGTM with comments https://codereview.chromium.org/11659026/diff/3001/plugins/org.chromium.sdk/src/

12/26/12

Search

Clear search

Close search

Google apps

Main menu