#873: Update RoutesDispatcher to handle RESTful URL requests - cherrypy-tickets

8 messages - Collapse all

CherryPy

View profile

More options Feb 13, 11:23 am

From: CherryPy <t...@cherrypy.org>

Date: Fri, 13 Feb 2009 16:23:40 -0000

Local: Fri, Feb 13 2009 11:23 am

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: fumanchu
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: CherryPy code | Resolution:
Keywords: |
---------------------------+----------------------------------------------- -
Comment (by guest):

This does indeed appear to cause a problem in cherrypy-3.1.1:

{{{
Traceback (most recent call last):
File "/usr/lib/python2.5/site-
packages/CherryPy-3.1.1-py2.5.egg/cherrypy/_cprequest.py", line 600, in
respond
self.process_body()
File "/usr/lib/python2.5/site-
packages/CherryPy-3.1.1-py2.5.egg/cherrypy/_cprequest.py", line 718, in
process_body
keep_blank_values=1)
File "/usr/lib/python2.5/site-
packages/CherryPy-3.1.1-py2.5.egg/cherrypy/_cpcgifs.py", line 8, in
__init__
cgi.FieldStorage.__init__(self, *args, **kwds)
File "/usr/lib/python2.5/cgi.py", line 532, in __init__
self.read_urlencoded()
File "/usr/lib/python2.5/cgi.py", line 637, in read_urlencoded
qs = self.fp.read(self.length)
File "/usr/lib/python2.5/site-
packages/CherryPy-3.1.1-py2.5.egg/cherrypy/wsgiserver/__init__.py", line
199, in read
data = self.rfile.read(size)
File "/usr/lib/python2.5/site-
packages/CherryPy-3.1.1-py2.5.egg/cherrypy/wsgiserver/__init__.py", line
791, in read
data = self.recv(left)
File "/usr/lib/python2.5/site-
packages/CherryPy-3.1.1-py2.5.egg/cherrypy/wsgiserver/__init__.py", line
747, in recv
return self._sock.recv(size)
timeout: timed out
}}}

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply to author Forward

CherryPy

View profile

More options Feb 16, 5:08 am

From: CherryPy <t...@cherrypy.org>

Date: Mon, 16 Feb 2009 10:08:37 -0000

Local: Mon, Feb 16 2009 5:08 am

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

Correction: It still works with fastcgi.

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply to author Forward

CherryPy

View profile

More options Apr 1, 3:05 pm

From: CherryPy <t...@cherrypy.org>

Date: Wed, 01 Apr 2009 19:05:58 -0000

Local: Wed, Apr 1 2009 3:05 pm

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: lawouach
Type: enhancement | Status: assigned
Priority: low | Milestone:
Component: CherryPy code | Resolution:
Keywords: |
---------------------------+----------------------------------------------- -
Changes (by lawouach):

* owner: fumanchu => lawouach
* priority: normal => low
* status: new => assigned

Comment:

Personally I would rather see this on the tools wiki and not add more
semantic to the current Routes dispatcher.

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply to author Forward

CherryPy

View profile

More options May 16, 11:03 pm

From: CherryPy <t...@cherrypy.org>

Date: Sun, 17 May 2009 03:03:00 -0000

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: lawouach
Type: enhancement | Status: assigned
Priority: low | Milestone:
Component: CherryPy code | Resolution:
Keywords: |
---------------------------+----------------------------------------------- -
Comment (by jroesslein):

Here is a patch that fixes this issue. Also controllers are now loaded
when needed.
When mapping the controller class, not object, should be provided.

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply to author Forward

CherryPy

View profile

More options May 16, 11:09 pm

From: CherryPy <t...@cherrypy.org>

Date: Sun, 17 May 2009 03:09:13 -0000

Local: Sat, May 16 2009 11:09 pm

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: lawouach
Type: enhancement | Status: assigned
Priority: low | Milestone:
Component: CherryPy code | Resolution:
Keywords: |
---------------------------+----------------------------------------------- -
Comment (by jroesslein):

Opps forgot the patch.

[http://pastebin.ca/1425103]

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply to author Forward

CherryPy

View profile

More options May 19, 4:07 am

From: CherryPy <t...@cherrypy.org>

Date: Tue, 19 May 2009 08:07:37 -0000

Local: Tues, May 19 2009 4:07 am

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: lawouach
Type: enhancement | Status: assigned
Priority: low | Milestone:
Component: CherryPy code | Resolution:
Keywords: |
---------------------------+----------------------------------------------- -
Comment (by lawouach):

Which issue does the patch fix? The original post was about making the
RoutesDispatcher based on the HTTP method, I don't see how the attached
patch does that.

In any case, I'm really not a big fan of lazy object creation without some
sort of caching and I'm even less happy with a cache on the dispatcher.

I'm also wondering if lazy object creation actually improves performances
overall. I'd like more input to make a decision but as it stands I doubt
it's a good idea.

--
Ticket URL: <http://cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply to author Forward

CherryPy

View profile

More options Oct 28, 3:03 pm

From: CherryPy <t...@cherrypy.org>

Date: Wed, 28 Oct 2009 19:03:48 -0000

Local: Wed, Oct 28 2009 3:03 pm

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply
  |
  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: lawouach
Type: enhancement | Status: assigned
Priority: low | Milestone:
Component: CherryPy code | Resolution:
Keywords: |
---------------------------+----------------------------------------------- -
Comment (by delagoya):

Hi all. I want to close this issue. The default RoutesDispatcher is fine.
You can use wsgi middleware to set REQUEST_METHOD from a form "_method"
hidden input. I think this would be a better way to go.

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply Reply to author Forward

CherryPy

View profile

More options Nov 1, 10:46 am

From: CherryPy <t...@cherrypy.org>

Date: Sun, 01 Nov 2009 15:46:17 -0000

Local: Sun, Nov 1 2009 10:46 am

Subject: Re: [CherryPy] #873: Update RoutesDispatcher to handle RESTful URL requests

  Reply
  |
  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

#873: Update RoutesDispatcher to handle RESTful URL requests
---------------------------+----------------------------------------------- -
Reporter: delagoya | Owner: lawouach
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: CherryPy code | Resolution: toolfix
Keywords: |
---------------------------+----------------------------------------------- -
Changes (by fumanchu):

* resolution: => toolfix
* status: assigned => closed

--
Ticket URL: <http://www.cherrypy.org/ticket/873>
CherryPy <http://www.cherrypy.org>
CherryPy - a pythonic, object-oriented HTTP framework

Reply Reply to author Forward

End of messages

« Back to Discussions

« Newer topic

Older topic »