Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Patches pending commit for 2.3
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Felix Schwarz  
View profile  
 More options Apr 2 2010, 9:21 am
From: Felix Schwarz <felix.schw...@web.de>
Date: Fri, 02 Apr 2010 15:21:59 +0200
Local: Fri, Apr 2 2010 9:21 am
Subject: Patches pending commit for 2.3

Hi,

today I committed a few trivial patches to the 2.3.x branch. Now I glanced
over the bugs for newer versions to find out if there is more stuff that needs
backporting.

This is my preliminary queue of pending patches, feel free to comment/discuss:
- #995 - CherryPy 2.3.0 regression with Python 2.5
   http://www.bitbucket.org/felixschwarz/cp2-candidates/src/tip/invalid_...
   Even though Python changed it's behavior for Python 2.5+, I don't see any
   actual change in the tests so I have to commit that without any test case...

   Interestingly this is fixed differently in 3.1 and trunk. Also 3.0 misses
   the fix completely. To me the fix in 3.1 (r1765) looks a bit better so I'm
   tempted to backport this instead of the patch in #995.

   Also #735 which is the original issue is still open. I think it should be
   closed again as it changed scope (it was fixed but no in the version the
   last commenter wanted)

- #868 - traceback returned when CherryPy receives invalid cookie
   http://www.bitbucket.org/felixschwarz/cp2-candidates/src/tip/invalid_...
   backport of r2175

- #951 - Content-Length breaks curl on 100-Continue
   no patch yet but looks interesting enough to warant a backport.

Debian also ships a patch for the autoreloader:
http://patch-tracker.debian.org/package/python-cherrypy/2.3.0-3
Basically it's a backport of later changes to _cpengine so I guess that can go
in as well...

fs

  smime.p7s
6K Download

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Christoph Zwerschke  
View profile  
 More options Apr 2 2010, 11:20 am
From: Christoph Zwerschke <c...@online.de>
Date: Fri, 02 Apr 2010 17:20:09 +0200
Local: Fri, Apr 2 2010 11:20 am
Subject: Re: [cherrypy-devel] Patches pending commit for 2.3
Am 02.04.2010 15:21 schrieb Felix Schwarz:

> Interestingly this is fixed differently in 3.1 and trunk. Also 3.0 misses
> the fix completely. To me the fix in 3.1 (r1765) looks a bit better so I'm
> tempted to backport this instead of the patch in #995.

Do you mean http://www.cherrypy.org/changeset/1765? To me that's the
uglies fix of all. Either output cookie with sep="\n" and then split
with "\n", or output cookie with no (i.e. default) sep, and then split
with splitlines() - the splitlines() handles all kinds of line seps. The
latter method looks like the cleanest solution to me, plus it also
obviates the need for the "if cookie" statement since the list will be
empty in this case.

> Also #735 which is the original issue is still open. I think it
> should be closed again as it changed scope (it was fixed but no in
> the version the last commenter wanted)

Right, that's the same issue and can be closed then.

 From my side, I don't have any more patches for 2.3.1; I noticed the
deprecation of sha and md5 in Py 2.6 was already handled in r2662.

-- Christoph


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Robert Brewer  
View profile  
 More options Apr 2 2010, 12:40 pm
From: "Robert Brewer" <fuman...@aminus.org>
Date: Fri, 2 Apr 2010 09:40:32 -0700
Local: Fri, Apr 2 2010 12:40 pm
Subject: RE: [cherrypy-devel] Patches pending commit for 2.3

Felix Schwarz wrote:
> today I committed a few trivial patches to the 2.3.x branch.

Thanks!

> Now I glanced over the bugs for newer versions to find out
> if there is more stuff that needs backporting.

> This is my preliminary queue of pending patches, feel free to
> comment/discuss:
> - #995 - CherryPy 2.3.0 regression with Python 2.5
>    http://www.bitbucket.org/felixschwarz/cp2-
> candidates/src/tip/invalid_cookies
>    Even though Python changed it's behavior for Python 2.5+, I don't
> see any
>    actual change in the tests so I have to commit that without any test
> case...

> Interestingly this is fixed differently in 3.1 and trunk. Also 3.0
> misses the fix completely.

Right; 2.3.0 was released after 3.0.0.

> To me the fix in 3.1 (r1765) looks a bit better
> so I'm
>    tempted to backport this instead of the patch in #995.

>    Also #735 which is the original issue is still open. I think it
> should be
>    closed again as it changed scope (it was fixed but no in the version
> the
>    last commenter wanted)

Fine by me.

> - #868 - traceback returned when CherryPy receives invalid cookie
>    http://www.bitbucket.org/felixschwarz/cp2-
> candidates/src/tip/invalid_cookies
>    backport of r2175

> - #951 - Content-Length breaks curl on 100-Continue
>    no patch yet but looks interesting enough to warant a backport.

> Debian also ships a patch for the autoreloader:
> http://patch-tracker.debian.org/package/python-cherrypy/2.3.0-3
> Basically it's a backport of later changes to _cpengine so I guess that
> can go
> in as well...

Yes, as long as that doesn't require upgrading to CP 3's process package. The inheritance/interaction between cherrypy.server and .engine changed significantly from CP2 to CP3.

Robert Brewer
fuman...@aminus.org


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »