Am 02.04.2010 15:21 schrieb Felix Schwarz:
> Interestingly this is fixed differently in 3.1 and trunk. Also 3.0 misses
> the fix completely. To me the fix in 3.1 (r1765) looks a bit better so I'm
> tempted to backport this instead of the patch in #995.
Do you mean
http://www.cherrypy.org/changeset/1765? To me that's the
uglies fix of all. Either output cookie with sep="\n" and then split
with "\n", or output cookie with no (i.e. default) sep, and then split
with splitlines() - the splitlines() handles all kinds of line seps. The
latter method looks like the cleanest solution to me, plus it also
obviates the need for the "if cookie" statement since the list will be
empty in this case.
> Also #735 which is the original issue is still open. I think it
> should be closed again as it changed scope (it was fixed but no in
> the version the last commenter wanted)
Right, that's the same issue and can be closed then.
From my side, I don't have any more patches for 2.3.1; I noticed the
deprecation of sha and md5 in Py 2.6 was already handled in r2662.
-- Christoph