[CCPPETMR/SIRF-SuperBuild] Add option to build UCL/petmr-rd-tools (#89)
Ben Thomas
Will build UCL/petmr-rd-tools if requested. Not that both ITK and glog are required to successfully build. I have left them out of the dependency list in External_petmr_rd_tools.cmake. Once happy, we should add this to the VM.
You can view, comment on, or merge this pull request online at:
https://github.com/CCPPETMR/SIRF-SuperBuild/pull/89
Commit Summary
- Add petmr-rd-tools to SuperBuild
- Remove ITK and glog as project dependencies
File Changes
- M SuperBuild.cmake (5)
- A SuperBuild/External_petmr_rd_tools.cmake (98)
- M version_config.cmake (15)
Patch Links:
- https://github.com/CCPPETMR/SIRF-SuperBuild/pull/89.patch
- https://github.com/CCPPETMR/SIRF-SuperBuild/pull/89.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Kris Thielemans
why not have ITK as project dependency? We can build it... would have to enable the BUILD_ITK option then if this one is build.
Ben Thomas
Can do. Will need to enable USE_SYSTEM_ITK option.
Kris Thielemans
why? Are you saying petmr-rd-tools fails if we're building ITK itself? In that case, there's no point in enabling the dependency of course.
Kris Thielemans
The relevant option to enable our own is USE_ITK
Ben Thomas
@bathomas pushed 1 commit.
- 0e491de Build ITK if needed by petmr-rd-tools
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Kris Thielemans
thanks. we could add 1 build in Travis (adding glog to the dependencies) but let's leave this for later. Also, we'll merge this after 1.0.0-rc.1
Ben Thomas
@bathomas pushed 1 commit.
- 73c2e87 Glog for petmr-rd-tools
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Kris Thielemans
Merged #89.